Skip to content

Commit 01b86e7

Browse files
authored
docs: clarify cluster version change impact for ClusterGenerator, CMP Plugins and migration (argoproj#26851)
Signed-off-by: reggie-k <regina.voloshin@codefresh.io>
1 parent 182e4c6 commit 01b86e7

2 files changed

Lines changed: 24 additions & 5 deletions

File tree

docs/operator-manual/applicationset/Generators-Cluster.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,14 @@ spec:
152152
- clusters:
153153
selector:
154154
matchLabels:
155-
argocd.argoproj.io/kubernetes-version: 1.28
155+
argocd.argoproj.io/kubernetes-version: v1.28.1
156156
# matchExpressions are also supported.
157157
#matchExpressions:
158158
# - key: argocd.argoproj.io/kubernetes-version
159159
# operator: In
160160
# values:
161-
# - "1.27"
162-
# - "1.28"
161+
# - "v1.27.1"
162+
# - "v1.28.1"
163163
```
164164

165165
### Pass additional key-value pairs via `values` field

docs/operator-manual/upgrading/3.2-3.3.md

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,26 @@ This design change improves repository cleanliness, reduces unnecessary commit n
7373
Review your automation workflows and repository maintenance scripts to ensure that old or unwanted files in application paths are cleaned up if necessary. Consider implementing a periodic manual or automated cleanup procedure if your use case requires it.
7474
- For more details on current behavior, see the [Source Hydrator user guide](../../user-guide/source-hydrator.md).
7575

76+
### Cluster version format change
77+
78+
**New behavior:**
79+
80+
3.3.3 now stores the cluster version in a more detailed format, `vMajor.Minor.Patch` compared to the previous format `Major.Minor`.
81+
82+
This change is aligning how ArgoCD interprets K8s cluster version with how Helm `3.19.0` and above interprets it.
83+
84+
This change makes it easier to compare versions and to support future features. It also allows for more accurate version comparisons and better compatibility with future Kubernetes releases.
85+
86+
87+
**Impact:**
88+
89+
Application Sets with Cluster Generators, that fetch clusters based on their Kubernetes version and use `argocd.argoproj.io/auto-label-cluster-info` on the cluster secret, need to be updated to use `argocd.argoproj.io/kubernetes-version` with the `vMajor.Minor.Patch` format instead of the previous `Major.Minor` format.
90+
More details [here](../applicationset/Generators-Cluster.md#fetch-clusters-based-on-their-k8s-version).
91+
92+
Additionally, API, UI and CLI commands that retrieve cluster information now return the version in the `vMajor.Minor.Patch` format.
93+
94+
The env variable $KUBE_VERSION that is used with Argo CD CMP Plugins remains unchanged and returns the version in `Major.Minor.Patch` format, so CMP Plugins are not impacted.
95+
7696
### Anonymous call to Settings API returns fewer fields
7797

7898
The Settings API now returns less information when accessed anonymously.
@@ -92,8 +112,7 @@ removed in a future release.
92112

93113
## Helm Upgraded to 3.19.4
94114

95-
Argo CD v3.3 upgrades the bundled Helm version to 3.19.4. There are no breaking changes in Helm 3.19.4 according to the
96-
[release notes](https://github.com/helm/helm/releases/tag/v3.19.0).
115+
Argo CD v3.3 upgrades the bundled Helm version to 3.19.4. This Helm release interprets K8s version in a semantic version format of `vMajor.Minor.Patch`, instead of the previous `vMajor.Minor` format. This led to a breaking change in Argo CD described [above](#cluster-version-format-change).
97116

98117
## Kustomize Upgraded to 5.8.1
99118

0 commit comments

Comments
 (0)