fixed lint errors

Author: ATGardner

acr_controller/application/client.go

@@ -54,7 +54,7 @@ func NewHttpApplicationClient(token string, address string, rootpath string) App
 }
 
 func (c *httpApplicationClient) execute(ctx context.Context, url string, result interface{}) error {
-	req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		return err
 	}

acr_controller/service/acr_service.go

@@ -180,7 +180,7 @@ func getCurrentRevisionFromOperation(a *application.Application) string {
 }
 
 func (c *acrService) getRevisions(_ context.Context, a *application.Application) (string, string) {
-	if a.Status.History == nil || len(a.Status.History) == 0 {
+	if len(a.Status.History) == 0 {
 		// it is first sync operation, and we have only current revision
 		return getCurrentRevisionFromOperation(a), ""
 	}

cmd/argocd-repo-server/commands/argocd_repo_server.go

@@ -81,7 +81,7 @@ func NewCommand() *cobra.Command {
 		helmRegistryMaxIndexSize              string
 		disableManifestMaxExtractedSize       bool
 		includeHiddenDirectories              bool
-		cmpUseManifestGeneratePaths       bool
+		cmpUseManifestGeneratePaths           bool
 	)
 	command := cobra.Command{
 		Use:               cliName,

event_reporter/application/client.go

@@ -61,7 +61,7 @@ func NewHttpApplicationClient(token string, address string, rootpath string) App
 }
 
 func (c *httpApplicationClient) execute(ctx context.Context, url string, result interface{}) error {
-	req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		return err
 	}
@@ -124,12 +124,12 @@ func (c *httpApplicationClient) GetManifests(ctx context.Context, in *appclient.
 	if in.Revision != nil {
 		params = fmt.Sprintf("%s&revision=%s", params, *in.Revision)
 	}
-	if in.SourcePositions != nil && len(in.SourcePositions) > 0 {
+	if len(in.SourcePositions) > 0 {
 		for _, sourcePosition := range in.SourcePositions {
 			params = fmt.Sprintf("%s&sourcePositions=%d", params, sourcePosition)
 		}
 	}
-	if in.Revisions != nil && len(in.Revisions) > 0 {
+	if len(in.Revisions) > 0 {
 		for _, revision := range in.Revisions {
 			params = fmt.Sprintf("%s&revisions=%s", params, revision)
 		}

event_reporter/reporter/app_revision.go

@@ -12,7 +12,7 @@ import (
 
 // treats multi-sourced apps as single source and gets first revision details
 func getApplicationLegacyRevisionDetails(a *v1alpha1.Application, revisionsWithMetadata *utils.AppSyncRevisionsMetadata) *v1alpha1.RevisionMetadata {
-	if revisionsWithMetadata.SyncRevisions == nil || len(revisionsWithMetadata.SyncRevisions) == 0 {
+	if len(revisionsWithMetadata.SyncRevisions) == 0 {
 		return nil
 	}
 
@@ -66,7 +66,7 @@ func (s *applicationEventReporter) getRevisionsDetails(ctx context.Context, a *v
 func (s *applicationEventReporter) getApplicationRevisionsMetadata(ctx context.Context, logCtx *log.Entry, a *v1alpha1.Application) (*utils.AppSyncRevisionsMetadata, error) { //nolint:golint,unparam
 	result := &utils.AppSyncRevisionsMetadata{}
 
-	if a.Status.Sync.Revision != "" || a.Status.Sync.Revisions != nil || (a.Status.History != nil && len(a.Status.History) > 0) {
+	if a.Status.Sync.Revision != "" || a.Status.Sync.Revisions != nil || len(a.Status.History) > 0 {
 		// can be the latest revision of repository
 		operationSyncRevisionsMetadata, err := s.getRevisionsDetails(ctx, a, utils.GetOperationSyncRevisions(a))
 		if err != nil {

event_reporter/reporter/event_payload_test.go

@@ -78,8 +78,8 @@ func TestGetResourceEventPayload(t *testing.T) {
 		err = json.Unmarshal(event.Payload, &eventPayload)
 		require.NoError(t, err)
 
-		assert.Equal(t, "{ \"key\" : \"manifest\" }", eventPayload.Source.DesiredManifest)
-		assert.Equal(t, "{ \"key\" : \"manifest\" }", eventPayload.Source.ActualManifest)
+		assert.JSONEq(t, "{ \"key\" : \"manifest\" }", eventPayload.Source.DesiredManifest)
+		assert.JSONEq(t, "{ \"key\" : \"manifest\" }", eventPayload.Source.ActualManifest)
 	})
 
 	t.Run("Deleting timestamp not empty", func(t *testing.T) {

event_reporter/utils/app.go

@@ -59,7 +59,7 @@ func revisionsToCheck(obj RevisionsData, fieldToCheck *AppRevisionsFieldNames) b
 	}
 
 	if *fieldToCheck == AppRevisionsFieldName {
-		return obj.Revisions != nil && len(obj.Revisions) > 0
+		return len(obj.Revisions) > 0
 	}
 	return true
 }

event_reporter/utils/app_revision.go

@@ -41,7 +41,7 @@ func GetLatestAppHistoryId(a *appv1.Application) int64 {
 }
 
 func getLatestAppHistoryItem(a *appv1.Application) *appv1.RevisionHistory {
-	if a.Status.History != nil && len(a.Status.History) > 0 {
+	if len(a.Status.History) > 0 {
 		return &a.Status.History[len(a.Status.History)-1]
 	}
 

pkg/codefresh/client.go

@@ -77,7 +77,7 @@ func (c *CodefreshClient) SendEvent(ctx context.Context, appName string, event *
 			return err
 		}
 
-		req, err := http.NewRequestWithContext(ctx, "POST", url, io.NopCloser(&buf))
+		req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, io.NopCloser(&buf))
 		if err != nil {
 			return err
 		}
@@ -111,7 +111,7 @@ func (c *CodefreshClient) SendGraphQL(query GraphQLQuery) (*json.RawMessage, err
 		return nil, err
 	}
 
-	req, err := http.NewRequest("POST", c.cfConfig.BaseURL+"/2.0/api/graphql", bytes.NewBuffer(queryJSON))
+	req, err := http.NewRequest(http.MethodPost, c.cfConfig.BaseURL+"/2.0/api/graphql", bytes.NewBuffer(queryJSON))
 	if err != nil {
 		return nil, err
 	}

pkg/codefresh/client_test.go

@@ -44,6 +44,7 @@ func TestCodefreshClient_SendEvent(t *testing.T) {
 			authToken: "some-token",
 			payload:   []byte(`{"key": "value"}`),
 			beforeFn: func(t *testing.T, rt *MockRoundTripper) {
+				t.Helper()
 				rt.On("RoundTrip", mock.Anything).Run(func(args mock.Arguments) {
 					req := args.Get(0).(*http.Request)
 					assert.Equal(t, "POST", req.Method, "invalid request method")
@@ -57,7 +58,7 @@ func TestCodefreshClient_SendEvent(t *testing.T) {
 					require.NoError(t, err, "failed to read request body")
 					assert.JSONEq(t, `{"data":{"key":"value"}}`, string(body), "invalid request body")
 				}).Return(&http.Response{
-					StatusCode: 200,
+					StatusCode: http.StatusOK,
 				}, nil)
 			},
 		},
@@ -67,11 +68,12 @@ func TestCodefreshClient_SendEvent(t *testing.T) {
 			authToken: "some-token",
 			payload:   []byte(`{"key": "value"}`),
 			beforeFn: func(t *testing.T, rt *MockRoundTripper) {
+				t.Helper()
 				rt.On("RoundTrip", mock.Anything).Run(func(args mock.Arguments) {
 					req := args.Get(0).(*http.Request)
 					assert.Equal(t, "http://some.host/2.0/api/events", req.URL.String(), "invalid request URL")
 				}).Return(&http.Response{
-					StatusCode: 200,
+					StatusCode: http.StatusOK,
 				}, nil)
 			},
 		},