fix: OCI client, avoid calling tags/list if revision is not a constraint argoproj#23580 (argoproj#23581)

Signed-off-by: Diego Erdody <diego.erdody@dexterity.ai>
Co-authored-by: Diego Erdody <diego.erdody@dexterity.ai>

Author: erdody

util/oci/client.go

@@ -295,6 +295,11 @@ func (c *nativeOCIClient) DigestMetadata(ctx context.Context, digest string) (*i
 func (c *nativeOCIClient) ResolveRevision(ctx context.Context, revision string, noCache bool) (string, error) {
 	digest, err := c.resolveDigest(ctx, revision) // Lookup explicit revision
 	if err != nil {
+		// If the revision is not a semver constraint, just return the error
+		if !versions.IsConstraint(revision) {
+			return digest, err
+		}
+
 		tags, err := c.GetTags(ctx, noCache)
 		if err != nil {
 			return "", fmt.Errorf("error fetching tags: %w", err)

util/oci/client_test.go

@@ -374,7 +374,7 @@ func Test_nativeOCIClient_ResolveRevision(t *testing.T) {
 			fields: fields{repo: store, tagsFunc: func(context.Context, string) (tags []string, err error) {
 				return []string{"1.0.0", "1.1.0", "1.2.0", "2.0.0"}, nil
 			}},
-			expectedError: errors.New("no version for constraints: failed to determine semver constraint: improper constraint: sha256:abc123"),
+			expectedError: errors.New("cannot get digest for revision sha256:abc123: sha256:abc123: not found"),
 		},
 		{
 			name:     "resolve latest tag",

util/versions/tags.go

@@ -62,3 +62,12 @@ func MaxVersion(revision string, tags []string) (string, error) {
 	log.Debugf("Semver constraint '%s' resolved to version '%s'", constraints.String(), maxVersion.Original())
 	return maxVersion.Original(), nil
 }
+
+// Returns true if the given revision is not an exact semver and can be parsed as a semver constraint
+func IsConstraint(revision string) bool {
+	if _, err := semver.NewVersion(revision); err == nil {
+		return false
+	}
+	_, err := semver.NewConstraint(revision)
+	return err == nil
+}

util/versions/tags_test.go

@@ -65,3 +65,27 @@ func TestTags_MaxVersion(t *testing.T) {
 		require.Error(t, err)
 	})
 }
+
+func TestTags_IsConstraint(t *testing.T) {
+	t.Run("Exact", func(t *testing.T) {
+		assert.False(t, IsConstraint("0.5.3"))
+	})
+	t.Run("Exact nonsemver", func(t *testing.T) {
+		assert.False(t, IsConstraint("2024.03-LTS-RC19"))
+	})
+	t.Run("Constraint", func(t *testing.T) {
+		assert.True(t, IsConstraint("= 0.5.3"))
+	})
+	t.Run("Constraint", func(t *testing.T) {
+		assert.True(t, IsConstraint("> 0.5.3"))
+	})
+	t.Run("Constraint", func(t *testing.T) {
+		assert.True(t, IsConstraint(">0.5.0,<0.7.0"))
+	})
+	t.Run("Constraint", func(t *testing.T) {
+		assert.True(t, IsConstraint("0.7.*"))
+	})
+	t.Run("Constraint", func(t *testing.T) {
+		assert.True(t, IsConstraint("*"))
+	})
+}