Skip to content

Commit 779ae02

Browse files
lodash security fixes (#3)
* lodash security fixes
1 parent 8d7b294 commit 779ae02

5 files changed

Lines changed: 3179 additions & 9 deletions

File tree

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ api/**/*.js
99
.coverdata
1010
debug
1111
reports
12-
coverage
12+
coverage
13+
.idea

handler.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var Q = require('q');
22
var CFError = require('cf-errors');
3-
var ErrorTypes = CFError.errorTypes;
3+
var ErrorTypes = CFError.Errors;
44

55
var Handler = function (headers) {
66

@@ -52,4 +52,4 @@ var Handler = function (headers) {
5252
return newHandler;
5353
};
5454

55-
module.exports = Handler;
55+
module.exports = Handler;

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ var Q = require('q');
77
var request = require('request');
88
var _ = require('lodash');
99
var CFError = require('cf-errors');
10-
var ErrorTypes = CFError.errorTypes;
10+
var ErrorTypes = CFError.Errors;
1111
var Fs = require("fs");
1212
var Handler = require("./handler.js");
1313

@@ -47,7 +47,7 @@ module.exports.create = Factory;
4747
deferred.resolve();
4848
}
4949
else {
50-
deferred.reject(new CFError(ErrorTypes.Error, "failed to retrieve api metadata from url:%s", self.config.url));
50+
deferred.reject(new CFError(ErrorTypes.Error, 'failed to retrieve api metadata from url: ' + self.config.url));
5151
}
5252
});
5353
}

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
{
22
"name": "cf-api-lib",
3-
"version": "0.0.3",
3+
"version": "0.0.4",
44
"description": "NodeJS client for API servers",
55
"dependencies": {
6-
"cf-errors": "git+https://github.com/codefresh-io/cf-errors.git#24eeeab7e67e13e0edc011d4d97996f4ca71c31c",
7-
"lodash": "^3.10.1",
6+
"cf-errors": "^0.1.15",
7+
"lodash": "4.17.20",
88
"mime": "^1.2.11",
99
"q": "^1.4.1",
10-
"request": "^2.60.0"
10+
"request": "2.88.2"
1111
},
1212
"devDependencies": {
1313
"optimist": "~0.6.0",

0 commit comments

Comments
 (0)