fix: bitbucket server and cloud provider selection (#801)

## What
<!-- What is changing in this PR? -->

## Why
<!-- Why are these changes being made? -->

## Notes
<!-- Add any additional notes here -->

Author: kim-codefresh

Makefile

@@ -1,4 +1,4 @@
-VERSION=v0.2.16
+VERSION=v0.2.17
 
 OUT_DIR=dist
 YEAR?=$(shell date +"%Y")

cmd/commands/helm_test.go

@@ -539,7 +539,7 @@ global:
       username: some-username`,
 			gitProvider: platmodel.GitProvidersGithub,
 			gitApiUrl:   "some-api-url",
-			wantErr:     "failed verifying runtime git token with git server \"some-api-url\": invalid git-token: Head \"some-api-url\": some error",
+			wantErr:     "failed verifying runtime git token with git server \"some-api-url\": invalid git-token: Head \"/api/v3\": some error",
 			beforeFn: func(rt *gitmocks.MockRoundTripper) {
 				rt.EXPECT().RoundTrip(gomock.AssignableToTypeOf(&http.Request{})).Times(1).Return(nil, errors.New("some error"))
 			},

internal/git/provider.go

@@ -184,9 +184,10 @@ func getProvider(providerType ProviderType, cloneURL, certFile string) (Provider
 
 func getGitProviderFromUserSelect(baseURL string, client *http.Client) Provider {
 	var providers = map[string]func(string, *http.Client) (Provider, error){
-		"Bitbucket": NewBitbucketServerProvider,
-		"GitHub":    NewGithubProvider,
-		"GitLab":    NewGitlabProvider,
+		"Bitbucket":        NewBitbucketProvider,
+		"GitHub":           NewGithubProvider,
+		"GitLab":           NewGitlabProvider,
+		"Bitbucket Server": NewBitbucketServerProvider,
 	}
 
 	templates := &promptui.SelectTemplates{

internal/git/provider_bitbucket-server.go

@@ -52,9 +52,7 @@ func NewBitbucketServerProvider(baseURL string, client *http.Client) (Provider,
 		return nil, fmt.Errorf("wrong domain for bitbucket-server provider: \"%s\"\n  maybe you meant to use \"bitbucket\" for the cloud git provider?", baseURL)
 	}
 
-	if u.Path == "" {
-		u.Path = BITBUCKET_SERVER_REST_ENDPOINT
-	}
+	u.Path = BITBUCKET_SERVER_REST_ENDPOINT
 
 	return &bitbucketServer{
 		providerType: BITBUCKET_SERVER,

internal/git/provider_bitbucket-server_test.go

@@ -44,9 +44,9 @@ func TestNewBitbucketServerProvider(t *testing.T) {
 			baseURL:    "https://some.server",
 			wantApiURL: "https://some.server/rest/api/1.0",
 		},
-		"should use baseUrl as apiUrl if it has path": {
+		"should ignore baseUrl path and use standard api path": {
 			baseURL:    "https://some.server/some/api/v-whatever",
-			wantApiURL: "https://some.server/some/api/v-whatever",
+			wantApiURL: "https://some.server/rest/api/1.0",
 		},
 		"should fail when base is not a valid url": {
 			baseURL: "https://contains-bad-\x7f",

internal/git/provider_bitbucket.go

@@ -37,7 +37,7 @@ type (
 
 const (
 	BITBUCKET_CLOUD_DOMAIN               = "bitbucket.org"
-	BITBUCKET_REST_ENDPOINT              = "/api/2.0"
+	BITBUCKET_CLOUD_API_URL              = "https://api.bitbucket.org/2.0"
 	BITBUCKET               ProviderType = "bitbucket"
 )
 
@@ -68,10 +68,15 @@ func NewBitbucketProvider(baseURL string, client *http.Client) (Provider, error)
 		return nil, fmt.Errorf("wrong domain for bitbucket provider: \"%s\", expected \"%s\"\n  maybe you meant to use \"bitbucket-server\" for on-prem git provider?", baseURL, BITBUCKET_CLOUD_DOMAIN)
 	}
 
-	u.Path = BITBUCKET_REST_ENDPOINT
+	// new api token working only with api.bitbucket.org/2.0
+	apiUrl, err := url.Parse(BITBUCKET_CLOUD_API_URL)
+	if err != nil {
+		return nil, err
+	}
+
 	return &bitbucket{
 		providerType: BITBUCKET,
-		apiURL:       u,
+		apiURL:       apiUrl,
 		c:            client,
 	}, nil
 }

internal/git/provider_bitbucket_test.go

@@ -42,11 +42,11 @@ func TestNewBitbucketProvider(t *testing.T) {
 	}{
 		"should use standard api path when base is host only": {
 			baseURL:    "https://bitbucket.org",
-			wantApiURL: "https://bitbucket.org/api/2.0",
+			wantApiURL: "https://api.bitbucket.org/2.0",
 		},
 		"should ignore baseUrl path if it contains it": {
 			baseURL:    "https://bitbucket.org/some/api/v-whatever",
-			wantApiURL: "https://bitbucket.org/api/2.0",
+			wantApiURL: "https://api.bitbucket.org/2.0",
 		},
 		"should fail when base is not a valid url": {
 			baseURL: "https://bitbucket.org/\x7f",
@@ -78,7 +78,7 @@ func Test_bitbucket_verifyToken(t *testing.T) {
 		beforeFn       func(c *mocks.MockRoundTripper)
 	}{
 		"Should fail if HEAD fails": {
-			wantErr: "failed checking token scope permission: failed getting current user: Head \"https://bitbucket.org/api/2.0/user\": some error",
+			wantErr: "failed checking token scope permission: failed getting current user: Head \"https://api.bitbucket.org/2.0/user\": some error",
 			beforeFn: func(c *mocks.MockRoundTripper) {
 				c.EXPECT().RoundTrip(gomock.AssignableToTypeOf(&http.Request{})).Return(nil, errors.New("some error"))
 			},

internal/git/provider_github.go

@@ -51,7 +51,7 @@ func NewGithubProvider(baseURL string, client *http.Client) (Provider, error) {
 
 	if strings.Contains(u.Hostname(), GITHUB_CLOUD_DOMAIN) {
 		u, _ = url.Parse(GITHUB_CLOUD_API_URL)
-	} else if u.Path == "" {
+	} else {
 		u.Path = GITHUB_REST_ENDPOINT
 	}
 

internal/git/provider_github_test.go

@@ -56,9 +56,9 @@ func TestNewGithubProvider(t *testing.T) {
 			wantApiURL: "https://some.server/api/v3",
 			wantCloud:  false,
 		},
-		"should use baseUrl as apiUrl if it on-prem and has path": {
+		"should ignore on-prem baseUrl path and use standard api path": {
 			baseURL:    "https://some.server/some/api/v-whatever",
-			wantApiURL: "https://some.server/some/api/v-whatever",
+			wantApiURL: "https://some.server/api/v3",
 			wantCloud:  false,
 		},
 		"should fail when base is not a valid url": {

internal/git/provider_gitlab.go

@@ -45,15 +45,18 @@ const (
 	GITLAB_CLOUD_DOMAIN               = "gitlab.com"
 	GITLAB_REST_ENDPOINT              = "/api/v4"
 	GITLAB               ProviderType = "gitlab"
+	GITLAB_CLOUD_API_URL              = "https://gitlab.com"
 )
 
 func NewGitlabProvider(baseURL string, client *http.Client) (Provider, error) {
-	u, err := url.Parse(baseURL)
+	u, err := url.Parse(baseURL) // baseURL is the isc url
 	if err != nil {
 		return nil, err
 	}
 
-	if u.Host == GITLAB_CLOUD_DOMAIN || u.Path == "" {
+	if strings.Contains(u.Hostname(), GITLAB_CLOUD_DOMAIN) {
+		u, _ = url.Parse(GITLAB_CLOUD_API_URL)
+	} else {
 		u.Path = GITLAB_REST_ENDPOINT
 	}