chore: fix issue with reading environment varibles (#914)

1. add new cli options:
- 'request-max-retries'
- 'request-retry-delay'
2. Fix reading CF_ARG_* envs
3. Add Claude context file

Author: pysarenko-bohdan

CLAUDE.md

@@ -0,0 +1,117 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project
+
+`codefresh` — the Codefresh command-line tool. A Node.js CLI built on `yargs` that talks to the Codefresh API through an OpenAPI-driven SDK (`codefresh-sdk`) and also wraps several external binaries (Stevedore, Venona, gitops controllers) on the user's machine.
+
+Node `^24.0.0` is required (see [.nvmrc](.nvmrc)). Package manager is `yarn@1.22` with `--frozen-lockfile` in CI.
+
+## Common commands
+
+```bash
+yarn install                                # install deps (use --frozen-lockfile in CI)
+yarn test                                   # jest, runs every *.spec.js with --coverage
+yarn test path/to/file.spec.js              # run a single spec file
+yarn test -t "pattern"                      # run tests whose name matches pattern
+yarn eslint                                 # lint + autofix lib/logic/**
+yarn e2e                                    # bash-driven scenarios in e2e/scenarios/*.sh (needs an authenticated CLI)
+yarn generate-completion                    # rebuilds lib/interface/cli/completion/tree.js — required by Dockerfile
+yarn build-local-docs                       # generate Hugo docs into ./temp
+yarn serve-docs                             # serve them locally; ALLOW_BETA_COMMANDS=true also includes beta cmds
+yarn pkg                                    # build native binaries with @yao-pkg/pkg (alpine/macos/linux/win, x64+arm64)
+node lib/interface/cli/codefresh <cmd>      # run the CLI directly from a clone (skipping the global `codefresh` install)
+```
+
+Jest setup is configured in [package.json](package.json) (`jest.setupFiles` → [test-setup.js](test-setup.js)). The setup mocks `Output`, `whoami`, and `request-promise`, and exposes `configureSdk()` / `verifyResponsesReturned()` as globals used throughout `*.sdk.spec.js`.
+
+## Architecture
+
+### Entry point and command discovery
+
+`lib/interface/cli/codefresh` (the `bin` entry) delegates to [commad-line-interface.js](lib/interface/cli/commad-line-interface.js) (note the spelling). On startup it:
+
+1. Recursively reads every `*.cmd.js` file under [lib/interface/cli/commands/](lib/interface/cli/commands/).
+2. Loads SDK config (`codefresh-sdk` + bundled [openapi.json](openapi.json) + cfconfig auth) — unless the invocation is `config use-context`, which is the only context-less path.
+3. Registers only commands where `isRoot()` is true. Subcommands attach to their parent via the `parent:` option in their constructor (see below).
+
+Beta commands are filtered at this top level by `context.isBetaFeatEnabled()`. The on-prem flag is filtered per-subcommand inside `Command._createBuilderFunction`.
+
+### The `Command` class
+
+[lib/interface/cli/Command.js](lib/interface/cli/Command.js) wraps yargs. Conventions every command file follows:
+
+- Each file exports a single `new Command({...})` instance (file name `*.cmd.js`).
+- Root commands set `root: true`; subcommands set `parent: require('../some/parent.cmd')` — that call also auto-registers the child via `setParentCommand`.
+- `requiresAuthentication` defaults to `true` for roots; subcommands inherit unless they override. Auth is enforced in [helpers/general.js#wrapHandler](lib/interface/cli/helpers/general.js) which also implements `--watch` (loop + `draftlog`) and the consecutive-error tolerance for watch mode.
+- `betaCommand: true` / `onPremCommand: true` gate the command behind context feature flags.
+- `webDocs: { category, title, weight }` feeds the Hugo docs generator ([docs/index.js](docs/index.js)) via `prepareDocs()`.
+- Handlers receive parsed `argv`; values can also be supplied through `CF_ARG_*` env vars (set in `commad-line-interface.js` via `yargs.env('CF_ARG_')`).
+
+When adding a new command, follow the surrounding directory's pattern — most resources have a `get.cmd.js` / `create.cmd.js` / `delete.cmd.js` triple, and bash completion is generated from sibling `*.completion.js` files.
+
+### SDK layer
+
+[lib/logic/sdk/index.js](lib/logic/sdk/index.js) exports a single shared `Codefresh` SDK instance. It is configured once at startup from `openapi.json`; downstream code does `const { sdk } = require('../../logic')` and calls methods like `sdk.pipelines.get({...})` whose names come straight from the OpenAPI spec.
+
+To add a new API endpoint there is usually no manual SDK wiring — regenerate/bump `openapi.json` and the method appears on `sdk`.
+
+### Output and entities
+
+`Output.print(data)` ([lib/output/Output.js](lib/output/Output.js)) dispatches by `--output` flag to a renderer in [lib/output/types/](lib/output/types/) (`json`, `yaml`, `table` (default + wide), `id`, `name`, `jsonArray`, `yamlArray`). When `--watch` is set, output goes through `draftlog` to overwrite in place.
+
+Domain objects under [lib/logic/entities/](lib/logic/entities/) extend [Entity.js](lib/logic/entities/Entity.js). Each entity declares `defaultColumns` / `wideColumns`; renderers call `toDefault()` / `toWide()` / `toJson()` / `toYaml()` / `toName()` / `toId()`. Table column styling (colors, status badges) lives in matching files under [lib/output/formatters/](lib/output/formatters/). `fromResponse` is the constructor convention used by command handlers.
+
+### Config storage
+
+Two distinct config files:
+
+- `~/.cfconfig` (override with `--cfconfig`) — auth contexts; managed entirely by `codefresh-sdk`.
+- `~/.Codefresh/cli-config/config.yaml` — CLI profile/preferences (request timeout, retries, pagination), managed by [lib/logic/cli-config/Manager.js](lib/logic/cli-config/Manager.js) with a JSON schema at [lib/logic/cli-config/schema.json](lib/logic/cli-config/schema.json).
+
+### External binaries
+
+The CLI shells out to several other binaries (Stevedore for cluster integration, Venona, argocd-agent, cf-gitops-controller). [lib/binary/](lib/binary/) holds:
+
+- [components.js](lib/binary/components.js) — registry of binary metadata (local dir, remote repo, version file).
+- [downloader.js](lib/binary/downloader.js) — fetches the right release from GitHub into `~/.Codefresh/<dir>/`.
+- [runner.js](lib/binary/runner.js) — `child_process.spawn` wrapper that pipes stdio through.
+
+`codefresh components update` (run inside the Docker image build) pre-populates the binaries.
+
+### Bash completion
+
+`lib/interface/cli/completion/tree.js` is **generated** by `yarn generate-completion` ([completion/generate](lib/interface/cli/completion/generate)). When `process.argv` includes `--get-yargs-completions`, [codefresh](lib/interface/cli/codefresh) takes a fast path that loads only completion logic — do not add work to the startup path that would break this. The Dockerfile runs `yarn generate-completion` during image build; the file is `.gitignored`.
+
+## Default CLI values
+
+Defaults live in two places — check both when changing or referencing them:
+
+- [lib/interface/cli/defaults.js](lib/interface/cli/defaults.js) — code-level constants exported as `DEFAULTS` (API URL, cfconfig path, pagination limits, watch interval, engine image, `~/.Codefresh` path, debug pattern). Used directly from command builders/handlers.
+- [lib/logic/cli-config/schema.json](lib/logic/cli-config/schema.json) — JSON-Schema for the user-editable profile config at `~/.Codefresh/cli-config/config.yaml`. The `default` field of each property is the fallback applied by [Manager.js](lib/logic/cli-config/Manager.js) (covers `output.pretty`, `output.dateFormat`, `request.timeout`/`maxAttempts`/`retryDelay`, `logs.fallback.*`).
+
+## Testing conventions
+
+- Unit tests: `*.spec.js`, plain jest.
+- SDK-backed integration tests: `*.sdk.spec.js`. These rely on the mocked [__mocks__/requestretry.js](__mocks__/requestretry.js) (use `request.__setResponse` / `request.__queueResponses`) and the global `verifyResponsesReturned([...])` helper from `test-setup.js`. They also call `await configureSdk()` in `beforeEach` to bind the SDK to the bundled `openapi.json` instead of a live server.
+- Jest mocks `Output`, `whoami`, and `request-promise` globally; do not assume they are real in tests.
+
+## Lint
+
+ESLint uses `airbnb-base` with overrides in [.eslintrc.js](.eslintrc.js): 4-space indent, `max-len: 140`, `no-console` and `no-underscore-dangle` disabled. Only `lib/logic/**` is wired into `yarn eslint`.
+
+## Release flow
+
+- Bumping `version` in [package.json](package.json) on `master` triggers [.github/workflows/create-release.yaml](.github/workflows/create-release.yaml), which uses `release-drafter` to publish a GitHub release.
+- Native binaries are produced with `yarn pkg` (configured under `pkg` in `package.json`).
+- The Docker image (see [Dockerfile](Dockerfile)) installs prod-only deps, runs `generate-completion`, then `npm uninstall -g corepack npm` for hardening, and symlinks `codefresh` into `/usr/local/bin/`.
+
+## Useful environment variables
+
+- `CF_ARG_<flag>` — alternative to passing `--flag` on the CLI (e.g. `CF_ARG_OUTPUT=json`).
+- `DEBUG=codefresh*` — print error stacks instead of the friendly message (see [defaults.js](lib/interface/cli/defaults.js)).
+- `ENGINE_IMAGE` — overrides the default `codefresh/engine:master` used by local pipeline runs.
+- `STEVEDORE` / `VENONACTL` — point components at an `alternateBinary` path instead of the auto-downloaded one.
+- `ALLOW_BETA_COMMANDS=true` — include beta commands when generating docs.
+- `NODE_TLS_REJECT_UNAUTHORIZED=0` — implicitly set when `--insecure` is passed.

lib/interface/cli/commad-line-interface.js

@@ -11,16 +11,20 @@ const openapi = require('../../../openapi');
 const sdk = require('../../logic/sdk');
 const cliConfHelpers = require('./helpers/cli-config');
 
-const PROCESS_ARGV = require('yargs-parser')(process.argv);
+const PROCESS_ARGV = require('yargs-parser')(process.argv, {
+    number: ['request-timeout', 'request-max-retries', 'request-retry-delay'],
+    envPrefix: 'CF_ARG_',
+});
 
 const cliConfig = configManager.config();
-
 async function getConfigForSdk(options = {}) {
     const configOptions = {
         configPath: PROCESS_ARGV.cfconfig,
         spec: { json: openapi },
         request: _.defaultsDeep({
             timeout: PROCESS_ARGV.requestTimeout,
+            maxAttempts: PROCESS_ARGV.requestMaxRetries,
+            retryDelay: PROCESS_ARGV.requestRetryDelay,
             headers: {
                 'User-Agent': `codefresh-cli-v${version}`,
                 'Codefresh-User-Agent-Type': 'cli',
@@ -76,7 +80,15 @@ async function startCommandLine() {
             },
         })
         .option('request-timeout', {
-            describe: `Request timeout (default: ${cliConfig.request.timeout})`,
+            describe: `Request timeout in ms (default: ${cliConfig.request.timeout})`,
+            global: false,
+        })
+        .option('request-max-retries', {
+            describe: `Request max retries (default: ${cliConfig.request.maxAttempts})`,
+            global: false,
+        })
+        .option('request-retry-delay', {
+            describe: `Request attempts delay in ms (default: ${cliConfig.request.retryDelay})`,
             global: false,
         })
         .demandCommand(1, 'You need at least one command before moving on')

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "1.1.4",
+  "version": "1.2.1",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,