chore: remove argo-rollouts from gitops-runtime helm chart (#1051)

* chore: remove argo-rollouts from gitops-runtime helm chart

Argo Rollouts was deprecated and disabled by default in a previous release.
This commit completes the removal by:

- Removing argo-rollouts dependency from Chart.yaml
- Removing external-argo-rollouts and argo-rollouts configuration from values.yaml
- Removing argo-rollouts helper function and component-list entry from _helpers.tpl
- Removing ROLLOUTS_HELM_REPOSITORY/VERSION env vars from app-proxy
- Removing argo-rollouts from all CI values files
- Removing argo-rollouts from multi-runtime values files
- Removing argo-rollouts tests and rollout-reporter references
- Updating README documentation to remove argo-rollouts sections
- Removing rollout-reporter from values-ha.yaml

BREAKING CHANGE: argo-rollouts is no longer included in the chart.
Users requiring Argo Rollouts must install it separately.

* chore: bump app-proxy version to 1.4020.0

Updates app-proxy to version 1.4020.0 which includes the removal of
Argo Rollouts installation capability (argo-platform#7045).

This aligns with the removal of argo-rollouts from the helm chart.

* docs: update helm chart documentation

Updates README.md to reflect:
- Removal of argo-rollouts configuration sections
- Updated app-proxy version to 1.4020.0
- Updated image enrichment versions to 1.1.20-main
- Added telemetry configuration documentation

* fix: remove extra blank line in default-values.yaml

Fixes yamllint error about too many blank lines.

Author: dmaizel

charts/gitops-runtime/Chart.yaml

@@ -26,10 +26,6 @@ dependencies:
     repository: https://codefresh-io.github.io/argo-helm
     version: 0.45.18-v3.6.7-cap-CR-32333
     condition: argo-workflows.enabled
-  - name: argo-rollouts
-    repository: https://codefresh-io.github.io/argo-helm
-    version: 2.37.3-7-v1.7.2-cap-OSS-697
-    condition: argo-rollouts.enabled
   - name: sealed-secrets
     repository: https://bitnami-labs.github.io/sealed-secrets/
     version: 2.18.0

charts/gitops-runtime/README.md

@@ -8,7 +8,6 @@
 - [Codefresh official documentation](#codefresh-official-documentation)
 - [Argo-workflows artifact and log storage](#argo-workflows-artifact-and-log-storage)
 - [Installation with External ArgoCD](#installation-with-external-argocd)
-- [Installation with External Argo Rollouts](#installation-with-external-argo-rollouts)
 - [Using with private registries - Helper utility](#using-with-private-registries---helper-utility)
 - [Openshift](#openshift)
 - [High Availability](#high-availability)
@@ -62,8 +61,6 @@ argo-workflows:
   server:
     clusterWorkflowTemplates:
       enabled: false
-argo-rollouts:
-  enabled: false
 tunnel-client:
   enabled: false
 gitops-operator:
@@ -82,8 +79,6 @@ argo-cd:
 argo-workflows:
   crds:
     install: true
-argo-rollouts:
-  installCRDs: true
 gitops-operator:
   crds:
     install: true
@@ -194,26 +189,6 @@ data:
   admin.enabled: "true"
 ```
 
-## Installation with External Argo Rollouts
-
-If you want to use an existing Argo Rollouts installation, you can disable the built-in Argo Rollouts and configure the GitOps Runtime to use the external Argo Rollouts.
-See the `values.yaml` example below:
-
-```yaml
-global:
-  # -- Configuration for external Argo Rollouts
-  external-argo-rollouts:
-    # -- Rollout reporter settings
-    rollout-reporter:
-      # -- Enable rollout reporter
-      # Configuration is defined at .Values.event-reporters.rollout
-      enabled: true
-
-argo-rollouts:
-  # -- Disable built-in Argo Rollouts
-  enabled: false
-```
-
 ## Using with private registries - Helper utility
 The GitOps Runtime comprises multiple subcharts and container images. Subcharts also vary in values structure, making it difficult to override image specific values to use private registries.
 We have created a helper utility to resolve this issue:

charts/gitops-runtime/README.md.gotmpl

@@ -60,6 +60,3 @@ global:
       username: 'username'
       password: 'dummy'
 
-
-argo-rollouts:
-  enabled: true

charts/gitops-runtime/ci/default-values-custom-tls.yaml

@@ -20,7 +20,3 @@ global:
       url: 'https://github.com'
       username: 'username'
       password: 'dummy'
-
-
-argo-rollouts:
-  enabled: true

charts/gitops-runtime/ci/default-values.yaml

@@ -18,5 +18,3 @@ global:
       url: 'https://github.com'
       username: 'username'
       password: 'dummy'
-argo-rollouts:
-  enabled: true

charts/gitops-runtime/ci/ingressless-values.yaml

@@ -23,10 +23,6 @@ global:
       username: 'username'
       password: 'dummy'
 
-argo-rollouts:
-  dashboard:
-    enabled: true
-
 argo-cd:
   redis-ha:
     enabled: true

charts/gitops-runtime/ci/values-all-images.yaml

@@ -23,10 +23,6 @@ global:
       username: 'username'
       password: 'dummy'
 
-argo-rollouts:
-  dashboard:
-    enabled: true
-
 argo-cd:
   enabled: false
 

charts/gitops-runtime/ci/values-external-argocd.yaml

@@ -123,18 +123,6 @@ Determine argocd repoServer url
   {{- end }}
 {{- end}}
 
-{{/*
-Determine rollouts name
-*/}}
-{{- define "codefresh-gitops-runtime.argo-rollouts.name" -}}
-  {{- if (index .Values "argo-rollouts" "enabled") }}
-    {{/* For now use template from rollouts chart until better approach */}}
-    {{- template "argo-rollouts.fullname" (dict "Values" (get .Values "argo-rollouts")) }}
-  {{- else }}
-    {{- printf "argo-rollouts" }}
-  {{- end }}
-{{- end }}
-
 {{/*
 Determine argocd server service port. Must be called with chart root context
 */}}
@@ -394,12 +382,6 @@ Output comma separated list of installed runtime components
     {{- $argoEvents := dict "name" "argo-events" "version" (get .Subcharts "argo-events").Chart.AppVersion }}
     {{- $comptList = append $comptList $argoEvents }}
   {{- end }}
-  {{- if index (get .Values "argo-rollouts") "enabled" }}
-    {{- $rolloutReporter := dict "name" "rollout-reporter" "version" .Chart.AppVersion }}
-    {{- $argoRollouts := dict "name" "argo-rollouts" "version" (get .Subcharts "argo-rollouts").Chart.AppVersion }}
-    {{- $comptList = append $comptList $argoRollouts }}
-    {{- $comptList = append $comptList $rolloutReporter }}
-  {{- end }}
   {{- if index (get .Values "argo-workflows") "enabled" }}
     {{- $workflowReporter := dict "name" "workflow-reporter" "version" .Chart.AppVersion }}
     {{- $argoWorkflows := dict "name" "argo-workflows" "version" (get .Subcharts "argo-workflows").Chart.AppVersion }}

charts/gitops-runtime/templates/_helpers.tpl

@@ -23,14 +23,4 @@ TARGET_RUNTIME_ACCOUNT_ID: {{ .Values.global.codefresh.accountId }}
       {{- fail "global.codefresh.accountId must be provided for hosted runtimes"}}
     {{- end }}
   {{- end }}
-{{/*
-This will promote argo-rollouts dependency version to app-proxy.
-This will be used when installing argo-rollouts using button.
-*/}}
-{{- range $d := .Chart.Dependencies }}
-{{- if eq $d.Name "argo-rollouts" }}
-ROLLOUTS_HELM_REPOSITORY: {{ $d.Repository | quote }}
-ROLLOUTS_HELM_VERSION: {{ $d.Version | quote }}
-{{- end }}
-{{- end }}
 {{- end }}