Merge pull request #1 from codefresh-io/cf-node-server-sdk-redis-feat

feat: adjust node-server-sdk-redis for codefresh

Author: vasil-cf

.gitignore

@@ -1,5 +1,4 @@
 package-lock.json
-yarn.lock
 dist/
 node_modules/
 **/*.tsbuildinfo

.nvmrc

@@ -0,0 +1 @@
+20.18.0

packages/shared/akamai-edgeworker-sdk/src/__tests__/index.test.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/extensions
 import { EdgeProvider, init, LDLogger, LDMultiKindContext, LDSingleKindContext } from '../..';
 import * as testData from './testData.json';
 

packages/store/node-server-sdk-redis/package.json

@@ -1,6 +1,6 @@
 {
-  "name": "@launchdarkly/node-server-sdk-redis",
-  "version": "3.0.11",
+  "name": "@codefresh-io/launchdarkly-node-server-sdk-redis",
+  "version": "3.0.11-codefresh.2",
   "description": "Redis-backed feature store for the LaunchDarkly Server-Side SDK for Node.js",
   "homepage": "https://github.com/launchdarkly/js-core/tree/main/packages/store/node-server-sdk-redis",
   "repository": {
@@ -11,7 +11,8 @@
   "main": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "files": [
-    "dist"
+    "dist",
+    "yarn.lock"
   ],
   "keywords": [
     "launchdarkly",
@@ -36,6 +37,7 @@
     "@launchdarkly/node-server-sdk": "8.2.4",
     "@trivago/prettier-plugin-sort-imports": "^4.1.1",
     "@types/jest": "^29.4.0",
+    "@types/redis-errors": "^1.2.3",
     "@typescript-eslint/eslint-plugin": "^6.1.0",
     "@typescript-eslint/parser": "^6.1.0",
     "eslint": "^8.45.0",

packages/store/node-server-sdk-redis/src/RedisClientState.ts

@@ -62,6 +62,7 @@ export default class RedisClientState {
     });
 
     client.on('reconnecting', (delay: number) => {
+      this.connected = false;
       this.attempt += 1;
       logger?.info(
         `Attempting to reconnect to redis (attempt # ${this.attempt}, delay: ${delay}ms)`,

packages/store/node-server-sdk-redis/src/RedisCore.ts

@@ -1,3 +1,5 @@
+import { MaxRetriesPerRequestError } from 'ioredis/built/errors';
+
 import { interfaces, LDLogger } from '@launchdarkly/node-server-sdk';
 
 import RedisClientState from './RedisClientState';
@@ -29,6 +31,7 @@ export default class RedisCore implements interfaces.PersistentDataStore {
   constructor(
     private readonly state: RedisClientState,
     private readonly logger?: LDLogger,
+    private readonly localFeatureStore?: any,
   ) {
     this.initedKey = this.state.prefixedKey('$inited');
   }
@@ -99,6 +102,50 @@ export default class RedisCore implements interfaces.PersistentDataStore {
     });
   }
 
+  #serializeItems(kind: any, itemsObj: Record<string, any>) {
+    const serializedItemsObj: Record<string, any> = {};
+    Object.keys(itemsObj).forEach((key) => {
+      const value = itemsObj[key];
+      serializedItemsObj[key] = kind.serialize(value).serializedItem;
+    });
+    return serializedItemsObj;
+  }
+
+  #prepareArray(values: Record<string, string>) {
+    const results: interfaces.KeyedItem<string, interfaces.SerializedItemDescriptor>[] = [];
+    Object.keys(values).forEach((key) => {
+      const value = values[key];
+      // When getting we do not populate version and deleted.
+      // The SDK will have to deserialize to access these values.
+      results.push({ key, item: { version: 0, deleted: false, serializedItem: value } });
+    });
+    return results;
+  }
+
+  #useItemsFromCodefresh(
+    kind: interfaces.PersistentStoreDataKind,
+    callback: (
+      descriptors: interfaces.KeyedItem<string, interfaces.SerializedItemDescriptor>[] | undefined,
+    ) => void,
+  ) {
+    this.localFeatureStore().then(
+      (items: any) => {
+        let localResults;
+        if (kind.namespace === 'features') {
+          localResults = items.features;
+        } else {
+          localResults = items.segments;
+        }
+        const serializedItems = this.#serializeItems(kind, localResults);
+        callback(this.#prepareArray(serializedItems));
+      },
+      (error: any) => {
+        console.log(error);
+        callback(undefined);
+      },
+    );
+  }
+
   getAll(
     kind: interfaces.PersistentStoreDataKind,
     callback: (
@@ -107,22 +154,17 @@ export default class RedisCore implements interfaces.PersistentDataStore {
   ): void {
     if (!this.state.isConnected() && !this.state.isInitialConnection()) {
       this.logger?.warn('Attempted to fetch all keys while Redis connection is down');
-      callback(undefined);
-      return;
+      this.#useItemsFromCodefresh(kind, callback);
     }
 
     this.state.getClient().hgetall(this.state.prefixedKey(kind.namespace), (err, values) => {
       if (err) {
         this.logger?.error(`Error fetching '${kind.namespace}' from Redis ${err}`);
+        if (err instanceof MaxRetriesPerRequestError) {
+          this.#useItemsFromCodefresh(kind, callback);
+        }
       } else if (values) {
-        const results: interfaces.KeyedItem<string, interfaces.SerializedItemDescriptor>[] = [];
-        Object.keys(values).forEach((key) => {
-          const value = values[key];
-          // When getting we do not populate version and deleted.
-          // The SDK will have to deserialize to access these values.
-          results.push({ key, item: { version: 0, deleted: false, serializedItem: value } });
-        });
-        callback(results);
+        callback(this.#prepareArray(values));
       } else {
         callback(undefined);
       }

packages/store/node-server-sdk-redis/src/RedisFeatureStore.ts

@@ -23,9 +23,10 @@ export default class RedisFeatureStore implements LDFeatureStore {
   constructor(
     options?: LDRedisOptions,
     private readonly logger?: LDLogger,
+    localFeatureStore?: any,
   ) {
     this.wrapper = new PersistentDataStoreWrapper(
-      new RedisCore(new RedisClientState(options, logger), logger),
+      new RedisCore(new RedisClientState(options, logger), logger, localFeatureStore),
       TtlFromOptions(options),
     );
   }

packages/store/node-server-sdk-redis/src/RedisFeatureStoreFactory.ts

@@ -23,7 +23,10 @@ import RedisFeatureStore from './RedisFeatureStore';
  * @returns
  *   A factory function suitable for use in the SDK configuration (LDOptions).
  */
-export default function RedisFeatureStoreFactory(options?: LDRedisOptions) {
+export default function RedisFeatureStoreFactory(
+  options?: LDRedisOptions,
+  localFeatureStore?: any,
+) {
   return (config: LDClientContext) =>
-    new RedisFeatureStore(options, config.basicConfiguration.logger);
+    new RedisFeatureStore(options, config.basicConfiguration.logger, localFeatureStore);
 }