feat: Add gitops environments resource#170
Closed
ilia-medvedev wants to merge 3 commits intomasterfrom
Closed
Conversation
ilia-medvedev
requested review from
a team,
dmelnyk-octo and
yaroslav-codefresh
as code owners
Author
|
/test |
Author
|
/test |
eti-codefresh
approved these changes
Sep 8, 2025
|
i reviewed the platform side looks good to me |
dmelnyk-octo
reviewed
Sep 8, 2025
Comment on lines
+48
to
+53
| "server": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "Target cluster server url. Defaults to `https://kubernetes.default.svc` which is the default in-cluster url", | ||
| Default: "https://kubernetes.default.svc", | ||
| }, |
Collaborator
There was a problem hiding this comment.
server should always correspond to the server of ArgoCD cluster we put in name and we don't have any validation for it on the backend. Putting random address in server can result in weird bug when in our UI we see that environment configured with cluster X, but inside it has apps from cluster Y.
What I think we should do is to remove "server" from graphql mutation input and derive it from the DB according to the provided cluster name. It should be easy change on backend side.
Author
There was a problem hiding this comment.
@denis-codefresh I agree. I did the implementation according to the current schema and it's a mandatory field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Notes
Checklist
/testcomment will be ignored by the CI trigger unless it is made by a repo admin or collaborator.