Skip to content

feat: add themed LoginResetPassword page#28

Merged
garronej merged 2 commits into
codegouvfr:mainfrom
damienlethiec:feature/add-login-reset-password-page
Nov 20, 2025
Merged

feat: add themed LoginResetPassword page#28
garronej merged 2 commits into
codegouvfr:mainfrom
damienlethiec:feature/add-login-reset-password-page

Conversation

@damienlethiec

Copy link
Copy Markdown
Contributor
  • Add LoginResetPassword.tsx with DSFR theming
  • Add Storybook stories for testing (Default and WithUsernameError)
  • Integrate page into KcPage router
  • Use DSFR Input component with proper error handling
  • Add "Back to login" link with DSFR styling
  • Follow existing code patterns from LoginUpdatePassword
image

- Add LoginResetPassword.tsx with DSFR theming
- Add Storybook stories for testing (Default and WithUsernameError)
- Integrate page into KcPage router
- Use DSFR Input component with proper error handling
- Add "Back to login" link with DSFR styling
- Follow existing code patterns from LoginUpdatePassword
@LoicArc

LoicArc commented Nov 20, 2025

Copy link
Copy Markdown

I don't think Keycloak will throw any error when the username/email is not found as this would be a security threat, so this may not needs to be implemented in this theme
https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html#forgot-password-request

@garronej

Copy link
Copy Markdown
Collaborator

I don't think Keycloak will throw any error when the username/email is not found as this would be a security threat, so this may not needs to be implemented in this theme

You're right but this is just a page you get to when you click on the "Pasword forgoten?" of the login page.

@garronej

Copy link
Copy Markdown
Collaborator

@damienlethiec You're the real MVP

Signed-off-by: Joseph Garrone <joseph.garrone@data.gouv.fr>
@garronej
garronej merged commit 8bb7fff into codegouvfr:main Nov 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants