You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The type assertion is intentional. It ensures we destructure all props explicitly, so nothing is unintentionally passed via rest. Without this, rest wouldn’t be inferred as never, and we could accidentally miss props without noticing.
We do spread rest onto the <div> to allow custom or non-standard HTML attributes, but that naturally leads to type issues that user needs to explicitly ignore.
To resolve this without compromising type safety, I’d suggest introducing a dedicated prop nativeDivElement. That’s consistent with the pattern we’ve followed elsewhere in the codebase, and it allows us to keep the Equals<keyof rest, never> check valid and meaningful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#434
I believe all valid HTML attributes for a
I removed the type assertion. I'm not sure why it was there in the first place.