Skip to content

Commit 066003d

Browse files
committed
remove skipped rules that no longer applies
1 parent 651988a commit 066003d

File tree

1 file changed

+4
-27
lines changed

1 file changed

+4
-27
lines changed

rector.php

Lines changed: 4 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
2323
use Rector\CodingStyle\Rector\FuncCall\VersionCompareFuncCallToConstantRector;
2424
use Rector\Config\RectorConfig;
25-
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
2625
use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
27-
use Rector\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector;
2826
use Rector\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector;
2927
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
3028
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
@@ -99,26 +97,11 @@
9997
__DIR__ . '/tests/_support/Test/TestForReflectionHelper.php',
10098
],
10199

102-
RemoveUnusedConstructorParamRector::class => [
103-
// there are deprecated parameters
104-
__DIR__ . '/system/Debug/Exceptions.php',
105-
// @TODO remove if deprecated $httpVerb is removed
106-
__DIR__ . '/system/Router/AutoRouterImproved.php',
107-
// @TODO remove if deprecated $config is removed
108-
__DIR__ . '/system/HTTP/Request.php',
109-
__DIR__ . '/system/HTTP/Response.php',
110-
],
111-
112100
// Exclude test file because `is_cli()` is mocked and Rector might remove needed parameters.
113101
RemoveExtraParametersRector::class => [
114102
__DIR__ . '/tests/system/Debug/ToolbarTest.php',
115103
],
116104

117-
// check on constant compare
118-
UnwrapFutureCompatibleIfPhpVersionRector::class => [
119-
__DIR__ . '/system/Autoloader/Autoloader.php',
120-
],
121-
122105
UnderscoreToCamelCaseVariableNameRector::class => [
123106
// session handlers have the gc() method with underscored parameter `$max_lifetime`
124107
__DIR__ . '/system/Session/Handlers',
@@ -137,6 +120,10 @@
137120
__DIR__ . '/tests/system/Debug/ExceptionsTest.php',
138121
],
139122

123+
DeclareStrictTypesTestsRector::class => [
124+
__DIR__ . '/tests/system/Debug/ExceptionsTest.php',
125+
],
126+
140127
// use mt_rand instead of random_int on purpose on non-cryptographically random
141128
RandomFunctionRector::class,
142129

@@ -153,19 +140,13 @@
153140
],
154141

155142
ReturnNeverTypeRector::class => [
156-
__DIR__ . '/system/Cache/Handlers/BaseHandler.php',
157-
__DIR__ . '/system/Cache/Handlers/MemcachedHandler.php',
158-
__DIR__ . '/system/Cache/Handlers/WincacheHandler.php',
159-
__DIR__ . '/system/CodeIgniter.php',
160143
__DIR__ . '/system/Database/MySQLi/Utils.php',
161144
__DIR__ . '/system/Database/OCI8/Utils.php',
162145
__DIR__ . '/system/Database/Postgre/Utils.php',
163146
__DIR__ . '/system/Database/SQLSRV/Utils.php',
164147
__DIR__ . '/system/Database/SQLite3/Utils.php',
165148
__DIR__ . '/system/HTTP/DownloadResponse.php',
166149
__DIR__ . '/system/HTTP/SiteURI.php',
167-
__DIR__ . '/system/Helpers/kint_helper.php',
168-
__DIR__ . '/tests/_support/Autoloader/FatalLocator.php',
169150
],
170151

171152
// Unnecessary (string) is inserted
@@ -184,10 +165,6 @@
184165
// some tests extended by other tests
185166
FinalizeTestCaseClassRector::class,
186167

187-
DeclareStrictTypesTestsRector::class => [
188-
__DIR__ . '/tests/system/Debug/ExceptionsTest.php',
189-
],
190-
191168
RemoveNullArgOnNullDefaultParamRector::class => [
192169
// skip form query usage, easier to read
193170
__DIR__ . '/system/Model.php',

0 commit comments

Comments
 (0)