Skip to content

Commit 153c355

Browse files
committed
fix: generate inputs for all route params in Debug Toolbar
1 parent 3da7a20 commit 153c355

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

system/Debug/Toolbar/Views/toolbar.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ var ciDebugBar = {
762762
var rowGet = this.toolbar.querySelectorAll(
763763
'td[data-debugbar-route="GET"]'
764764
);
765-
var patt = /\((?:[^)(]+|\((?:[^)(]+|\([^)(]*\))*\))*\)/;
765+
var patt = /\(.+?\)/g;
766766

767767
for (var i = 0; i < rowGet.length; i++) {
768768
row = rowGet[i];
@@ -788,10 +788,9 @@ var ciDebugBar = {
788788
'<form data-debugbar-route-tpl="' +
789789
ciDebugBar.trimSlash(row.innerText.replace(patt, "?")) +
790790
'">' +
791-
row.innerText.replace(
792-
patt,
793-
'<input id="debugbar-route-id-' + i + '" type="text" placeholder="$1">'
794-
) +
791+
row.innerText.replace(patt, function (match) {
792+
return '<input type="text" placeholder="' + match + '">';
793+
}) +
795794
'<input type="submit" value="Go" class="debug-bar-mleft4">' +
796795
"</form>";
797796
}

user_guide_src/source/changelogs/v4.7.1.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Bugs Fixed
4444
- **Model:** Fixed a bug where ``BaseModel::updateBatch()`` threw an exception when ``updateOnlyChanged`` was ``true`` and the index field value did not change.
4545
- **Session:** Fixed a bug in ``MemcachedHandler`` where the constructor incorrectly threw an exception when ``savePath`` was not empty.
4646
- **Toolbar:** Fixed a bug where the standalone toolbar page loaded from ``?debugbar_time=...`` was not interactive.
47+
- **Toolbar:** Fixed a bug in the Routes panel where only the first route parameter was converted to an input field on hover.
4748
- **View:** Fixed a bug where ``View`` would throw an error if the ``appOverridesFolder`` config property was not defined.
4849

4950
See the repo's

0 commit comments

Comments
 (0)