feat(encryption): Remove previousKeysFallbackEnabled property and related logic

Author: patel-vansh

app/Config/Encryption.php

@@ -23,15 +23,6 @@ class Encryption extends BaseConfig
      */
     public string $key = '';
 
-    /**
-     * --------------------------------------------------------------------------
-     * Previous Encryption Keys fallback enabled
-     * --------------------------------------------------------------------------
-     * If you want to enable decryption using previous keys, set this to true.
-     * See the user guide for more info.
-     */
-    public bool $previousKeysFallbackEnabled = false;
-
     /**
      * --------------------------------------------------------------------------
      * Previous Encryption Keys

env

@@ -55,9 +55,7 @@
 
 # encryption.key =
 
-# Previous keys fallback is disabled by default.
-# If you want to enable it, uncomment the line below.
-# encryption.previousKeysFallbackEnabled = true
+# Previous keys fallback; comma-separated list
 # encryption.previousKeys =
 
 #--------------------------------------------------------------------

system/Config/BaseConfig.php

@@ -133,9 +133,6 @@ public function __construct()
             if ($this instanceof Encryption) {
                 if ($property === 'key') {
                     $this->{$property} = $this->parseEncryptionKey($this->{$property});
-                } elseif ($property === 'previousKeysFallbackEnabled') {
-                    // previousKeysFallbackEnabled must be boolean
-                    $this->{$property} = (bool) $this->{$property};
                 } elseif ($property === 'previousKeys') {
                     $keysArray      = array_map('trim', explode(',', $this->{$property}));
                     $parsedKeys     = [];

system/Encryption/Encryption.php

@@ -53,11 +53,6 @@ class Encryption
      */
     protected $key;
 
-    /**
-     * Whether to fall back to previous keys when decryption fails.
-     */
-    protected bool $previousKeysFallbackEnabled = false;
-
     /**
      * Comma-separated list of previous keys for fallback decryption.
      *
@@ -104,7 +99,6 @@ public function __construct(?EncryptionConfig $config = null)
         $config ??= new EncryptionConfig();
 
         $this->key                         = $config->key;
-        $this->previousKeysFallbackEnabled = $config->previousKeysFallbackEnabled;
         $this->previousKeys                = $config->previousKeys;
         $this->driver                      = $config->driver;
         $this->digest                      = $config->digest ?? 'SHA512';
@@ -131,7 +125,6 @@ public function initialize(?EncryptionConfig $config = null)
     {
         if ($config instanceof EncryptionConfig) {
             $this->key                         = $config->key;
-            $this->previousKeysFallbackEnabled = $config->previousKeysFallbackEnabled ?? false;
             $this->previousKeys                = $config->previousKeys ?? '';
             $this->driver                      = $config->driver;
             $this->digest                      = $config->digest ?? 'SHA512';

system/Encryption/Handlers/OpenSSLHandler.php

@@ -55,11 +55,6 @@ class OpenSSLHandler extends BaseHandler
      */
     protected $key = '';
 
-    /**
-     * Whether to fall back to previous keys when decryption fails.
-     */
-    protected bool $previousKeysFallbackEnabled = false;
-
     /**
      * List of previous keys for fallback decryption.
      *
@@ -146,7 +141,7 @@ public function decrypt($data, $params = null)
             $exception = $e;
         }
 
-        if ($result === false && $this->previousKeysFallbackEnabled && $this->previousKeys !== '') {
+        if ($result === false && $this->previousKeys !== '') {
             foreach (explode(',', $this->previousKeys) as $previousKey) {
                 try {
                     $result = $this->decryptWithKey($data, $previousKey);

system/Encryption/Handlers/SodiumHandler.php

@@ -30,11 +30,6 @@ class SodiumHandler extends BaseHandler
      */
     protected $key = '';
 
-    /**
-     * Whether to fall back to previous keys when decryption fails.
-     */
-    protected bool $previousKeysFallbackEnabled = false;
-
     /**
      * List of previous keys for fallback decryption.
      *
@@ -101,7 +96,7 @@ public function decrypt($data, $params = null)
             sodium_memzero($this->key);
         }
 
-        if ($result === false && $this->previousKeysFallbackEnabled && $this->previousKeys !== '') {
+        if ($result === false && $this->previousKeys !== '') {
             foreach (explode(',', $this->previousKeys) as $previousKey) {
                 try {
                     $result = $this->decryptWithKey($data, $previousKey);