Force lowercase service names. Fixes #2534

MGatner · MGatner · commit 5b805749dd88 · 2020-02-17T15:40:57.000-05:00
diff --git a/system/Config/BaseService.php b/system/Config/BaseService.php
@@ -66,6 +66,7 @@ class BaseService
 	/**
 	 * Cache for instance of any services that
 	 * have been requested as a "shared" instance.
+	 * Keys should be lowercase service names.
 	 *
 	 * @var array
 	 */
@@ -106,6 +107,8 @@ class BaseService
 	 */
 	protected static function getSharedInstance(string $key, ...$params)
 	{
+		$key = strtolower($key);
+
 		// Returns mock if exists
 		if (isset(static::$mocks[$key]))
 		{

Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,7 @@ class BaseService`
`66`	`66`	`/**`
`67`	`67`	`* Cache for instance of any services that`
`68`	`68`	`* have been requested as a "shared" instance.`
	`69`	`+ * Keys should be lowercase service names.`
`69`	`70`	`*`
`70`	`71`	`* @var array`
`71`	`72`	`*/`
`@@ -106,6 +107,8 @@ class BaseService`
`106`	`107`	`*/`
`107`	`108`	`protected static function getSharedInstance(string $key, ...$params)`
`108`	`109`	`{`
	`110`	`+ $key = strtolower($key);`
	`111`	`+`
`109`	`112`	`// Returns mock if exists`
`110`	`113`	`if (isset(static::$mocks[$key]))`
`111`	`114`	`{`