Skip to content

Commit 5cccab3

Browse files
authored
Merge pull request #5655 from kenjis/update-internals.md
docs: update internals.md
2 parents 5abf826 + db0f193 commit 5cccab3

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

contributing/internals.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@ other core packages, you can create that in the constructor using the
1717
override that:
1818

1919
```php
20-
public function __construct(Foo $foo=null)
20+
public function __construct(?Foo $foo = null)
2121
{
22-
$this->foo = $foo instanceOf Foo
23-
? $foo
24-
: \Config\Services::foo();
22+
$this->foo = $foo ?? \Config\Services::foo();
2523
}
2624
```
2725

@@ -75,7 +73,7 @@ package itself will need its own sub-namespace that collects all related
7573
files into one grouping, like `CodeIgniter\HTTP`.
7674

7775
Files MUST be named the same as the class they hold, and they must match
78-
the Style Guide <./styleguide.md>, meaning CamelCase class and
76+
the [Style Guide](styleguide.md), meaning CamelCase class and
7977
file names. They should be in their own directory that matches the
8078
sub-namespace under the **system** directory.
8179

0 commit comments

Comments
 (0)