Add OCI8 _deleteBatch()

Author: sclubricants

system/Database/OCI8/Builder.php

@@ -434,4 +434,81 @@ protected function _upsertBatch(string $table, array $keys, array $values): stri
 
         return str_replace('{:_table_:}', $data, $sql);
     }
+
+    /**
+     * Generates a platform-specific batch update string from the supplied data
+     */
+    protected function _deleteBatch(string $table, array $keys, array $values): string
+    {
+        $sql = $this->QBOptions['sql'] ?? '';
+
+        // if this is the first iteration of batch then we need to build skeleton sql
+        if ($sql === '') {
+            $constraints = $this->QBOptions['constraints'] ?? [];
+
+            if ($constraints === []) {
+                if ($this->db->DBDebug) {
+                    throw new DatabaseException('You must specify a constraint to match on for batch deletes.'); // @codeCoverageIgnore
+                }
+
+                return ''; // @codeCoverageIgnore
+            }
+
+            $alias = $this->QBOptions['alias'] ?? '_u';
+
+            $sql = 'DELETE ' . $table . "\n";
+
+            $sql .= "WHERE EXISTS (SELECT * FROM (\n{:_table_:}";
+
+            $sql .= ') ' . $alias . "\n";
+
+            $sql .= 'WHERE ' . implode(
+                ' AND ',
+                array_map(
+                    static fn ($key) => ($key instanceof RawSql ?
+                    $key :
+                    $table . '.' . $key . ' = ' . $alias . '.' . $key),
+                    $constraints
+                )
+            );
+
+            // convert binds in where
+            foreach ($this->QBWhere as $key => $where) {
+                foreach ($this->binds as $field => $bind) {
+                    $this->QBWhere[$key]['condition'] = str_replace(':' . $field . ':', $bind[0], $where['condition']);
+                }
+            }
+
+            // remove database prefix from alias in where
+            $sql .= ' ' . str_replace(
+                'WHERE ',
+                'AND ',
+                str_replace(
+                    $this->db->DBPrefix . trim($alias, $this->db->escapeChar),
+                    trim($alias, $this->db->escapeChar),
+                    $this->compileWhereHaving('QBWhere')
+                )
+            ) . ')';
+
+            $this->QBOptions['sql'] = $sql;
+        }
+
+        if (isset($this->QBOptions['fromQuery'])) {
+            $data = $this->QBOptions['fromQuery'];
+        } else {
+            $data = implode(
+                " FROM DUAL UNION ALL\n",
+                array_map(
+                    static fn ($value) => 'SELECT ' . implode(', ', array_map(
+                        static fn ($key, $index) => $index . ' ' . $key,
+                        $keys,
+                        $value
+                    )),
+                    $values
+                )
+            ) . " FROM DUAL\n";
+        }
+
+        return str_replace('{:_table_:}', $data, $sql);
+    }
 }

system/Database/Postgre/Builder.php

@@ -456,7 +456,7 @@ protected function _deleteBatch(string $table, array $keys, array $values): stri
             // remove database prefix from alias in where
             $sql .= ' ' . str_replace(
                 'WHERE ',
-                ' AND ',
+                'AND ',
                 str_replace(
                     $this->db->DBPrefix . trim($alias, $this->db->escapeChar),
                     trim($alias, $this->db->escapeChar),