Merge pull request #2339 from dafriend/session_returns_null_with_zero_value

Fix Session::get('key') returns null when value is (int) 0

Author: lonnieezell

system/Session/Session.php

@@ -305,7 +305,7 @@ protected function configure()
 		);
 
 		//if (empty($this->sessionExpiration))
-		if (!isset($this->sessionExpiration))
+		if (! isset($this->sessionExpiration))
 		{
 			$this->sessionExpiration = (int) ini_get('session.gc_maxlifetime');
 		}
@@ -496,7 +496,7 @@ public function set($data, $value = null)
 	 */
 	public function get(string $key = null)
 	{
-		if (! empty($key) && $value = dot_array_search($key, $_SESSION))
+		if (! empty($key) && ! is_null($value = dot_array_search($key, $_SESSION)))
 		{
 			return $value;
 		}
@@ -634,7 +634,7 @@ public function __get(string $key)
 	 *
 	 * @param string $key Identifier of the session property to remove.
 	 *
-	 * @return bool
+	 * @return boolean
 	 */
 	public function __isset(string $key): bool
 	{

tests/system/Session/SessionTest.php

@@ -129,6 +129,18 @@ public function testGetReturnsNullWhenNotFound()
 		$this->assertNull($session->get('foo'));
 	}
 
+	public function testGetReturnsItemValueisZero()
+	{
+		$_SESSION = [];
+
+		$session = $this->getInstance();
+		$session->start();
+
+		$session->set('foo', (int) 0);
+
+		$this->assertSame((int) 0, $session->get('foo'));
+	}
+
 	public function testGetReturnsAllWithNoKeys()
 	{
 		$_SESSION = [