Merge pull request #5726 from kenjis/fix-db-reference

refactor: remove `&` before $db

Author: kenjis

system/Database/BaseBuilder.php

@@ -270,7 +270,7 @@ class BaseBuilder
      *
      * @throws DatabaseException
      */
-    public function __construct($tableName, ConnectionInterface &$db, ?array $options = null)
+    public function __construct($tableName, ConnectionInterface $db, ?array $options = null)
     {
         if (empty($tableName)) {
             throw new DatabaseException('A table must be specified when creating a new Query Builder.');

system/Database/BasePreparedQuery.php

@@ -57,7 +57,7 @@ abstract class BasePreparedQuery implements PreparedQueryInterface
 
     public function __construct(BaseConnection $db)
     {
-        $this->db = &$db;
+        $this->db = $db;
     }
 
     /**

system/Database/BaseUtils.php

@@ -49,9 +49,9 @@ abstract class BaseUtils
     /**
      * Class constructor
      */
-    public function __construct(ConnectionInterface &$db)
+    public function __construct(ConnectionInterface $db)
     {
-        $this->db = &$db;
+        $this->db = $db;
     }
 
     /**

system/Database/Forge.php

@@ -179,7 +179,7 @@ class Forge
      */
     public function __construct(BaseConnection $db)
     {
-        $this->db = &$db;
+        $this->db = $db;
     }
 
     /**

system/Database/Query.php

@@ -91,7 +91,7 @@ class Query implements QueryInterface
      */
     public $db;
 
-    public function __construct(ConnectionInterface &$db)
+    public function __construct(ConnectionInterface $db)
     {
         $this->db = $db;
     }

system/Database/SQLSRV/Utils.php

@@ -34,7 +34,7 @@ class Utils extends BaseUtils
      */
     protected $optimizeTable = 'ALTER INDEX all ON %s REORGANIZE';
 
-    public function __construct(ConnectionInterface &$db)
+    public function __construct(ConnectionInterface $db)
     {
         parent::__construct($db);
 

system/Database/Seeder.php

@@ -92,7 +92,7 @@ public function __construct(Database $config, ?BaseConnection $db = null)
 
         $db ??= Database::connect($this->DBGroup);
 
-        $this->db    = &$db;
+        $this->db    = $db;
         $this->forge = Database::forge($this->DBGroup);
     }
 

system/Model.php

@@ -100,14 +100,14 @@ class Model extends BaseModel
         'getCompiledUpdate',
     ];
 
-    public function __construct(?ConnectionInterface &$db = null, ?ValidationInterface $validation = null)
+    public function __construct(?ConnectionInterface $db = null, ?ValidationInterface $validation = null)
     {
         /**
          * @var BaseConnection|null $db
          */
         $db ??= Database::connect($this->DBGroup);
 
-        $this->db = &$db;
+        $this->db = $db;
 
         parent::__construct($validation);
     }