fix: Connection::getFieldData() default value convention for SQLSRV and OCI8

Author: michalsn

system/Database/OCI8/Connection.php

@@ -349,7 +349,7 @@ protected function _fieldData(string $table): array
             $retval[$i]->max_length = $length;
 
             $retval[$i]->nullable = $query[$i]->NULLABLE === 'Y';
-            $retval[$i]->default  = $query[$i]->DATA_DEFAULT;
+            $retval[$i]->default  = rtrim($query[$i]->DATA_DEFAULT);
         }
 
         return $retval;

system/Database/SQLSRV/Connection.php

@@ -384,12 +384,42 @@ protected function _fieldData(string $table): array
                 );
 
             $retVal[$i]->nullable = $query[$i]->IS_NULLABLE !== 'NO';
-            $retVal[$i]->default  = $query[$i]->COLUMN_DEFAULT;
+            $retVal[$i]->default  = $this->normalizeDefault($query[$i]->COLUMN_DEFAULT);
         }
 
         return $retVal;
     }
 
+    /**
+     * Normalizes SQL Server COLUMN_DEFAULT values.
+     * Removes wrapping parentheses and handles basic conversions.
+     */
+    private function normalizeDefault(?string $default): ?string
+    {
+        if ($default === null) {
+            return null;
+        }
+
+        $default = trim($default);
+
+        // Remove outer parentheses (handles both single and double wrapping)
+        while (preg_match('/^\((.*)\)$/', $default, $matches)) {
+            $default = trim($matches[1]);
+        }
+
+        // Handle NULL literal
+        if (strcasecmp($default, 'NULL') === 0) {
+            return null;
+        }
+
+        // Handle string literals - remove quotes and unescape
+        if (preg_match("/^'(.*)'$/s", $default, $matches)) {
+            return str_replace("''", "'", $matches[1]);
+        }
+
+        return $default;
+    }
+
     /**
      * Begin Transaction
      */

tests/system/Database/Live/ForgeTest.php

@@ -1093,7 +1093,7 @@ public function testAddFields(): void
                     'type'       => 'int',
                     'max_length' => 10,
                     'nullable'   => false,
-                    'default'    => '((0))', // Why?
+                    'default'    => '0',
                 ],
             ];
         } elseif ($this->db->DBDriver === 'OCI8') {
@@ -1124,7 +1124,7 @@ public function testAddFields(): void
                     'type'       => 'NUMBER',
                     'max_length' => '11',
                     'nullable'   => false,
-                    'default'    => '0 ', // Why?
+                    'default'    => '0',
                 ],
             ];
 

tests/system/Database/Live/SQLSRV/GetFieldDataTestCase.php

@@ -15,7 +15,9 @@
 
 use CodeIgniter\Database\Live\AbstractGetFieldDataTestCase;
 use Config\Database;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
+use ReflectionClass;
 
 /**
  * @internal
@@ -68,31 +70,31 @@ public function testGetFieldDataDefault(): void
                 'type'       => 'int',
                 'max_length' => 10,
                 'nullable'   => false,
-                'default'    => '((0))', // int 0
+                'default'    => '0',
                 // 'primary_key' => 0,
             ],
             (object) [
                 'name'       => 'text_default_null',
                 'type'       => 'varchar',
                 'max_length' => 64,
                 'nullable'   => true,
-                'default'    => '(NULL)', // NULL value
+                'default'    => null,
                 // 'primary_key' => 0,
             ],
             (object) [
                 'name'       => 'text_default_text_null',
                 'type'       => 'varchar',
                 'max_length' => 64,
                 'nullable'   => false,
-                'default'    => "('null')", // string "null"
+                'default'    => 'null', // string "null"
                 // 'primary_key' => 0,
             ],
             (object) [
                 'name'       => 'text_default_abc',
                 'type'       => 'varchar',
                 'max_length' => 64,
                 'nullable'   => false,
-                'default'    => "('abc')", // string "abc"
+                'default'    => 'abc',
                 // 'primary_key' => 0,
             ],
         ];
@@ -235,4 +237,59 @@ public function testGetFieldDataType(): void
         ];
         $this->assertSameFieldData($expected, $fields);
     }
+
+    #[DataProvider('provideNormalizeDefault')]
+    public function testNormalizeDefault(?string $input, ?string $expected, string $description): void
+    {
+        $reflection = new ReflectionClass($this->db);
+        $method     = $reflection->getMethod('normalizeDefault');
+
+        $result = $method->invoke($this->db, $input);
+
+        $this->assertSame($expected, $result, "Failed test: {$description}");
+    }
+
+    /**
+     * @return iterable<array{string|null, string|null, string}>
+     */
+    public static function provideNormalizeDefault(): iterable
+    {
+        return [
+            // [input, expected_output, description]
+
+            // Null cases
+            [null, null, 'null input'],
+            ['(NULL)', null, 'NULL literal wrapped in parentheses'],
+            ['(null)', null, 'null literal lowercase'],
+            ['(Null)', null, 'null literal mixed case'],
+            ['(nULL)', null, 'null literal random case'],
+
+            // String literal cases
+            ["('hello')", 'hello', 'simple string'],
+            ["('hello world')", 'hello world', 'string with space'],
+            ["('')", '', 'empty string literal'],
+            ["('can''t')", "can't", 'string with escaped quote'],
+            ["('it''s a ''test''')", "it's a 'test'", 'string with multiple escaped quotes'],
+            ["('line1'+char(10)+'line2')", "line1'+char(10)+'line2", 'concatenated multiline expression'],
+
+            // Numeric cases
+            ['((0))', '0', 'zero with double parentheses'],
+            ['((123))', '123', 'positive integer with double parentheses'],
+            ['((-456))', '-456', 'negative integer with double parentheses'],
+            ['((3.14))', '3.14', 'float with double parentheses'],
+
+            // Function/expression cases
+            ['(getdate())', 'getdate()', 'function call'],
+            ['(newid())', 'newid()', 'newid function'],
+            ['(user_name())', 'user_name()', 'user_name function'],
+            ['(current_timestamp)', 'current_timestamp', 'current_timestamp'],
+            ['((1+1))', '1+1', 'mathematical expression'],
+            ['((100*2))', '100*2', 'multiplication expression'],
+
+            // Edge cases
+            ["((('nested')))", 'nested', 'multiple nested parentheses'],
+            ['plain_value', 'plain_value', 'value without parentheses'],
+            ['(complex_func(1, 2))', 'complex_func(1, 2)', 'function with parameters'],
+        ];
+    }
 }

user_guide_src/source/changelogs/v4.6.4.rst

@@ -31,6 +31,7 @@ Bugs Fixed
 **********
 
 - **Database:** Fixed a bug in ``Database::connect()`` which was causing to store non-shared connection instances in shared cache.
+- **Database:** Fixed a bug in ``Connection::getFieldData()`` for ``SQLSRV`` and ``OCI8`` where extra characters were returned in column default values (specific to those handlers), instead of following the convention used by other drivers.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_