refactor: fix static code analysis problems

Author: patel-vansh

app/Config/Encryption.php

@@ -29,6 +29,8 @@ class Encryption extends BaseConfig
      * --------------------------------------------------------------------------
      * If you want to enable decryption using previous keys, set them here.
      * See the user guide for more info.
+     *
+     * @var array<string>|string
      */
     public array|string $previousKeys = '';
 

system/Encryption/Handlers/OpenSSLHandler.php

@@ -58,6 +58,8 @@ class OpenSSLHandler extends BaseHandler
 
     /**
      * List of previous keys for fallback decryption.
+     *
+     * @var array<string>|string
      */
     protected array|string $previousKeys = '';
 
@@ -135,7 +137,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
         // Only use fallback keys if no custom key was provided in params
         $useFallback = ! isset($params['key']);
 
-        $attemptDecrypt = function ($key) use ($data) {
+        $attemptDecrypt = function ($key) use ($data): array {
             try {
                 $result = $this->decryptWithKey($data, $key);
 
@@ -154,7 +156,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
         $originalException = $result['exception'];
 
         // If primary key failed and fallback is allowed, try previous keys
-        if ($useFallback && ! empty($this->previousKeys)) {
+        if ($useFallback && ! in_array($this->previousKeys, ['', '0', []], true)) {
             foreach ($this->previousKeys as $previousKey) {
                 $fallbackResult = $attemptDecrypt($previousKey);
 

system/Encryption/Handlers/SodiumHandler.php

@@ -33,6 +33,8 @@ class SodiumHandler extends BaseHandler
 
     /**
      * List of previous keys for fallback decryption.
+     *
+     * @var array<string>|string
      */
     protected array|string $previousKeys = '';
 
@@ -88,7 +90,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
         // Only use fallback keys if no custom key was provided in params
         $useFallback = ! isset($params['key']);
 
-        $attemptDecrypt = function ($key) use ($data) {
+        $attemptDecrypt = function ($key) use ($data): array {
             try {
                 $result = $this->decryptWithKey($data, $key);
                 sodium_memzero($key);
@@ -110,7 +112,7 @@ public function decrypt($data, #[SensitiveParameter] $params = null)
         $originalException = $result['exception'];
 
         // If primary key failed and fallback is allowed, try previous keys
-        if ($useFallback && ! empty($this->previousKeys)) {
+        if ($useFallback && ! in_array($this->previousKeys, ['', '0', []], true)) {
             foreach ($this->previousKeys as $previousKey) {
                 $fallbackResult = $attemptDecrypt($previousKey);