[Rector] Apply PHP 7.4 Requirement and syntax

Author: samsonasik

app/Config/Constants.php

@@ -38,9 +38,9 @@
 defined('HOUR')   || define('HOUR', 3600);
 defined('DAY')    || define('DAY', 86400);
 defined('WEEK')   || define('WEEK', 604800);
-defined('MONTH')  || define('MONTH', 2592000);
-defined('YEAR')   || define('YEAR', 31536000);
-defined('DECADE') || define('DECADE', 315360000);
+defined('MONTH')  || define('MONTH', 2_592_000);
+defined('YEAR')   || define('YEAR', 31_536_000);
+defined('DECADE') || define('DECADE', 315_360_000);
 
 /*
  | --------------------------------------------------------------------------

app/Config/Events.php

@@ -32,9 +32,7 @@
             ob_end_flush();
         }
 
-        ob_start(static function ($buffer) {
-            return $buffer;
-        });
+        ob_start(static fn($buffer) => $buffer);
     }
 
     /*

composer.json

@@ -5,7 +5,7 @@
     "homepage": "https://codeigniter.com",
     "license": "MIT",
     "require": {
-        "php": "^7.3 || ^8.0",
+        "php": "^7.4 || ^8.0",
         "ext-curl": "*",
         "ext-intl": "*",
         "ext-json": "*",

rector.php

@@ -27,7 +27,6 @@
 use Rector\CodingStyle\Rector\ClassMethod\MakeInheritedMethodVisibilitySameAsParentRector;
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Core\Configuration\Option;
-use Rector\Core\ValueObject\PhpVersion;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPromotedPropertyRector;
 use Rector\DeadCode\Rector\If_\UnwrapFutureCompatibleIfPhpVersionRector;
@@ -54,7 +53,7 @@
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $containerConfigurator->import(SetList::DEAD_CODE);
-    $containerConfigurator->import(LevelSetList::UP_TO_PHP_73);
+    $containerConfigurator->import(LevelSetList::UP_TO_PHP_74);
     $containerConfigurator->import(PHPUnitSetList::PHPUNIT_SPECIFIC_METHOD);
     $containerConfigurator->import(PHPUnitSetList::PHPUNIT_80);
 
@@ -119,7 +118,6 @@
 
     // auto import fully qualified class names
     $parameters->set(Option::AUTO_IMPORT_NAMES, true);
-    $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_73);
 
     $services = $containerConfigurator->services();
     $services->set(UnderscoreToCamelCaseVariableNameRector::class);

system/Autoloader/FileLocator.php

@@ -186,7 +186,7 @@ public function search(string $path, string $ext = 'php', bool $prioritizeApp =
         }
 
         if (! $prioritizeApp && ! empty($appPaths)) {
-            $foundPaths = array_merge($foundPaths, $appPaths);
+            $foundPaths = [...$foundPaths, ...$appPaths];
         }
 
         // Remove any duplicates

system/BaseModel.php

@@ -295,7 +295,7 @@ public function __construct(?ValidationInterface $validation = null)
         /**
          * @var Validation $validation
          */
-        $validation       = $validation ?? Services::validation(null, false);
+        $validation ??= Services::validation(null, false);
         $this->validation = $validation;
 
         $this->initialize();

system/CodeIgniter.php

@@ -576,7 +576,7 @@ protected function getResponseObject()
      * @param int $duration How long the Strict Transport Security
      *                      should be enforced for this URL.
      */
-    protected function forceSecureAccess($duration = 31536000)
+    protected function forceSecureAccess($duration = 31_536_000)
     {
         if ($this->config->forceGlobalSecureRequests !== true) {
             return;

system/Commands/Generators/MigrateCreate.php

@@ -77,9 +77,9 @@ class MigrateCreate extends BaseCommand
     public function run(array $params)
     {
         // Resolve arguments before passing to make:migration
-        $params[0] = $params[0] ?? CLI::getSegment(2);
+        $params[0] ??= CLI::getSegment(2);
 
-        $params['namespace'] = $params['namespace'] ?? CLI::getOption('namespace') ?? APP_NAMESPACE;
+        $params['namespace'] ??= CLI::getOption('namespace') ?? APP_NAMESPACE;
 
         if (array_key_exists('force', $params) || CLI::getOption('force')) {
             $params['force'] = null;

system/Commands/Help.php

@@ -72,7 +72,7 @@ class Help extends BaseCommand
     public function run(array $params)
     {
         $command  = array_shift($params);
-        $command  = $command ?? 'help';
+        $command ??= 'help';
         $commands = $this->commands->getCommands();
 
         if (! $this->commands->verifyCommand($command, $commands)) {

system/Commands/Utilities/Environment.php

@@ -72,7 +72,7 @@ final class Environment extends BaseCommand
      *
      * @var array<int, string>
      */
-    private static $knownTypes = [
+    private static array $knownTypes = [
         'production',
         'development',
     ];