Skip to content

Commit d8ffc5c

Browse files
authored
Merge pull request #5652 from kenjis/fix-routes-migrations
refactor: remove migrations routes
2 parents da4aea7 + 345e8cf commit d8ffc5c

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

contributing/internals.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,17 +122,9 @@ scans and keep performance high.
122122

123123
## Command-Line Support
124124

125-
CodeIgniter has never been known for it's strong CLI support. However,
125+
CodeIgniter has never been known for its strong CLI support. However,
126126
if your package could benefit from it, create a new file under
127-
**system/Commands**. The class contained within is simply a controller
128-
that is intended for CLI usage only. The `index()` method should provide
129-
a list of available commands provided by that package.
130-
131-
Routes must be added to **system/Config/Routes.php** using the `cli()`
132-
method to ensure it is not accessible through the browser, but is
133-
restricted to the CLI only.
134-
135-
See the **MigrationsCommand** file for an example.
127+
**system/Commands**.
136128

137129
## Documentation
138130

system/Config/Routes.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,5 @@
1919
* already loaded up and ready for us to use.
2020
*/
2121

22-
// Migrations
23-
$routes->cli('migrations/(:segment)/(:segment)', '\CodeIgniter\Commands\MigrationsCommand::$1/$2');
24-
$routes->cli('migrations/(:segment)', '\CodeIgniter\Commands\MigrationsCommand::$1');
25-
$routes->cli('migrations', '\CodeIgniter\Commands\MigrationsCommand::index');
26-
2722
// CLI Catchall - uses a _remap to call Commands
2823
$routes->cli('ci(:any)', '\CodeIgniter\CLI\CommandRunner::index/$1');

0 commit comments

Comments
 (0)