set default value for superglobals

Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>

Author: michalsn

system/Commands/Utilities/Environment.php

@@ -86,7 +86,7 @@ final class Environment extends BaseCommand
     public function run(array $params)
     {
         if ($params === []) {
-            CLI::write(sprintf('Your environment is currently set as %s.', CLI::color(service('superglobals')->server('CI_ENVIRONMENT') ?? ENVIRONMENT, 'green')));
+            CLI::write(sprintf('Your environment is currently set as %s.', CLI::color(service('superglobals')->server('CI_ENVIRONMENT', ENVIRONMENT), 'green')));
             CLI::newLine();
 
             return EXIT_ERROR;
@@ -150,7 +150,7 @@ private function writeNewEnvironmentToEnvFile(string $newEnv): bool
             copy($baseEnv, $envFile);
         }
 
-        $pattern = preg_quote(service('superglobals')->server('CI_ENVIRONMENT') ?? ENVIRONMENT, '/');
+        $pattern = preg_quote(service('superglobals')->server('CI_ENVIRONMENT', ENVIRONMENT), '/');
         $pattern = sprintf('/^[#\s]*CI_ENVIRONMENT[=\s]+%s$/m', $pattern);
 
         return file_put_contents(

system/Config/Services.php

@@ -543,7 +543,7 @@ public static function createRequest(App $config, bool $isCli = false): void
             $request = AppServices::incomingrequest($config);
 
             // guess at protocol if needed
-            $request->setProtocolVersion(static::superglobals()->server('SERVER_PROTOCOL') ?? 'HTTP/1.1');
+            $request->setProtocolVersion(static::superglobals()->server('SERVER_PROTOCOL', 'HTTP/1.1'));
         }
 
         // Inject the request object into Services.

system/HTTP/MessageTrait.php

@@ -86,7 +86,7 @@ public function appendBody($data): self
      */
     public function populateHeaders(): void
     {
-        $contentType = service('superglobals')->server('CONTENT_TYPE') ?? getenv('CONTENT_TYPE');
+        $contentType = service('superglobals')->server('CONTENT_TYPE', (string) getenv('CONTENT_TYPE'));
         if (! empty($contentType)) {
             $this->setHeader('Content-Type', $contentType);
         }

system/Pager/Pager.php

@@ -434,7 +434,7 @@ protected function calculateCurrentPage(string $group)
         } else {
             $pageSelector = $this->groups[$group]['pageSelector'];
 
-            $page = (int) (service('superglobals')->get($pageSelector) ?? 1);
+            $page = (int) (service('superglobals')->get($pageSelector, 1));
 
             $this->groups[$group]['currentPage'] = $page < 1 ? 1 : $page;
         }