Merge pull request #5610 from kenjis/fix-SQLSRV/Connection

deprecate Database\SQLSRV\Connection::getError()

Author: kenjis

system/Database/BaseConnection.php

@@ -1526,7 +1526,8 @@ public function isWriteType($sql): bool
      *
      * Must return an array with keys 'code' and 'message':
      *
-     *  return ['code' => null, 'message' => null);
+     * @return array<string, int|string|null>
+     * @phpstan-return array{code: int|string|null, message: string|null}
      */
     abstract public function error(): array;
 

system/Database/SQLSRV/Connection.php

@@ -465,6 +465,8 @@ protected function execute(string $sql)
      * Returns the last error encountered by this connection.
      *
      * @return mixed
+     *
+     * @deprecated Use `error()` instead.
      */
     public function getError()
     {

user_guide_src/source/changelogs/v4.2.0.rst

@@ -38,7 +38,7 @@ Changes
 Deprecations
 ************
 
-
+- ``CodeIgniter\Database\SQLSRV\Connection::getError()`` is deprecated. Use ``CodeIgniter\Database\SQLSRV\Connection::error()`` instead.
 
 Bugs Fixed
 **********