call Console::run() within command()

Author: paulbalandan

system/Common.php

@@ -12,6 +12,7 @@
  */
 
 use CodeIgniter\Cache\CacheInterface;
+use CodeIgniter\CLI\Console;
 use CodeIgniter\Config\BaseConfig;
 use CodeIgniter\Config\Factories;
 use CodeIgniter\Context\Context;
@@ -127,7 +128,7 @@ function command(string $command)
         $regexString = '([^\s]+?)(?:\s|(?<!\\\\)"|(?<!\\\\)\'|$)';
         $regexQuoted = '(?:"([^"\\\\]*(?:\\\\.[^"\\\\]*)*)"|\'([^\'\\\\]*(?:\\\\.[^\'\\\\]*)*)\')';
 
-        $args   = [];
+        $tokens = [];
         $length = strlen($command);
         $cursor = 0;
 
@@ -140,9 +141,9 @@ function command(string $command)
             if (preg_match('/\s+/A', $command, $match, 0, $cursor)) {
                 // nothing to do
             } elseif (preg_match('/' . $regexQuoted . '/A', $command, $match, 0, $cursor)) {
-                $args[] = stripcslashes(substr($match[0], 1, strlen($match[0]) - 2));
+                $tokens[] = stripcslashes(substr($match[0], 1, strlen($match[0]) - 2));
             } elseif (preg_match('/' . $regexString . '/A', $command, $match, 0, $cursor)) {
-                $args[] = stripcslashes($match[1]);
+                $tokens[] = stripcslashes($match[1]);
             } else {
                 // @codeCoverageIgnoreStart
                 throw new InvalidArgumentException(sprintf(
@@ -155,41 +156,25 @@ function command(string $command)
             $cursor += strlen($match[0]);
         }
 
-        /** @var array<int|string, string|null> */
-        $params      = [];
-        $command     = array_shift($args);
-        $optionValue = false;
-
-        foreach ($args as $i => $arg) {
-            if (mb_strpos($arg, '-') !== 0) {
-                if ($optionValue) {
-                    // if this was an option value, it was already
-                    // included in the previous iteration
-                    $optionValue = false;
-                } else {
-                    // add to segments if not starting with '-'
-                    // and not an option value
-                    $params[] = $arg;
-                }
+        if (! in_array('--no-header', $tokens, true)) {
+            // Don't show the header as it is not needed when running commands from code.
+            $tokens[] = '--no-header';
+        }
 
-                continue;
-            }
+        // Prepend an application name, as Console expects one.
+        array_unshift($tokens, 'spark');
 
-            $arg   = ltrim($arg, '-');
-            $value = null;
+        ob_start();
 
-            if (isset($args[$i + 1]) && mb_strpos($args[$i + 1], '-') !== 0) {
-                $value       = $args[$i + 1];
-                $optionValue = true;
-            }
+        try {
+            (new Console())->run($tokens);
 
-            $params[$arg] = $value;
+            return ob_get_clean();
+        } finally {
+            // `Console::run()` creates a `CLIRequest` instance stored globally, which
+            // can cause issues if the next code expects a different type of request.
+            Services::createRequest(config(App::class), is_cli());
         }
-
-        ob_start();
-        service('commands')->run($command, $params);
-
-        return ob_get_clean();
     }
 }
 

tests/system/Commands/CommandTest.php

@@ -165,11 +165,11 @@ public static function provideCommandParsesArgsCorrectly(): iterable
             ],
             [
                 'reveal seg1 seg2 -opt1 val1 seg3',
-                ['seg1', 'seg2', 'opt1' => 'val1', 'seg3'],
+                ['seg1', 'seg2', 'seg3', 'opt1' => 'val1'],
             ],
             [
                 'reveal as df -gh -jk -qw 12 zx cv',
-                ['as', 'df', 'gh' => null, 'jk' => null, 'qw' => '12', 'zx', 'cv'],
+                ['as', 'df', 'zx', 'cv', 'gh' => null, 'jk' => null, 'qw' => '12'],
             ],
             [
                 'reveal as -df "some stuff" -jk 12 -sd "Some longer stuff" -fg \'using single quotes\'',