fix: crash in toggleViewsHints - debugDiv.appendChild (toolbar.js)#9735
fix: crash in toggleViewsHints - debugDiv.appendChild (toolbar.js)#9735paulbalandan merged 3 commits intocodeigniter4:developfrom
toggleViewsHints - debugDiv.appendChild (toolbar.js)#9735Conversation
|
Hi there, mjomble! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
michalsn
left a comment
There was a problem hiding this comment.
I have confirmed this is working correctly.
Please add a changelog entry, see: https://github.com/codeigniter4/CodeIgniter4/pull/9736/files
|
I noticed that both our PRs fix an Uncaught TypeError in toolbar.js, so I added a changelog line that refers to both bugs in plural. |
toggleViewsHints - debugDiv.appendChild (toolbar.js)
toggleViewsHints - debugDiv.appendChild (toolbar.js)toggleViewsHints - debugDiv.appendChild (toolbar.js)
|
Fair enough. Thank you. |
Description
Fixes #9727
Checklist: