Skip to content

fix: cannot read properties of null in toggleViewsHints (toolbar.js)#9736

Merged
michalsn merged 1 commit intocodeigniter4:developfrom
michalsn:fix/toolbar-js
Oct 3, 2025
Merged

fix: cannot read properties of null in toggleViewsHints (toolbar.js)#9736
michalsn merged 1 commit intocodeigniter4:developfrom
michalsn:fix/toolbar-js

Conversation

@michalsn
Copy link
Copy Markdown
Member

@michalsn michalsn commented Oct 1, 2025

Description
This PR fixes an Uncaught TypeError: Cannot read properties of null in toolbar.js within the toggleViewsHints method.

Fixes #9726

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 3, 2025
@paulbalandan
Copy link
Copy Markdown
Member

Oh, this needs to update the conflict

@michalsn
Copy link
Copy Markdown
Member Author

michalsn commented Oct 3, 2025

Updated. Thank you @paulbalandan

@michalsn michalsn merged commit cd92eab into codeigniter4:develop Oct 3, 2025
3 checks passed
@michalsn michalsn deleted the fix/toolbar-js branch November 22, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Crash in toggleViewsHints - getValidElementInner

2 participants