Skip to content

feat: Add support for HTTP status in ResponseCache #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsn merged 3 commits into from
Dec 28, 2025
Merged

feat: Add support for HTTP status in ResponseCache #9855

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7521597
feat: Added support for HTTP status in ResponseCache
sk757a Dec 26, 2025
97fe5aa
Suggestions
sk757a Dec 26, 2025
a9ca173
Changelog
sk757a Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion system/Cache/ResponseCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,12 @@ public function make(CLIRequest|IncomingRequest $request, ResponseInterface $res

return $this->cache->save(
$this->generateCacheKey($request),
serialize(['headers' => $headers, 'output' => $response->getBody()]),
serialize([
'headers' => $headers,
'output' => $response->getBody(),
'statuscode' => $response->getStatusCode(),
'reasonphrase' => $response->getReasonPhrase(),
Comment thread
sk757a marked this conversation as resolved.
Outdated
]),
$this->ttl,
);
}
Expand Down Expand Up @@ -140,6 +145,10 @@ public function get(CLIRequest|IncomingRequest $request, ResponseInterface $resp

$response->setBody($output);

if (isset($cachedResponse['statuscode'])) {
$response->setStatusCode($cachedResponse['statuscode'], $cachedResponse['reasonphrase'] ?? '');
}

return $response;
}

Expand Down
17 changes: 17 additions & 0 deletions tests/system/Cache/ResponseCacheTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,23 @@ public function testCachePageIncomingRequest(): void
$this->assertNotInstanceOf(ResponseInterface::class, $cachedResponse);
}

public function testCachePageIncomingRequestWithStatus(): void
{
$pageCache = $this->createResponseCache();

$response = new Response(new App());
$response->setStatusCode(432, 'Foo Bar');
$response->setBody('The response body.');

$this->assertTrue($pageCache->make($this->createIncomingRequest('foo/bar'), $response));

// Check cached response status
$cachedResponse = $pageCache->get($this->createIncomingRequest('foo/bar'), new Response(new App()));
$this->assertInstanceOf(ResponseInterface::class, $cachedResponse);
$this->assertSame(432, $cachedResponse->getStatusCode());
$this->assertSame('Foo Bar', $cachedResponse->getReasonPhrase());
}

public function testCachePageIncomingRequestWithCacheQueryString(): void
{
$cache = new Cache();
Expand Down