Merge pull request #21 from codeigniter4/context-bug

DatabaseHandler: Enforce Context Updates

Author: MGatner

src/Handlers/DatabaseHandler.php

@@ -99,6 +99,7 @@ public function set(string $class, string $property, $value = null, ?string $con
             $result = db_connect()->table($this->table)
                 ->where('class', $class)
                 ->where('key', $property)
+                ->where('context', $context)
                 ->update([
                     'value'      => $value,
                     'type'       => $type,

tests/SettingsTest.php

@@ -258,4 +258,40 @@ public function testForgetWithContext()
 
         $this->assertSame('Bar', $settings->get('Test.siteName', 'category:disease'));
     }
+
+    /**
+     * @see https://github.com/codeigniter4/settings/issues/20
+     */
+    public function testSetUpdatesContextOnly()
+    {
+        $settings = new Settings(config('Settings'));
+
+        $settings->set('Test.siteName', 'Humpty');
+        $settings->set('Test.siteName', 'Jack', 'context:male');
+        $settings->set('Test.siteName', 'Jill', 'context:female');
+        $settings->set('Test.siteName', 'Jane', 'context:female');
+
+        $this->seeInDatabase($this->table, [
+            'class'   => 'Tests\Support\Config\Test',
+            'key'     => 'siteName',
+            'value'   => 'Jane',
+            'type'    => 'string',
+            'context' => 'context:female',
+        ]);
+
+        $this->seeInDatabase($this->table, [
+            'class'   => 'Tests\Support\Config\Test',
+            'key'     => 'siteName',
+            'value'   => 'Humpty',
+            'type'    => 'string',
+            'context' => null,
+        ]);
+        $this->seeInDatabase($this->table, [
+            'class'   => 'Tests\Support\Config\Test',
+            'key'     => 'siteName',
+            'value'   => 'Jack',
+            'type'    => 'string',
+            'context' => 'context:male',
+        ]);
+    }
 }