Skip to content

Commit e3a7cdd

Browse files
authored
fix(no-release): blocked network from ci and release workflows (#44)
Add allowed-endpoints: - release-assets.githubusercontent.com:443
1 parent 67ed316 commit e3a7cdd

4 files changed

Lines changed: 17 additions & 26 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 14 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ name: CI
33
on:
44
push:
55
branches:
6-
- "*"
6+
- "**"
77
pull_request:
88
branches:
9-
- "*"
9+
- "**"
1010

1111
concurrency:
1212
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
@@ -30,25 +30,20 @@ jobs:
3030
github.com:443
3131
objects.githubusercontent.com:443
3232
registry.npmjs.org:443
33+
release-assets.githubusercontent.com:443
3334
3435
- name: Git checkout
3536
if: github.event_name == 'push'
3637
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3738
with:
3839
fetch-depth: 1
39-
sparse-checkout: |
40-
.
41-
src
4240
persist-credentials: false
4341

4442
- name: Git checkout (full-history)
4543
if: github.event_name == 'pull_request'
4644
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
4745
with:
4846
fetch-depth: 0
49-
sparse-checkout: |
50-
.
51-
src
5247
ref: ${{ github.head_ref }}
5348
repository: ${{ github.event.pull_request.head.repo.full_name }}
5449
persist-credentials: false
@@ -86,28 +81,17 @@ jobs:
8681
- name: Git checkout
8782
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
8883
with:
89-
fetch-depth: ${{ github.event_name == 'pull_request' && 1 || 2 }}
90-
repository: ${{ github.event.pull_request.head.repo.full_name }}
84+
fetch-depth: 1
9185
persist-credentials: false
9286

93-
- name: Run check (push)
94-
if: github.event_name == 'push'
95-
uses: actions/dependency-review-action@ce3cf9537a52e8119d91fd484ab5b8a807627bf8 # v4.6.0
96-
with:
97-
allow-licenses: MIT, ISC, CC0-1.0, Apache-2.0, BSD-3-Clause, Unlicense
98-
head-ref: ${{ github.sha }}
99-
base-ref: ${{ github.event.before }}
100-
fail-on-severity: low
101-
comment-summary-in-pr: never
102-
warn-on-openssf-scorecard-level: 3
103-
104-
- name: Run check (pull_request)
105-
if: github.event_name == 'pull_request'
87+
- name: Run dependency review
10688
uses: actions/dependency-review-action@ce3cf9537a52e8119d91fd484ab5b8a807627bf8 # v4.6.0
10789
with:
10890
allow-licenses: MIT, ISC, CC0-1.0, Apache-2.0, BSD-3-Clause, Unlicense
109-
fail-on-severity: low
110-
comment-summary-in-pr: on-failure
91+
head-ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
92+
base-ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.repository.default_branch }}
93+
fail-on-severity: moderate
94+
comment-summary-in-pr: ${{ github.event_name == 'pull_request' && 'on-failure' || 'never' }}
11195
warn-on-openssf-scorecard-level: 3
11296

11397
format:
@@ -125,6 +109,7 @@ jobs:
125109
objects.githubusercontent.com:443
126110
raw.githubusercontent.com:443
127111
registry.npmjs.org:443
112+
release-assets.githubusercontent.com:443
128113
129114
- name: Git checkout
130115
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -158,6 +143,7 @@ jobs:
158143
objects.githubusercontent.com:443
159144
registry.npmjs.org:443
160145
storage.googleapis.com:443
146+
release-assets.githubusercontent.com:443
161147
162148
- name: Git checkout
163149
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -179,11 +165,13 @@ jobs:
179165
uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2
180166
with:
181167
fail_ci_if_error: true
168+
verbose: true
182169

183170
- name: Upload test result
184171
uses: codecov/test-results-action@f2dba722c67b86c6caa034178c6e4d35335f6706 # v1.1.0
185172
with:
186173
fail_ci_if_error: true
174+
verbose: true
187175

188176
type:
189177
name: Type check
@@ -201,6 +189,7 @@ jobs:
201189
objects.githubusercontent.com:443
202190
raw.githubusercontent.com:443
203191
registry.npmjs.org:443
192+
release-assets.githubusercontent.com:443
204193
205194
- name: Git checkout
206195
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/codeql.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
github.com:443
4343
objects.githubusercontent.com
4444
uploads.github.com:443
45+
release-assets.githubusercontent.com:443
4546
4647
- name: Git checkout
4748
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

.github/workflows/release.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
rekor.sigstore.dev:443
3939
tuf-repo-cdn.sigstore.dev:443
4040
uploads.github.com:443
41+
release-assets.githubusercontent.com:443
4142
4243
- name: Git checkout (full-history)
4344
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

__tests__/src/blueprints/Formatter.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ describe('blueprints > Formatter', () => {
389389

390390
expect(formatted).toIncludeRepeated(
391391
formatterOptions.formatOptions.separatorBetweenInputAndResult,
392-
2
392+
3
393393
);
394394
});
395395

0 commit comments

Comments
 (0)