Skip to content

Commit 524f0b7

Browse files
authored
[♻️Refactor] 0903 QA 진행 후 리팩토링 요소 반영 (#206)
* ♻️ refactor: 테스트 스켈레톤 코드 삭제 * 🎨 styles: skeleton - 예약 내역, 내 체험관리 영역 스타일 수정 * ♻️ refactor: 배너 캐러셀 영역 스켈레톤 적용으로 인해 삭제(blurImageUrl) * ♻️ refactor: toast 메시지로 에러메시지 보여주던걸 Alert메시지로 통일 * 🐛 fix: 비 로그인 사용자가 특정 링크 접근시 aauthGuard 동작되도록 수정, AuthGuard 코드 자체 리팩토링 * 🎨 styles: 예약내역, 내 체험관리 스켈레톤 styles 수정(브라우저 width에 맞는 길이로 수정) * ♻️ refactor: 모든체험, 인기체험 suspense 제거 후 반영
1 parent d3acae2 commit 524f0b7

17 files changed

Lines changed: 86 additions & 352 deletions

File tree

src/app/activities/page-content.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,10 @@ const ActivitiesPageContent = () => {
4646
) : (
4747
<>
4848
{/* 지연 로드: 인기 체험 */}
49-
<Suspense fallback={<LoadingSpinner />}>
50-
<BestActivities />
51-
</Suspense>
49+
<BestActivities />
5250

5351
{/* 지연 로드: 전체 체험 목록 */}
54-
<Suspense fallback={<LoadingSpinner />}>
55-
<AllActivities />
56-
</Suspense>
52+
<AllActivities />
5753
</>
5854
)}
5955
</div>

src/app/my/layout.tsx

Lines changed: 36 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { usePathname, useRouter } from 'next/navigation';
44
import React, { useEffect, useState } from 'react';
55

66
import Sidebar from '@/features/my/components/sidebar';
7+
import { AuthGuard } from '@/shared/components/auth/AuthGuard';
78
import LoadingSpinner from '@/shared/components/loading-spinner/loading-spinner';
89
import useWindowSize from '@/shared/libs/hooks/useWindowSize';
910

@@ -42,39 +43,41 @@ export default function Layout({ children }: { children: React.ReactNode }) {
4243
}
4344

4445
return (
45-
<div
46-
className={`mx-auto flex justify-center px-[2.4rem] py-[3rem] md:w-[73.2rem] md:gap-[3rem] lg:min-w-[102.4rem] lg:gap-[5rem]`}
47-
>
48-
{/* 모바일에서만 보이는 뒤로가기 버튼 */}
49-
{isMobile && !isMyPageRoot && (
50-
<button
51-
onClick={handleBackClick}
52-
className="absolute top-[5.8rem] left-[2.4rem]"
53-
aria-label="뒤로 가기"
54-
>
55-
<Image
56-
src="/images/icons/back.svg"
57-
alt="뒤로 가기"
58-
width={23}
59-
height={23}
60-
/>
61-
</button>
62-
)}
63-
64-
<aside
65-
className={
66-
(isMobile && !isMyPageRoot) ||
67-
isActivityRegistration ||
68-
isActivityEdit
69-
? 'hidden'
70-
: ''
71-
}
46+
<AuthGuard>
47+
<div
48+
className={`mx-auto flex justify-center px-[2.4rem] py-[3rem] md:w-[73.2rem] md:gap-[3rem] lg:min-w-[102.4rem] lg:gap-[5rem]`}
7249
>
73-
<Sidebar />
74-
</aside>
75-
<main className={`${isMobile && isMyPageRoot ? 'hidden' : ''} w-full`}>
76-
{children}
77-
</main>
78-
</div>
50+
{/* 모바일에서만 보이는 뒤로가기 버튼 */}
51+
{isMobile && !isMyPageRoot && (
52+
<button
53+
onClick={handleBackClick}
54+
className="absolute top-[5.8rem] left-[2.4rem]"
55+
aria-label="뒤로 가기"
56+
>
57+
<Image
58+
src="/images/icons/back.svg"
59+
alt="뒤로 가기"
60+
width={23}
61+
height={23}
62+
/>
63+
</button>
64+
)}
65+
66+
<aside
67+
className={
68+
(isMobile && !isMyPageRoot) ||
69+
isActivityRegistration ||
70+
isActivityEdit
71+
? 'hidden'
72+
: ''
73+
}
74+
>
75+
<Sidebar />
76+
</aside>
77+
<main className={`${isMobile && isMyPageRoot ? 'hidden' : ''} w-full`}>
78+
{children}
79+
</main>
80+
</div>
81+
</AuthGuard>
7982
);
8083
}
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import ActivityRegistrationForm from '@/features/activity-registration/components/activity-registration-form';
2-
import { AuthGuard } from '@/shared/components/auth/AuthGuard';
32

43
const ActivityRegistrationPage = () => {
54
return (
@@ -14,10 +13,4 @@ const ActivityRegistrationPage = () => {
1413
);
1514
};
1615

17-
export default function GuardActivityRegistrationPage() {
18-
return (
19-
<AuthGuard>
20-
<ActivityRegistrationPage />
21-
</AuthGuard>
22-
);
23-
}
16+
export default ActivityRegistrationPage;

src/app/test-skeleton/page.tsx

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/app/test-skeleton/test-skeleton.tsx

Lines changed: 0 additions & 259 deletions
This file was deleted.

src/features/activities/components/banner-carousel.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,6 @@ const BannerCarousel = () => {
123123
quality={idx === 0 ? 60 : 50}
124124
loading={idx === 0 ? 'eager' : 'lazy'}
125125
sizes="(max-width: 768px) 100vw, (max-width: 1024px) 100vw, 112rem"
126-
placeholder={idx === 0 ? undefined : 'blur'}
127-
blurDataURL={
128-
idx === 0
129-
? undefined
130-
: 'data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAYEBQYFBAYGBQYHBwYIChAKCgkJChQODwwQFxQYGBcUFhYaHSUfGhsjHBYWICwgIyYnKSopGR8tMC0oMCUoKSj/2wBDAQcHBwoIChMKChMoGhYaKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCj/wAARCAABAAEDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAv/xAAhEAACAQMDBQAAAAAAAAAAAAABAgMABAUGIWGRkqGx0f/EABUBAQEAAAAAAAAAAAAAAAAAAAMF/8QAGhEAAgIDAAAAAAAAAAAAAAAAAAECEgMRkf/aAAwDAQACEQMRAD8AltJagyeH0AthI5xdrLcNM91BF5pX2HaH9bcfaSXWGaRmknyJckliyjqTzSlT54b6bk+h0R//2Q=='
131-
}
132126
/>
133127
<div className="absolute inset-0 flex flex-col justify-end bg-gradient-to-t from-black/90 to-transparent p-2 transition-opacity duration-700 md:p-8 lg:p-12">
134128
<div className="mb-2 text-center text-[1.8rem] font-bold text-white drop-shadow-lg md:text-[2.4rem] lg:text-[3.2rem]">

0 commit comments

Comments
 (0)