Merge pull request #17 from hovhannest/pi-tool-result-hook

Add pi tool-result hook and windows installer

Author: codejunkie99

.agent/harness/hooks/pi_post_tool.py

@@ -0,0 +1,221 @@
+#!/usr/bin/env python3
+"""Process Pi Coding Agent tool_result events into episodic memory entries.
+
+Pi exposes a project-local extension system. The adapter installs
+`.pi/extensions/memory-hook.ts`, which forwards every `tool_result` event to
+this script via stdin. We normalize Pi's event shape into the same
+tool_input/tool_response structure used by the Claude Code hook so the
+importance scoring, reflection generation, and success classification stay
+consistent across harnesses.
+"""
+import json
+import os
+import sys
+
+HERE = os.path.dirname(os.path.abspath(__file__))
+AGENT_ROOT = os.path.abspath(os.path.join(HERE, "..", ".."))
+
+sys.path.insert(0, os.path.join(AGENT_ROOT, "harness"))
+sys.path.insert(0, os.path.join(AGENT_ROOT, "tools"))
+
+from hooks.post_execution import log_execution  # noqa: E402
+from hooks.on_failure import on_failure        # noqa: E402
+import hooks.claude_code_post_tool as cc       # noqa: E402
+
+
+_PI_TO_CANONICAL = {
+    "bash": "Bash",
+    "edit": "Edit",
+    "write": "Write",
+    "read": "Read",
+    "grep": "Grep",
+    "find": "Find",
+    "ls": "LS",
+    "task": "Task",
+    "todowrite": "TodoWrite",
+    "todo_write": "TodoWrite",
+    "webfetch": "WebFetch",
+    "web_fetch": "WebFetch",
+}
+
+# Pi tends to use camelCase for tool_input keys; the shared
+# claude_code_post_tool helpers (cc._action_label, cc._reflection,
+# cc._importance) expect the snake_case keys Claude Code sends.
+# Normalize a known set so action labels and reflections come out
+# meaningful instead of degrading to "edit: ?" / "Edited ?".
+_PI_INPUT_KEY_MAP = {
+    "filePath": "file_path",
+    "filepath": "file_path",
+    "path": "file_path",
+    "oldString": "old_string",
+    "oldstring": "old_string",
+    "newString": "new_string",
+    "newstring": "new_string",
+    "content": "content",
+    "command": "command",
+    "todos": "todos",
+    "todo": "todos",
+    "url": "url",
+    "pattern": "pattern",
+    "query": "query",
+}
+
+
+def _tool_name(name: str) -> str:
+    if not isinstance(name, str):
+        return "Unknown"
+    lowered = name.strip().lower()
+    if lowered in _PI_TO_CANONICAL:
+        return _PI_TO_CANONICAL[lowered]
+    if "_" in name:
+        return "".join(part[:1].upper() + part[1:] for part in name.split("_") if part)
+    return name[:1].upper() + name[1:]
+
+
+def _normalize_input(raw) -> dict:
+    """Map Pi tool_input keys to the snake_case shape cc.* helpers expect."""
+    if not isinstance(raw, dict):
+        if raw is None:
+            return {}
+        return {"raw": str(raw)}
+    out: dict = {}
+    for k, v in raw.items():
+        out[_PI_INPUT_KEY_MAP.get(k, k)] = v
+    return out
+
+
+def _extract_text(content) -> str:
+    if isinstance(content, str):
+        return content[:500]
+    if not isinstance(content, list):
+        return ""
+    texts = []
+    for item in content:
+        if isinstance(item, dict) and item.get("type") == "text":
+            text = item.get("text")
+            if isinstance(text, str) and text:
+                texts.append(text)
+    return " ".join(texts)[:500]
+
+
+def _normalize_response(event: dict) -> dict:
+    """Map Pi tool_result shape to the Claude hook's response schema."""
+    resp: dict = {"is_error": bool(event.get("isError", False))}
+    details = event.get("details")
+    content = event.get("content")
+
+    if isinstance(details, dict):
+        if isinstance(details.get("output"), str):
+            resp["output"] = details["output"][:500]
+        if isinstance(details.get("stdout"), str):
+            resp["stdout"] = details["stdout"][:500]
+        if isinstance(details.get("stderr"), str):
+            resp["stderr"] = details["stderr"][:300]
+        if isinstance(details.get("error"), str):
+            resp["error"] = details["error"][:300]
+        if isinstance(details.get("text"), str):
+            resp["text"] = details["text"][:500]
+        if "exitCode" in details:
+            resp["exit_code"] = details.get("exitCode")
+        if "cancelled" in details:
+            resp["interrupted"] = bool(details.get("cancelled"))
+        if "truncated" in details:
+            resp["truncated"] = bool(details.get("truncated"))
+        resp["details"] = details
+
+    text = _extract_text(content)
+    if text:
+        resp.setdefault("output", text)
+        resp["content"] = [{"type": "text", "text": text}]
+
+    if not any(k in resp for k in ("output", "stdout", "text", "content")):
+        if isinstance(details, str):
+            resp["output"] = details[:500]
+        elif details is not None:
+            resp["output"] = json.dumps(details, default=str)[:500]
+
+    return resp
+
+
+def _emit_malformed(reason: str, raw_excerpt: str) -> None:
+    """Record an explicit failure entry instead of silently logging a bogus
+    'Unknown success'. If Pi changes payload shape or sends malformed
+    JSON, this surfaces in AGENT_LEARNINGS.jsonl as a real signal.
+    """
+    excerpt = raw_excerpt[:200] if isinstance(raw_excerpt, str) else ""
+    # importance MUST be numeric — downstream salience_score() does
+    # `importance / 10.0` and a string would crash context_budget,
+    # show.py, and auto_dream readers. 5 ≈ "medium" on the 1-10 scale.
+    on_failure(
+        skill_name="pi",
+        action="hook:malformed_payload",
+        error=f"pi tool_result payload malformed: {reason}",
+        context=excerpt,
+        confidence=0.95,
+        importance=5,
+        pain_score=2,
+    )
+
+
+def main() -> None:
+    raw = ""
+    try:
+        raw = sys.stdin.read()
+    except OSError as e:
+        _emit_malformed(f"stdin read failed: {e}", "")
+        return
+
+    if not raw or not raw.strip():
+        _emit_malformed("empty payload", "")
+        return
+
+    try:
+        payload = json.loads(raw)
+    except json.JSONDecodeError as e:
+        _emit_malformed(f"json decode error: {e.msg}", raw)
+        return
+
+    if not isinstance(payload, dict):
+        _emit_malformed(f"payload is {type(payload).__name__}, expected object", raw)
+        return
+
+    if "tool_name" not in payload:
+        _emit_malformed("missing tool_name", raw)
+        return
+
+    tool_name = _tool_name(payload.get("tool_name") or "Unknown")
+    tool_input = _normalize_input(payload.get("tool_input"))
+    tool_response = _normalize_response(payload)
+
+    success = cc._is_success(tool_name, tool_input, tool_response)
+    importance = cc._importance(tool_name, json.dumps(tool_input))
+    action = cc._action_label(tool_name, tool_input)
+    reflection = cc._reflection(tool_name, tool_input, tool_response, success)
+    detail = cc._detail(tool_name, tool_input, tool_response, success)
+
+    pscore = cc._pain_score(importance, success)
+    if success:
+        log_execution(
+            skill_name="pi",
+            action=action,
+            result=detail,
+            success=True,
+            reflection=reflection,
+            importance=importance,
+            confidence=0.7,
+            pain_score=pscore,
+        )
+    else:
+        on_failure(
+            skill_name="pi",
+            action=action,
+            error=reflection,
+            context=detail,
+            confidence=0.7,
+            importance=importance,
+            pain_score=pscore,
+        )
+
+
+if __name__ == "__main__":
+    main()

README.md

@@ -224,7 +224,7 @@ verify_codex_fixes.py           # v0.8.0 regression checks (33 checks)
 | **OpenCode** | `AGENTS.md` + `opencode.json` | partial (permission rules) |
 | **OpenClaw** | `AGENTS.md` (auto-injected) + per-project `openclaw agents add --workspace` | varies by fork |
 | **Hermes Agent** | `AGENTS.md` (agentskills.io compatible) | partial (own memory) |
-| **Pi Coding Agent** | `AGENTS.md` + `.pi/skills/` | no (extension system) |
+| **Pi Coding Agent** | `AGENTS.md` + `.pi/skills/` + `.pi/extensions/` | yes (`tool_result` event) |
 | **Standalone Python** | `run.py` (any LLM) | yes (full control) |
 | **Antigravity** | `ANTIGRAVITY.md` | yes (system context) |
 

adapters/pi/AGENTS.md

@@ -45,4 +45,6 @@ them.
 - System prompt override: put `.pi/SYSTEM.md` at project root if you
   want to replace pi's default system prompt entirely.
 - Prompt templates go in `.pi/prompts/`.
-- TypeScript extensions go in `.pi/extensions/` (advanced).
+- TypeScript extensions go in `.pi/extensions/` (advanced). This adapter
+  installs `memory-hook.ts`, which logs `tool_result` events to episodic
+  memory automatically.

adapters/pi/README.md

@@ -10,6 +10,11 @@ on top so you keep one knowledge base even if you later swap harnesses.
 ./install.sh pi
 ```
 
+Or on Windows PowerShell:
+```powershell
+.\install.ps1 pi C:\path\to\your-project
+```
+
 Then install pi itself:
 ```bash
 npm install -g @mariozechner/pi-coding-agent
@@ -23,8 +28,11 @@ npm install -g @mariozechner/pi-coding-agent
 - `.pi/skills/` → symlink to `.agent/skills/`. Pi scans this path at
   startup. Symlink means there's one source of truth; customize under
   `.agent/skills/` and pi sees it immediately.
-- `.pi/` directory is created even if empty — ready for optional pi
-  extensions, prompt templates, and `.pi/SYSTEM.md` overrides.
+- `.pi/extensions/memory-hook.ts` — project-local extension that listens
+  to Pi's `tool_result` event and appends episodic entries via the shared
+  agentic-stack hook path.
+- `.pi/` directory is created for skills, extensions, prompt templates,
+  and optional `.pi/SYSTEM.md` overrides.
 
 ## Coexisting with other adapters
 Pi, hermes, and opencode all read `AGENTS.md`. You can install any
@@ -35,6 +43,15 @@ subsequent installs are no-ops on that file.
 In pi: ask "what's in my LESSONS file?" — it should read
 `.agent/memory/semantic/LESSONS.md`.
 
+Run one tool call, then inspect the episodic log:
+
+```bash
+tail -1 .agent/memory/episodic/AGENT_LEARNINGS.jsonl
+```
+
+You should see a `skill` of `pi` and an `action` derived from the tool
+that just ran.
+
 ## Optional
 If pi's default system prompt doesn't fit your workflow, drop a
 `.pi/SYSTEM.md` at project root. Pi uses it as a complete override.