test: cover dashboard tui navigation [skip ci]

Author: codejunkie99

harness_manager/dashboard_tui.py

@@ -812,6 +812,33 @@ def _open_section(section: str, target_root: Path, stack_root: Path) -> None:
         _pause()
 
 
+def _run_interactive(stdscr: Any, target: Path, stack: Path, curses_mod: Any) -> None:
+    try:
+        curses_mod.curs_set(0)
+    except Exception:
+        pass
+    stdscr.keypad(True)
+    section_idx = 0
+    while True:
+        _draw(stdscr, section_idx, target, stack, curses_mod)
+        key = stdscr.getch()
+        if key in (ord("q"), 27):
+            return
+        if key in (ord("j"), curses_mod.KEY_DOWN):
+            section_idx = min(len(SECTIONS) - 1, section_idx + 1)
+        elif key in (ord("k"), curses_mod.KEY_UP):
+            section_idx = max(0, section_idx - 1)
+        elif key == ord("r"):
+            continue
+        elif key in (10, 13, curses_mod.KEY_ENTER):
+            section = SECTIONS[section_idx]
+            curses_mod.endwin()
+            try:
+                _open_section(section, target, stack)
+            finally:
+                stdscr.clear()
+
+
 def run(target_root: Path | str, stack_root: Path | str, plain: bool = False) -> int:
     target = _logical_path(target_root)
     stack = Path(stack_root)
@@ -825,30 +852,7 @@ def run(target_root: Path | str, stack_root: Path | str, plain: bool = False) ->
         return 0
 
     def _main(stdscr: Any) -> None:
-        try:
-            curses.curs_set(0)
-        except Exception:
-            pass
-        stdscr.keypad(True)
-        section_idx = 0
-        while True:
-            _draw(stdscr, section_idx, target, stack, curses)
-            key = stdscr.getch()
-            if key in (ord("q"), 27):
-                return
-            if key in (ord("j"), curses.KEY_DOWN):
-                section_idx = min(len(SECTIONS) - 1, section_idx + 1)
-            elif key in (ord("k"), curses.KEY_UP):
-                section_idx = max(0, section_idx - 1)
-            elif key == ord("r"):
-                continue
-            elif key in (10, 13, curses.KEY_ENTER):
-                section = SECTIONS[section_idx]
-                curses.endwin()
-                try:
-                    _open_section(section, target, stack)
-                finally:
-                    stdscr.clear()
+        _run_interactive(stdscr, target, stack, curses)
 
     curses.wrapper(_main)
     return 0

test_dashboard_tui.py

@@ -9,6 +9,58 @@
 ROOT = Path(__file__).resolve().parent
 
 
+class FakeCurses:
+    A_BOLD = 1
+    KEY_DOWN = 258
+    KEY_UP = 259
+    KEY_ENTER = 343
+
+    def __init__(self):
+        self.cursor_values = []
+        self.endwin_count = 0
+
+    def curs_set(self, value):
+        self.cursor_values.append(value)
+
+    def endwin(self):
+        self.endwin_count += 1
+
+
+class FakeScreen:
+    def __init__(self, keys, height=32, width=100):
+        self.keys = list(keys)
+        self.height = height
+        self.width = width
+        self.keypad_enabled = None
+        self.clear_count = 0
+        self.current = {}
+        self.snapshots = []
+
+    def getmaxyx(self):
+        return self.height, self.width
+
+    def keypad(self, enabled):
+        self.keypad_enabled = enabled
+
+    def erase(self):
+        self.current = {}
+
+    def clear(self):
+        self.clear_count += 1
+        self.current = {}
+
+    def addstr(self, y, x, text, attr=0):
+        self.current[(y, x)] = text
+
+    def refresh(self):
+        self.snapshots.append(dict(self.current))
+
+    def getch(self):
+        if self.keys:
+            return self.keys.pop(0)
+        return ord("q")
+
+
 class DashboardTuiTest(unittest.TestCase):
     def make_project(self, root: Path) -> None:
         agent = root / ".agent"
@@ -229,6 +281,54 @@ def test_bare_installed_project_stays_script_safe_without_tty(self):
         self.assertEqual(result.returncode, 0, result.stderr)
         self.assertIn("open dashboard", result.stdout)
 
+    def test_interactive_dashboard_keypress_navigation(self):
+        from harness_manager import dashboard_tui
+
+        curses = FakeCurses()
+        screen = FakeScreen(
+            [
+                curses.KEY_DOWN,
+                curses.KEY_DOWN,
+                ord("r"),
+                curses.KEY_UP,
+                ord("q"),
+            ]
+        )
+        with tempfile.TemporaryDirectory() as tmp:
+            project = Path(tmp)
+            self.make_project(project)
+
+            dashboard_tui._run_interactive(screen, project, ROOT, curses)
+
+        self.assertEqual(curses.cursor_values, [0])
+        self.assertTrue(screen.keypad_enabled)
+        headings = [snapshot.get((4, 21)) for snapshot in screen.snapshots]
+        self.assertEqual(headings, ["Overview", "Adapters", "Doctor", "Doctor", "Adapters"])
+
+    def test_interactive_dashboard_enter_opens_selected_section(self):
+        from harness_manager import dashboard_tui
+
+        curses = FakeCurses()
+        screen = FakeScreen([curses.KEY_DOWN, curses.KEY_ENTER, ord("q")])
+        opened = []
+        original_open_section = dashboard_tui._open_section
+
+        def fake_open_section(section, target_root, stack_root):
+            opened.append((section, target_root, stack_root))
+
+        with tempfile.TemporaryDirectory() as tmp:
+            project = Path(tmp)
+            self.make_project(project)
+            try:
+                dashboard_tui._open_section = fake_open_section
+                dashboard_tui._run_interactive(screen, project, ROOT, curses)
+            finally:
+                dashboard_tui._open_section = original_open_section
+
+        self.assertEqual(opened, [("Adapters", project, ROOT)])
+        self.assertEqual(curses.endwin_count, 1)
+        self.assertEqual(screen.clear_count, 1)
+
 
 if __name__ == "__main__":
     unittest.main()