Codex drip code review fix

Author: Rajat

apps/web/graphql/courses/__tests__/update-group-drip.test.ts

@@ -2,6 +2,7 @@ import DomainModel from "@models/Domain";
 import UserModel from "@models/User";
 import CourseModel from "@models/Course";
 import constants from "@/config/constants";
+import { responses } from "@/config/strings";
 import { Constants } from "@courselit/common-models";
 import { updateGroup } from "../logic";
 
@@ -94,4 +95,51 @@ describe("updateGroup drip status updates", () => {
             2 * constants.relativeDripUnitInMillis,
         );
     });
+
+    it("rejects status-only drip updates when the group has no drip type yet", async () => {
+        const groupId = id("group-without-drip");
+        const course = await CourseModel.create({
+            domain: testDomain._id,
+            courseId: id("course-without-drip"),
+            title: id("course-title-without-drip"),
+            creatorId: adminUser.userId,
+            groups: [
+                {
+                    _id: groupId,
+                    name: "Group 1",
+                    rank: 1000,
+                    collapsed: true,
+                    lessonsOrder: [],
+                },
+            ],
+            lessons: [],
+            type: "course",
+            privacy: "unlisted",
+            costType: "free",
+            cost: 0,
+            slug: id("course-slug-without-drip"),
+        });
+
+        await expect(
+            updateGroup({
+                id: groupId,
+                courseId: course.courseId,
+                drip: {
+                    status: false,
+                },
+                ctx: {
+                    subdomain: testDomain,
+                    user: adminUser,
+                    address: "",
+                },
+            }),
+        ).rejects.toThrow(responses.invalid_input);
+
+        const updatedCourse = await CourseModel.findOne({
+            domain: testDomain._id,
+            courseId: course.courseId,
+        }).lean();
+
+        expect(updatedCourse?.groups?.[0]?.drip).toBeUndefined();
+    });
 });

apps/web/graphql/courses/logic.ts

@@ -815,6 +815,9 @@ export const updateGroup = async ({
     ctx: GQLContext;
 }) => {
     const course = await getCourseOrThrow(undefined, ctx, courseId);
+    const currentGroup = course.groups?.find((group) => group.id === id);
+    const existingDripType = currentGroup?.drip?.type;
+    const effectiveDripType = drip?.type || existingDripType;
 
     const $set = {};
     if (name) {
@@ -849,20 +852,26 @@ export const updateGroup = async ({
     }
 
     if (drip) {
+        const hasDripUpdates = Object.keys(drip).some((key) => key !== "type");
+
+        if (!effectiveDripType && hasDripUpdates) {
+            throw new Error(responses.invalid_input);
+        }
+
         if (typeof drip.status === "boolean") {
             $set["groups.$.drip.status"] = drip.status;
         }
         if (drip.type) {
             $set["groups.$.drip.type"] = drip.type;
         }
-        if (drip.type === Constants.dripType[0]) {
+        if (effectiveDripType === Constants.dripType[0]) {
             if (typeof drip.delayInMillis === "number") {
                 $set["groups.$.drip.delayInMillis"] =
                     drip.delayInMillis * constants.relativeDripUnitInMillis;
             }
             $set["groups.$.drip.dateInUTC"] = drip.dateInUTC;
         }
-        if (drip.type === Constants.dripType[1]) {
+        if (effectiveDripType === Constants.dripType[1]) {
             $set["groups.$.drip.delayInMillis"] = null;
             if (drip.dateInUTC) {
                 $set["groups.$.drip.dateInUTC"] = drip.dateInUTC;