Skip to content

Queue observability via Posthog #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajat1saxena merged 5 commits into from
Mar 23, 2026
Merged

Queue observability via Posthog #745

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c20c0b
bug fix: drip settings cannot be switched off
Mar 21, 2026
d49cd66
Test suite parallelization fix
Mar 22, 2026
95a4b2b
posthog observability for queue; drip refactoring;
Mar 22, 2026
381fd92
Changed messaging
Mar 23, 2026
8f64377
Codex drip code review fix
Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/graphql/courses/logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ export const updateGroup = async ({
}

if (drip) {
if (drip.status) {
if (typeof drip.status === "boolean") {
$set["groups.$.drip.status"] = drip.status;
Comment on lines +861 to 862
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve drip.type when accepting status: false

Because DripInput.type is optional in apps/web/graphql/courses/types/index.ts:86-95 but Drip.type is non-null on reads at apps/web/graphql/courses/types/index.ts:97-103, this new branch can create a partial groups.$.drip object when a client sends updateGroup(..., drip: { status: false }) for a group that has never had drip configured. In that case the mutation stores drip.status without any drip.type, and subsequent reads of that group can fail with Cannot return null for non-nullable field Drip.type.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

@rajat1saxena rajat1saxena Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if still valid as I applied the fix

Comment thread
rajat1saxena marked this conversation as resolved.
}
if (drip.type) {
Expand Down
Loading