feat: Standardize API error responses to { error: message } and refine sealMedia behavior with specific status codes.

Rajat · Rajat · commit 70887948172e · 2026-02-02T12:12:31.000+05:30
diff --git a/.migrations/00005-migrate-to-dual-bucket-architecture.js b/.migrations/00005-migrate-to-dual-bucket-architecture.js
diff --git a/apps/api/src/media/handlers.ts b/apps/api/src/media/handlers.ts
@@ -75,7 +75,7 @@ export async function uploadMedia(
         return res.status(200).json(media);
     } catch (err: any) {
         logger.error({ err }, err.message);
-        res.status(500).json({ error: err.message });
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -111,7 +111,7 @@ export async function getMedia(
         return res.status(200).json(result);
     } catch (err: any) {
         logger.error({ err }, err.message);
-        return res.status(500).json(err.message);
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -123,7 +123,7 @@ export async function getMediaCount(req: any, res: any) {
         const totalMediaFiles = await getCount({ userId, apikey });
         return res.status(200).json({ count: totalMediaFiles });
     } catch (err: any) {
-        return res.status(500).json(err.message);
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -140,7 +140,7 @@ export async function getTotalSpaceOccupied(req: any, res: any) {
                 : maxStorageAllowedNotSubscribed,
         });
     } catch (err: any) {
-        return res.status(500).json(err.message);
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -160,7 +160,7 @@ export async function getMediaDetails(req: any, res: any) {
         return res.status(200).json(media);
     } catch (err: any) {
         logger.error({ err }, err.message);
-        return res.status(500).json(err.message);
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -177,7 +177,7 @@ export async function deleteMedia(req: any, res: any) {
         return res.status(200).json({ message: SUCCESS });
     } catch (err: any) {
         logger.error({ err }, err.message);
-        return res.status(500).json(err.message);
+        return res.status(500).json({ error: err.message });
     }
 }
 
@@ -199,12 +199,15 @@ export async function sealMedia(req: any, res: any) {
 
         return res.status(200).json(mediaDetails);
     } catch (err: any) {
-        logger.error({ err }, err.message);
         const statusCode =
-            err.message === "Media not found" ||
-            err.message === "Media is already sealed"
+            err.message === "Media not found"
                 ? 404
-                : 500;
+                : err.message === "Media is already sealed"
+                  ? 409
+                  : 500;
+        if (statusCode === 500) {
+            logger.error({ err }, err.message);
+        }
         return res.status(statusCode).json({ error: err.message });
     }
 }
diff --git a/apps/api/src/media/service.ts b/apps/api/src/media/service.ts
@@ -372,7 +372,7 @@ async function sealMedia({
     }
 
     if (!media.temp) {
-        throw new Error("Media is already sealed");
+        return media;
     }
 
     const fileExtension = path.extname(media.fileName).replace(".", "");
diff --git a/apps/api/src/media/utils/get-public-urls.ts b/apps/api/src/media/utils/get-public-urls.ts
@@ -4,7 +4,7 @@ import {
     CLOUD_ENDPOINT,
     PATH_PREFIX,
     CLOUD_ENDPOINT_PUBLIC,
-} from "@/config/constants";
+} from "../../config/constants";
 import { Constants, Media } from "@medialit/models";
 
 const prefix = PATH_PREFIX ? `${PATH_PREFIX}/` : "";
diff --git a/docs/prds/dual-bucket-architecture.md b/docs/prds/dual-bucket-architecture.md
@@ -105,7 +105,7 @@ s3://public-bucket/
 - `CLOUD_REGION` - Region (if applicable)
 - `CLOUD_KEY` - Access key ID
 - `CLOUD_SECRET` - Secret access key
-- `CLOUD_PREFIX` - Optional prefix (if needed for multi-tenant)
+- `PATH_PREFIX` - Optional prefix (if needed for multi-tenant)
 
 **Note**: Both buckets MUST use the same credentials and endpoint. Different credentials/endpoints per bucket are out of scope for v1.
 
@@ -130,7 +130,7 @@ s3://public-bucket/
 **Implementation:**
 
 - `putObject()` uses `CLOUD_BUCKET_NAME`
-- Key generation: `{CLOUD_PREFIX}/{mediaId}/main.{ext}` (if prefix exists)
+- Key generation: `{PATH_PREFIX}/{mediaId}/main.{ext}` (if prefix exists)
 
 ---
 
@@ -164,8 +164,8 @@ s3://public-bucket/
 
 **Key Generation:**
 
-- Source: `{CLOUD_PREFIX}/{mediaId}/main.{ext}` in private bucket
-- Destination: `{CLOUD_PREFIX}/{mediaId}/main.{ext}` in public bucket (for public) or same private bucket (for private)
+- Source: `{PATH_PREFIX}/{mediaId}/main.{ext}` in private bucket
+- Destination: `{PATH_PREFIX}/{mediaId}/main.{ext}` in public bucket (for public) or same private bucket (for private)
 
 ---
 
@@ -184,7 +184,7 @@ s3://public-bucket/
 **Implementation:**
 
 - `deleteFolder()` operates on private bucket only
-- Prefix: `{CLOUD_PREFIX}/{mediaId}/` (if prefix exists)
+- Prefix: `{PATH_PREFIX}/{mediaId}/` (if prefix exists)
 
 ---
 
@@ -196,7 +196,7 @@ s3://public-bucket/
 
 - Source: Private bucket
 - Method: Generate signed URL using S3 presigner or CDN signer
-- Key: `{CLOUD_PREFIX}/{mediaId}/main.{ext}` or `{CLOUD_PREFIX}/{mediaId}/thumb.webp`
+- Key: `{PATH_PREFIX}/{mediaId}/main.{ext}` or `{PATH_PREFIX}/{mediaId}/thumb.webp`
 
 **Implementation:**
 
@@ -215,13 +215,13 @@ const url = await getS3SignedUrl(s3Client, command);
 
 - Source: Public bucket
 - Method: Direct HTTP URL or CDN URL
-- Key: `{CLOUD_PREFIX}/{mediaId}/main.{ext}` or `{CLOUD_PREFIX}/{mediaId}/thumb.webp`
+- Key: `{PATH_PREFIX}/{mediaId}/main.{ext}` or `{PATH_PREFIX}/{mediaId}/thumb.webp`
 
 **Implementation:**
 
 ```typescript
 // For public bucket
-const url = `${PUBLIC_ENDPOINT}/${key}`; // or `${CLOUDFRONT_ENDPOINT}/${key}`
+const url = `${PUBLIC_ENDPOINT}/${key}`; // or `${CDN_ENDPOINT}/${key}`
 ```
 
 ---
diff --git a/packages/medialit/src/index.ts b/packages/medialit/src/index.ts
@@ -95,7 +95,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Upload failed");
+            throw new Error(error.error || "Upload failed");
         }
 
         return response.json();
@@ -115,7 +115,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Deletion failed");
+            throw new Error(error.error || "Deletion failed");
         }
     }
 
@@ -130,7 +130,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Failed to seal media");
+            throw new Error(error.error || "Failed to seal media");
         }
 
         return response.json();
@@ -147,7 +147,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Failed to get media");
+            throw new Error(error.error || "Failed to get media");
         }
 
         return response.json();
@@ -179,7 +179,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Failed to list media");
+            throw new Error(error.error || "Failed to list media");
         }
 
         return response.json();
@@ -220,7 +220,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Failed to get count");
+            throw new Error(error.error || "Failed to get count");
         }
 
         const result = await response.json();
@@ -238,7 +238,7 @@ export class MediaLit {
 
         if (!response.ok) {
             const error = await response.json();
-            throw new Error(error.message || "Failed to get stats");
+            throw new Error(error.error || "Failed to get stats");
         }
 
         return response.json();

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export async function uploadMedia(`
`75`	`75`	`return res.status(200).json(media);`
`76`	`76`	`} catch (err: any) {`
`77`	`77`	`logger.error({ err }, err.message);`
`78`		`- res.status(500).json({ error: err.message });`
	`78`	`+ return res.status(500).json({ error: err.message });`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`
`@@ -111,7 +111,7 @@ export async function getMedia(`
`111`	`111`	`return res.status(200).json(result);`
`112`	`112`	`} catch (err: any) {`
`113`	`113`	`logger.error({ err }, err.message);`
`114`		`- return res.status(500).json(err.message);`
	`114`	`+ return res.status(500).json({ error: err.message });`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
`@@ -123,7 +123,7 @@ export async function getMediaCount(req: any, res: any) {`
`123`	`123`	`const totalMediaFiles = await getCount({ userId, apikey });`
`124`	`124`	`return res.status(200).json({ count: totalMediaFiles });`
`125`	`125`	`} catch (err: any) {`
`126`		`- return res.status(500).json(err.message);`
	`126`	`+ return res.status(500).json({ error: err.message });`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`
`@@ -140,7 +140,7 @@ export async function getTotalSpaceOccupied(req: any, res: any) {`
`140`	`140`	`: maxStorageAllowedNotSubscribed,`
`141`	`141`	`});`
`142`	`142`	`} catch (err: any) {`
`143`		`- return res.status(500).json(err.message);`
	`143`	`+ return res.status(500).json({ error: err.message });`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`
`@@ -160,7 +160,7 @@ export async function getMediaDetails(req: any, res: any) {`
`160`	`160`	`return res.status(200).json(media);`
`161`	`161`	`} catch (err: any) {`
`162`	`162`	`logger.error({ err }, err.message);`
`163`		`- return res.status(500).json(err.message);`
	`163`	`+ return res.status(500).json({ error: err.message });`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`
`@@ -177,7 +177,7 @@ export async function deleteMedia(req: any, res: any) {`
`177`	`177`	`return res.status(200).json({ message: SUCCESS });`
`178`	`178`	`} catch (err: any) {`
`179`	`179`	`logger.error({ err }, err.message);`
`180`		`- return res.status(500).json(err.message);`
	`180`	`+ return res.status(500).json({ error: err.message });`
`181`	`181`	`}`
`182`	`182`	`}`
`183`	`183`
`@@ -199,12 +199,15 @@ export async function sealMedia(req: any, res: any) {`
`199`	`199`
`200`	`200`	`return res.status(200).json(mediaDetails);`
`201`	`201`	`} catch (err: any) {`
`202`		`- logger.error({ err }, err.message);`
`203`	`202`	`const statusCode =`
`204`		`- err.message === "Media not found" \|\|`
`205`		`- err.message === "Media is already sealed"`
	`203`	`+ err.message === "Media not found"`
`206`	`204`	`? 404`
`207`		`- : 500;`
	`205`	`+ : err.message === "Media is already sealed"`
	`206`	`+ ? 409`
	`207`	`+ : 500;`
	`208`	`+ if (statusCode === 500) {`
	`209`	`+ logger.error({ err }, err.message);`
	`210`	`+ }`
`208`	`211`	`return res.status(statusCode).json({ error: err.message });`
`209`	`212`	`}`
`210`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ async function sealMedia({`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`if (!media.temp) {`
`375`		`- throw new Error("Media is already sealed");`
	`375`	`+ return media;`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`const fileExtension = path.extname(media.fileName).replace(".", "");`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ export class MediaLit {`
`95`	`95`
`96`	`96`	`if (!response.ok) {`
`97`	`97`	`const error = await response.json();`
`98`		`- throw new Error(error.message \|\| "Upload failed");`
	`98`	`+ throw new Error(error.error \|\| "Upload failed");`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`return response.json();`
`@@ -115,7 +115,7 @@ export class MediaLit {`
`115`	`115`
`116`	`116`	`if (!response.ok) {`
`117`	`117`	`const error = await response.json();`
`118`		`- throw new Error(error.message \|\| "Deletion failed");`
	`118`	`+ throw new Error(error.error \|\| "Deletion failed");`
`119`	`119`	`}`
`120`	`120`	`}`
`121`	`121`
`@@ -130,7 +130,7 @@ export class MediaLit {`
`130`	`130`
`131`	`131`	`if (!response.ok) {`
`132`	`132`	`const error = await response.json();`
`133`		`- throw new Error(error.message \|\| "Failed to seal media");`
	`133`	`+ throw new Error(error.error \|\| "Failed to seal media");`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`return response.json();`
`@@ -147,7 +147,7 @@ export class MediaLit {`
`147`	`147`
`148`	`148`	`if (!response.ok) {`
`149`	`149`	`const error = await response.json();`
`150`		`- throw new Error(error.message \|\| "Failed to get media");`
	`150`	`+ throw new Error(error.error \|\| "Failed to get media");`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`return response.json();`
`@@ -179,7 +179,7 @@ export class MediaLit {`
`179`	`179`
`180`	`180`	`if (!response.ok) {`
`181`	`181`	`const error = await response.json();`
`182`		`- throw new Error(error.message \|\| "Failed to list media");`
	`182`	`+ throw new Error(error.error \|\| "Failed to list media");`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`return response.json();`
`@@ -220,7 +220,7 @@ export class MediaLit {`
`220`	`220`
`221`	`221`	`if (!response.ok) {`
`222`	`222`	`const error = await response.json();`
`223`		`- throw new Error(error.message \|\| "Failed to get count");`
	`223`	`+ throw new Error(error.error \|\| "Failed to get count");`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`const result = await response.json();`
`@@ -238,7 +238,7 @@ export class MediaLit {`
`238`	`238`
`239`	`239`	`if (!response.ok) {`
`240`	`240`	`const error = await response.json();`
`241`		`- throw new Error(error.message \|\| "Failed to get stats");`
	`241`	`+ throw new Error(error.error \|\| "Failed to get stats");`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`return response.json();`