Codex suggested code review fixes

Author: Rajat

apps/api/src/media/routes.ts

@@ -188,7 +188,7 @@ router.post(
                 "application/json": {
                     schema: {
                         type: "array",
-                        items: { $ref: '#/components/schemas/Media' }
+                        items: { $ref: '#/components/schemas/MediaListItem' }
                     }
                 }
             }

apps/api/src/media/schemas.ts

@@ -26,14 +26,36 @@ export interface MediaResponse {
     group?: string;
 }
 
+export interface MediaListItemResponse {
+    mediaId: string;
+    originalFileName: string;
+    mimeType: string;
+    size: number;
+    access: AccessControl;
+    thumbnail: string;
+    caption?: string;
+    group?: string;
+}
+
 export const mediaResponseSchema = Joi.object<MediaResponse>({
     mediaId: Joi.string().required(),
     originalFileName: Joi.string().required(),
     mimeType: Joi.string().required(),
     size: Joi.number().required(),
     access: Joi.string().valid("public", "private").required(),
     file: Joi.string().uri().required(),
-    thumbnail: Joi.string().uri().optional(),
+    thumbnail: Joi.string().uri().optional().allow(""),
+    caption: Joi.string().optional().allow(""),
+    group: Joi.string().optional(),
+});
+
+export const mediaListItemResponseSchema = Joi.object<MediaListItemResponse>({
+    mediaId: Joi.string().required(),
+    originalFileName: Joi.string().required(),
+    mimeType: Joi.string().required(),
+    size: Joi.number().required(),
+    access: Joi.string().valid("public", "private").required(),
+    thumbnail: Joi.string().uri().optional().allow(""),
     caption: Joi.string().optional().allow(""),
     group: Joi.string().optional(),
 });

apps/api/src/swagger-generator.ts

@@ -7,6 +7,7 @@ import {
     uploadMediaSchema,
     getMediaSchema,
     mediaResponseSchema,
+    mediaListItemResponseSchema,
     mediaCountResponseSchema,
     mediaSizeResponseSchema,
 } from "./media/schemas";
@@ -107,6 +108,7 @@ swaggerAutogen()(outputFile, routes, doc).then(() => {
     content.components.schemas = {
         ...content.components.schemas,
         Media: joiToSwagger(mediaResponseSchema).swagger,
+        MediaListItem: joiToSwagger(mediaListItemResponseSchema).swagger,
         MediaSettings: joiToSwagger(mediaSettingsResponseSchema).swagger,
         MediaSettingsPayload: joiToSwagger(mediaSettingsSchema).swagger,
         UploadMediaPayload: joiToSwagger(uploadMediaSchema).swagger,
@@ -168,6 +170,20 @@ swaggerAutogen()(outputFile, routes, doc).then(() => {
                         },
                     },
                 };
+                operation.responses = operation.responses || {};
+                operation.responses["200"] = {
+                    description: "List retrieved successfully",
+                    content: {
+                        "application/json": {
+                            schema: {
+                                type: "array",
+                                items: {
+                                    $ref: "#/components/schemas/MediaListItem",
+                                },
+                            },
+                        },
+                    },
+                };
             }
 
             operation.responses = operation.responses || {};

apps/api/src/swagger_output.json

@@ -597,7 +597,7 @@
                 "schema": {
                   "type": "array",
                   "items": {
-                    "$ref": "#/components/schemas/Media"
+                    "$ref": "#/components/schemas/MediaListItem"
                   }
                 }
               }
@@ -869,6 +869,48 @@
         ],
         "additionalProperties": false
       },
+      "MediaListItem": {
+        "type": "object",
+        "properties": {
+          "mediaId": {
+            "type": "string"
+          },
+          "originalFileName": {
+            "type": "string"
+          },
+          "mimeType": {
+            "type": "string"
+          },
+          "size": {
+            "type": "number",
+            "format": "float"
+          },
+          "access": {
+            "type": "string",
+            "enum": [
+              "public",
+              "private"
+            ]
+          },
+          "thumbnail": {
+            "type": "string"
+          },
+          "caption": {
+            "type": "string"
+          },
+          "group": {
+            "type": "string"
+          }
+        },
+        "required": [
+          "mediaId",
+          "originalFileName",
+          "mimeType",
+          "size",
+          "access"
+        ],
+        "additionalProperties": false
+      },
       "MediaSettings": {
         "type": "object",
         "properties": {