Coded recommended changes

Author: Rajat

apps/api/src/media-settings/service.ts

@@ -1,21 +1,31 @@
 import * as queries from "./queries";
 import { MediaSettingsResponse } from "./schemas";
+import {
+    thumbnailHeight as defaultThumbnailHeight,
+    thumbnailWidth as defaultThumbnailWidth,
+} from "../config/constants";
 
 export async function getMediaSettings(
     userId: string,
     apikey: string,
-): Promise<MediaSettingsResponse | null> {
+): Promise<MediaSettingsResponse> {
     const mediaSettings = await queries.getMediaSettings(userId, apikey);
 
     if (!mediaSettings) {
-        return null; // Return null if not found to match the type
+        return {
+            useWebP: false,
+            webpOutputQuality: 0,
+            thumbnailHeight: defaultThumbnailHeight,
+            thumbnailWidth: defaultThumbnailWidth,
+        };
     }
 
     return {
         useWebP: mediaSettings.useWebP || false,
         webpOutputQuality: mediaSettings.webpOutputQuality || 0,
-        thumbnailHeight: mediaSettings.thumbnailHeight || 0,
-        thumbnailWidth: mediaSettings.thumbnailWidth || 0,
+        thumbnailHeight:
+            mediaSettings.thumbnailHeight || defaultThumbnailHeight,
+        thumbnailWidth: mediaSettings.thumbnailWidth || defaultThumbnailWidth,
     };
 }
 

apps/api/src/media/schemas.ts

@@ -33,7 +33,7 @@ export const mediaResponseSchema = Joi.object<MediaResponse>({
     size: Joi.number().required(),
     access: Joi.string().valid("public", "private").required(),
     file: Joi.string().uri().required(),
-    thumbnail: Joi.string().uri().required(),
+    thumbnail: Joi.string().uri().optional(),
     caption: Joi.string().optional().allow(""),
     group: Joi.string().optional(),
 });

apps/api/src/swagger-generator.ts

@@ -147,10 +147,6 @@ swaggerAutogen()(outputFile, routes, doc).then(() => {
                 });
             }
 
-            if (apiPath === "/media/create" && method === "post") {
-                operation.security = [{ apiKeyAuth: [] }];
-            }
-
             if (apiPath === "/health" && method === "get") {
                 operation.security = [];
             }

apps/api/src/swagger_output.json

@@ -857,8 +857,7 @@
           "mimeType",
           "size",
           "access",
-          "file",
-          "thumbnail"
+          "file"
         ],
         "additionalProperties": false
       },