chore: rename env var from WORKFLOWS to WORKFLOW for consistency

mrsimpson · mrsimpson · commit 288408a4f0e1 · 2026-04-02T12:41:15.000+02:00
diff --git a/.opencode/commands/workflow.md b/.opencode/commands/workflow.md
@@ -14,5 +14,5 @@ When workflows are disabled, the plugin will not inject development instructions
 You can also set the initial state via environment variable:
 
 ```bash
-WORKFLOWS=off opencode
+WORKFLOW=off opencode
 ```
diff --git a/.vibe/development-plan-disable-plugin-env-var.md b/.vibe/development-plan-disable-plugin-env-var.md
@@ -0,0 +1,38 @@
+# Development Plan: responsible-vibe (disable-plugin-env-var branch)
+
+*Generated on 2026-04-02 by Vibe Feature MCP*
+*Workflow: [minor](https://mrsimpson.github.io/responsible-vibe-mcp/workflows/minor)*
+
+## Goal
+*Define what you're building or fixing - this will be updated as requirements are gathered*
+## Key Decisions
+*Important decisions will be documented here as they are made*
+
+## Notes
+*Additional context and observations*
+
+## Explore
+### Tasks
+- [ ] *Tasks will be added as they are identified*
+
+### Completed
+- [x] Created development plan file
+
+## Implement
+### Tasks
+- [ ] *To be added when this phase becomes active*
+
+### Completed
+*None yet*
+
+## Finalize
+### Tasks
+- [ ] *To be added when this phase becomes active*
+
+### Completed
+*None yet*
+
+
+
+---
+*This plan is maintained by the LLM. Tool responses provide guidance on which section to focus on and what tasks to work on.*
diff --git a/packages/core/src/workflow-manager.ts b/packages/core/src/workflow-manager.ts
@@ -49,13 +49,13 @@ export class WorkflowManager {
   }
 
   /**
-   * Parse enabled domains from environment variable
-   * Supports both WORKFLOW_DOMAINS and VIBE_WORKFLOW_DOMAINS (legacy)
-   * WORKFLOW_DOMAINS takes precedence if both are set (modern, non-prefixed version preferred)
+   * Parse enabled domains from environment variable.
+   * WORKFLOW_DOMAINS is the canonical name.
+   * VIBE_WORKFLOW_DOMAINS is supported as a legacy alias for backward compatibility.
+   * WORKFLOW_DOMAINS takes precedence when both are set.
    */
   private parseEnabledDomains(): Set<string> {
-    // Check both WORKFLOW_DOMAINS and VIBE_WORKFLOW_DOMAINS
-    // WORKFLOW_DOMAINS (modern) takes precedence over VIBE_WORKFLOW_DOMAINS (legacy)
+    // WORKFLOW_DOMAINS (canonical) takes precedence over VIBE_WORKFLOW_DOMAINS (legacy alias)
     const domainsEnv =
       process.env['WORKFLOW_DOMAINS'] || process.env['VIBE_WORKFLOW_DOMAINS'];
 
@@ -74,7 +74,7 @@ export class WorkflowManager {
     logger.debug('Parsed enabled domains', {
       source: process.env['WORKFLOW_DOMAINS']
         ? 'WORKFLOW_DOMAINS'
-        : 'VIBE_WORKFLOW_DOMAINS',
+        : 'VIBE_WORKFLOW_DOMAINS (legacy)',
       domains: Array.from(domains),
     });
 
@@ -187,17 +187,17 @@ export class WorkflowManager {
    */
   public getAllAvailableWorkflows(): WorkflowInfo[] {
     // Create a temporary manager with all domains enabled
-    const originalEnv = process.env.VIBE_WORKFLOW_DOMAINS;
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code,architecture,office,sdd';
+    const originalEnv = process.env['WORKFLOW_DOMAINS'];
+    process.env['WORKFLOW_DOMAINS'] = 'code,architecture,office,sdd';
 
     try {
       const tempManager = new WorkflowManager();
       return tempManager.getAvailableWorkflows();
     } finally {
       if (originalEnv !== undefined) {
-        process.env.VIBE_WORKFLOW_DOMAINS = originalEnv;
+        process.env['WORKFLOW_DOMAINS'] = originalEnv;
       } else {
-        delete process.env.VIBE_WORKFLOW_DOMAINS;
+        delete process.env['WORKFLOW_DOMAINS'];
       }
     }
   }
@@ -323,7 +323,7 @@ export class WorkflowManager {
         this.getAvailableWorkflowsForProject(projectPath);
       if (availableWorkflows.length === 0) {
         throw new Error(
-          'No workflows available. Please install a workflow or adjust VIBE_WORKFLOW_DOMAINS environment variable.'
+          'No workflows available. Please install a workflow or adjust WORKFLOW_DOMAINS environment variable.'
         );
       }
       workflowName = availableWorkflows[0].name;
diff --git a/packages/core/test/unit/custom-workflow-loading.test.ts b/packages/core/test/unit/custom-workflow-loading.test.ts
@@ -9,24 +9,24 @@ describe('Custom Workflow Loading', () => {
   let originalEnv: string | undefined;
 
   beforeEach(() => {
-    originalEnv = process.env.VIBE_WORKFLOW_DOMAINS;
+    originalEnv = process.env.WORKFLOW_DOMAINS;
     testProjectPath = fs.mkdtempSync(
       path.join(tmpdir(), 'custom-workflow-test-')
     );
   });
 
   afterEach(() => {
     if (originalEnv !== undefined) {
-      process.env.VIBE_WORKFLOW_DOMAINS = originalEnv;
+      process.env.WORKFLOW_DOMAINS = originalEnv;
     } else {
-      delete process.env.VIBE_WORKFLOW_DOMAINS;
+      delete process.env.WORKFLOW_DOMAINS;
     }
 
     fs.rmSync(testProjectPath, { recursive: true, force: true });
   });
 
   it('should load custom workflow from .vibe/workflows directory', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code';
+    process.env.WORKFLOW_DOMAINS = 'code';
 
     const workflowsDir = path.join(testProjectPath, '.vibe', 'workflows');
     fs.mkdirSync(workflowsDir, { recursive: true });
@@ -73,7 +73,7 @@ describe('Custom Workflow Loading', () => {
   });
 
   it('should load multiple custom workflows', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code';
+    process.env.WORKFLOW_DOMAINS = 'code';
 
     const workflowsDir = path.join(testProjectPath, '.vibe', 'workflows');
     fs.mkdirSync(workflowsDir, { recursive: true });
@@ -133,7 +133,7 @@ describe('Custom Workflow Loading', () => {
   });
 
   it('should ignore domain filtering for custom workflows', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code'; // Only code domain
+    process.env.WORKFLOW_DOMAINS = 'code'; // Only code domain
 
     const workflowsDir = path.join(testProjectPath, '.vibe', 'workflows');
     fs.mkdirSync(workflowsDir, { recursive: true });
diff --git a/packages/core/test/unit/workflow-domain-filtering.test.ts b/packages/core/test/unit/workflow-domain-filtering.test.ts
@@ -5,19 +5,19 @@ describe('Workflow Domain Filtering', () => {
   let originalEnv: string | undefined;
 
   beforeEach(() => {
-    originalEnv = process.env.VIBE_WORKFLOW_DOMAINS;
+    originalEnv = process.env.WORKFLOW_DOMAINS;
   });
 
   afterEach(() => {
     if (originalEnv !== undefined) {
-      process.env.VIBE_WORKFLOW_DOMAINS = originalEnv;
+      process.env.WORKFLOW_DOMAINS = originalEnv;
     } else {
-      delete process.env.VIBE_WORKFLOW_DOMAINS;
+      delete process.env.WORKFLOW_DOMAINS;
     }
   });
 
   it('should load only code workflows when no domain filter is set', () => {
-    delete process.env.VIBE_WORKFLOW_DOMAINS;
+    delete process.env.WORKFLOW_DOMAINS;
 
     const manager = new WorkflowManager();
     const workflows = manager.getAvailableWorkflows();
@@ -34,8 +34,8 @@ describe('Workflow Domain Filtering', () => {
     expect(nonCodeWorkflows.length).toBe(0);
   });
 
-  it('should filter workflows by domain when VIBE_WORKFLOW_DOMAINS is set', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code';
+  it('should filter workflows by domain when WORKFLOW_DOMAINS is set', () => {
+    process.env.WORKFLOW_DOMAINS = 'code';
 
     const manager = new WorkflowManager();
     const workflows = manager.getAvailableWorkflows();
@@ -51,7 +51,7 @@ describe('Workflow Domain Filtering', () => {
   });
 
   it('should support multiple domains', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code,office';
+    process.env.WORKFLOW_DOMAINS = 'code,office';
 
     const manager = new WorkflowManager();
     const workflows = manager.getAvailableWorkflows();
@@ -64,7 +64,7 @@ describe('Workflow Domain Filtering', () => {
   });
 
   it('should handle invalid domains gracefully', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code,invalid,office';
+    process.env.WORKFLOW_DOMAINS = 'code,invalid,office';
 
     const manager = new WorkflowManager();
     const workflows = manager.getAvailableWorkflows();
diff --git a/packages/core/test/unit/workflow-domains-precedence.test.ts b/packages/core/test/unit/workflow-domains-precedence.test.ts
@@ -1,7 +1,7 @@
 import { describe, it, expect, afterEach } from 'vitest';
 import { WorkflowManager } from '../../src/workflow-manager.js';
 
-describe('WORKFLOW_DOMAINS precedence', () => {
+describe('WORKFLOW_DOMAINS precedence (backward compat)', () => {
   const originalVibe = process.env.VIBE_WORKFLOW_DOMAINS;
   const originalWorkflow = process.env.WORKFLOW_DOMAINS;
 
@@ -13,7 +13,7 @@ describe('WORKFLOW_DOMAINS precedence', () => {
     else delete process.env.WORKFLOW_DOMAINS;
   });
 
-  it('should prefer WORKFLOW_DOMAINS over VIBE_WORKFLOW_DOMAINS', () => {
+  it('should prefer WORKFLOW_DOMAINS over legacy VIBE_WORKFLOW_DOMAINS when both are set', () => {
     delete process.env['VIBE_WORKFLOW_DOMAINS'];
     delete process.env['WORKFLOW_DOMAINS'];
 
@@ -40,10 +40,11 @@ describe('WORKFLOW_DOMAINS precedence', () => {
     expect(hasArchitecture).toBe(true);
   });
 
-  it('should use VIBE_WORKFLOW_DOMAINS when WORKFLOW_DOMAINS is not set', () => {
+  it('should fall back to legacy VIBE_WORKFLOW_DOMAINS when WORKFLOW_DOMAINS is not set', () => {
     delete process.env['VIBE_WORKFLOW_DOMAINS'];
     delete process.env['WORKFLOW_DOMAINS'];
 
+    // Simulate a user who still has the old VIBE_WORKFLOW_DOMAINS set
     process.env['VIBE_WORKFLOW_DOMAINS'] = 'code';
 
     const manager = new WorkflowManager();
diff --git a/packages/core/test/unit/workflow-override-by-name.test.ts b/packages/core/test/unit/workflow-override-by-name.test.ts
@@ -9,24 +9,24 @@ describe('Workflow Override by Name', () => {
   let originalEnv: string | undefined;
 
   beforeEach(() => {
-    originalEnv = process.env.VIBE_WORKFLOW_DOMAINS;
+    originalEnv = process.env.WORKFLOW_DOMAINS;
     testProjectPath = fs.mkdtempSync(
       path.join(tmpdir(), 'workflow-override-test-')
     );
   });
 
   afterEach(() => {
     if (originalEnv !== undefined) {
-      process.env.VIBE_WORKFLOW_DOMAINS = originalEnv;
+      process.env.WORKFLOW_DOMAINS = originalEnv;
     } else {
-      delete process.env.VIBE_WORKFLOW_DOMAINS;
+      delete process.env.WORKFLOW_DOMAINS;
     }
 
     fs.rmSync(testProjectPath, { recursive: true, force: true });
   });
 
   it('should override predefined workflow by YAML name, not filename', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code';
+    process.env.WORKFLOW_DOMAINS = 'code';
 
     const workflowsDir = path.join(testProjectPath, '.vibe', 'workflows');
     fs.mkdirSync(workflowsDir, { recursive: true });
@@ -67,7 +67,7 @@ describe('Workflow Override by Name', () => {
   });
 
   it('should use YAML name as workflow key, not filename', () => {
-    process.env.VIBE_WORKFLOW_DOMAINS = 'code';
+    process.env.WORKFLOW_DOMAINS = 'code';
 
     const workflowsDir = path.join(testProjectPath, '.vibe', 'workflows');
     fs.mkdirSync(workflowsDir, { recursive: true });
diff --git a/packages/core/test/unit/workflow-validation.test.ts b/packages/core/test/unit/workflow-validation.test.ts
@@ -40,8 +40,8 @@ describe('Workflow Validation', () => {
 
     it('should load ALL workflow files from resources directory', () => {
       // Temporarily disable domain filtering for this test
-      const originalEnv = process.env.VIBE_WORKFLOW_DOMAINS;
-      process.env.VIBE_WORKFLOW_DOMAINS =
+      const originalEnv = process.env.WORKFLOW_DOMAINS;
+      process.env.WORKFLOW_DOMAINS =
         'code,architecture,office,sdd,sdd-crowd,children,skilled';
 
       try {
@@ -63,9 +63,9 @@ describe('Workflow Validation', () => {
         }
       } finally {
         if (originalEnv !== undefined) {
-          process.env.VIBE_WORKFLOW_DOMAINS = originalEnv;
+          process.env.WORKFLOW_DOMAINS = originalEnv;
         } else {
-          delete process.env.VIBE_WORKFLOW_DOMAINS;
+          delete process.env.WORKFLOW_DOMAINS;
         }
       }
     });
diff --git a/packages/docs/user/crowd-mcp-integration.md b/packages/docs/user/crowd-mcp-integration.md
@@ -23,7 +23,7 @@ This creates three agent configurations in `.crowd/agents/`:
 Each agent is pre-configured with:
 
 - `VIBE_ROLE` environment variable (business-analyst, architect, or developer)
-- `VIBE_WORKFLOW_DOMAINS=sdd-crowd` to access collaborative workflows
+- `WORKFLOW_DOMAINS=sdd-crowd` to access collaborative workflows
 - System prompts explaining team collaboration
 - MCP server connection to workflows server
 
@@ -248,7 +248,7 @@ mcpServers:
     args: [@codemcp/workflows-server@latest]
     env:
       VIBE_ROLE: business-analyst
-      VIBE_WORKFLOW_DOMAINS: sdd-crowd
+      WORKFLOW_DOMAINS: sdd-crowd
 ```
 
 ## Workflow Features
@@ -444,7 +444,7 @@ When transitioning phases:
 - **VIBE_ROLE**: Agent's role (business-analyst, architect, developer)
   - Required for collaborative workflows
   - Optional for single-agent workflows
-- **VIBE_WORKFLOW_DOMAINS**: Filter workflows by domain
+- **WORKFLOW_DOMAINS**: Filter workflows by domain
   - Set to `sdd-crowd` for collaborative workflows
   - Can combine: `sdd-crowd,sdd` for both
 
diff --git a/packages/docs/user/custom-workflows.md b/packages/docs/user/custom-workflows.md
@@ -28,7 +28,7 @@ Workflows are organized by domains to keep things manageable:
 **Control which domains are loaded:**
 
 ```bash
-export VIBE_WORKFLOW_DOMAINS="code,architecture"
+export WORKFLOW_DOMAINS="code,architecture"
 # Only loads workflows from code and architecture domains
 ```
 
@@ -153,13 +153,13 @@ The copied workflow will have:
 
 ```bash
 # Default: only 'code' domain workflows
-VIBE_WORKFLOW_DOMAINS="code"
+WORKFLOW_DOMAINS="code"
 
 # Multiple domains
-VIBE_WORKFLOW_DOMAINS="code,architecture,office"
+WORKFLOW_DOMAINS="code,architecture,office"
 
 # All domains
-VIBE_WORKFLOW_DOMAINS="code,architecture,office"
+WORKFLOW_DOMAINS="code,architecture,office"
 ```
 
 ## Project-Specific Configuration
diff --git a/packages/docs/user/packaged-workflows.md b/packages/docs/user/packaged-workflows.md
@@ -19,7 +19,7 @@ Instead, they are organized into multiple domains and you can decide which ones
 When running the MCP-server (or configuring your agent how to run it), pass an environment variable to define the domains you'd like to use.
 
 ```bash
-export VIBE_WORKFLOW_DOMAINS="code,architecture"
+export WORKFLOW_DOMAINS="code,architecture"
 # Only loads workflows from code and architecture domains
 ```
 
diff --git a/packages/mcp-server/src/server-helpers.ts b/packages/mcp-server/src/server-helpers.ts
@@ -125,10 +125,10 @@ export function createConversationNotFoundResult(
 ): HandlerResult<never> {
   if (availableWorkflows.length === 0) {
     return createErrorResult(
-      'No development conversation has been started for this project. Please call start_development() to begin. First, set up workflows by adjusting the VIBE_WORKFLOW_DOMAINS environment variable or copying a workflow to .vibe/workflows/ directory.',
+      'No development conversation has been started for this project. Please call start_development() to begin. First, set up workflows by adjusting the WORKFLOW_DOMAINS environment variable or copying a workflow to .vibe/workflows/ directory.',
       {
         suggestion:
-          'Set VIBE_WORKFLOW_DOMAINS=code,architecture,office or copy a workflow file to .vibe/workflows/',
+          'Set WORKFLOW_DOMAINS=code,architecture,office or copy a workflow file to .vibe/workflows/',
         availableWorkflows: [],
       }
     );
diff --git a/packages/mcp-server/test/unit/conversation-not-found-error.test.ts b/packages/mcp-server/test/unit/conversation-not-found-error.test.ts
@@ -113,7 +113,7 @@ describe('CONVERSATION_NOT_FOUND error handling', () => {
       // The actual scenario is covered by the server-helpers.ts implementation
 
       // Test is implicit: if no workflows are available, the error should mention
-      // VIBE_WORKFLOW_DOMAINS environment variable (see server-helpers.ts line 113)
+      // WORKFLOW_DOMAINS environment variable (see server-helpers.ts line 113)
       expect(true).toBe(true);
     });
   });
diff --git a/packages/opencode-plugin/src/plugin.ts b/packages/opencode-plugin/src/plugin.ts
@@ -115,7 +115,7 @@ export const WorkflowsPlugin: Plugin = async (
   });
 
   // Initialize workflows enabled state from environment variable
-  const envWorkflows = process.env.WORKFLOWS?.toLowerCase();
+  const envWorkflows = process.env.WORKFLOW?.toLowerCase();
   let workflowsEnabled = envWorkflows === 'off' ? false : true; // default: enabled
   logger.info('Workflows state initialized', { workflowsEnabled });
 
@@ -498,7 +498,7 @@ ACTION REQUIRED: Use transition_phase tool to move to a phase that allows editin
      */
     tool: await (async (): Promise<{ [key: string]: ToolDefinition }> => {
       const DISABLED_MSG =
-        'Workflows are disabled (WORKFLOWS=off). Enable with /workflow on or /wf on';
+        'Workflows are disabled (WORKFLOW=off). Enable with /workflow on or /wf on';
       const wrap = (def: ToolDefinition): ToolDefinition => ({
         ...def,
         execute: async (args, ctx) => {
diff --git a/packages/opencode-plugin/src/tool-handlers/start-development.ts b/packages/opencode-plugin/src/tool-handlers/start-development.ts
diff --git a/packages/opencode-plugin/test/e2e/plugin.test.ts b/packages/opencode-plugin/test/e2e/plugin.test.ts
diff --git a/packages/opencode-plugin/test/unit/start-development-domain-filtering.test.ts b/packages/opencode-plugin/test/unit/start-development-domain-filtering.test.ts
