Fix ask for permissions (#268)

## Root Cause

OpenCode PR [#21986](anomalyco/opencode#21986) (merged **April 10, 2026**, commit `bfef334b`) deliberately changed `ToolContext.ask` in the plugin SDK from returning `Promise<void>` to `Effect.Effect<void>`:

```diff
-  ask(input: AskInput): Promise<void>
+  ask(input: AskInput): Effect.Effect<void>
```

This broke the previous fix from commit `9e92eb3` (April 1, 2026), which used `await context.ask(...)` and worked correctly at the time. After the opencode change, `await`-ing an Effect object is a no-op — the Effect is never executed, so the permission prompt was silently skipped.

## Fix

Add `effect` as a peer dependency (it is always present in the process since the plugin runs inside opencode) and a dev dependency for local type checking. Use `Effect.runPromise()` to bridge the Effect into the async/await context of the plugin's `execute` functions.

The `ask` call is centralised in the `wrap()` decorator in `plugin.ts` so all five tools get permission enforcement without duplicating the call in each handler.

## Changes

- `package.json`: add `effect >=3.0.0` as peer + dev dependency
- `src/types.ts`: fix local `ToolContext.ask` type to match real SDK (`Effect.Effect<void>`)
- `src/plugin.ts`: use `Effect.runPromise(ctx.ask(...))` in the `wrap()` decorator; import `Effect` from `effect`
- `test/e2e/plugin.test.ts`: update `createMockToolContext()` helper; mock `ask` returns `Effect.void` instead of a resolved Promise

Author: mrsimpson

packages/opencode-plugin/package.json

@@ -29,16 +29,21 @@
   "devDependencies": {
     "@codemcp/workflows-core": "workspace:*",
     "@codemcp/workflows-server": "workspace:*",
+    "effect": "3.21.1",
     "rimraf": "^6.0.1",
     "tsup": "^8.0.0",
     "vitest": "4.0.18"
   },
   "peerDependencies": {
-    "@anthropic-ai/sdk": "*"
+    "@anthropic-ai/sdk": "*",
+    "effect": ">=3.0.0"
   },
   "peerDependenciesMeta": {
     "@anthropic-ai/sdk": {
       "optional": true
+    },
+    "effect": {
+      "optional": true
     }
   },
   "keywords": [

packages/opencode-plugin/src/plugin.ts

@@ -13,6 +13,7 @@
  */
 
 import type { Plugin, PluginInput, Hooks, ToolDefinition } from './types.js';
+import { Effect } from 'effect';
 import { createProceedToPhaseTool } from './tool-handlers/proceed-to-phase.js';
 import { createConductReviewTool } from './tool-handlers/conduct-review.js';
 import { createResetDevelopmentTool } from './tool-handlers/reset-development.js';
@@ -652,12 +653,14 @@ ACTION REQUIRED: Use transition_phase tool to move to a phase that allows editin
             );
           }
 
-          await ctx.ask({
-            permission: toolName,
-            patterns: ['*'],
-            always: ['*'],
-            metadata: {},
-          });
+          await Effect.runPromise(
+            ctx.ask({
+              permission: toolName,
+              patterns: ['*'],
+              always: ['*'],
+              metadata: {},
+            })
+          );
 
           return def.execute(args, ctx);
         },

packages/opencode-plugin/src/types.ts

@@ -51,6 +51,8 @@ export type PluginInput = {
 };
 
 // Tool context for custom tools
+import type { Effect } from 'effect';
+
 export type ToolContext = {
   sessionID: string;
   messageID: string;
@@ -64,7 +66,7 @@ export type ToolContext = {
     patterns: string[];
     always: string[];
     metadata: Record<string, unknown>;
-  }): Promise<void>;
+  }): Effect.Effect<void>;
 };
 
 // Tool definition

packages/opencode-plugin/test/e2e/plugin.test.ts

@@ -6,6 +6,7 @@
  */
 
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { Effect } from 'effect';
 import * as fs from 'node:fs';
 import * as path from 'node:path';
 import { tmpdir } from 'node:os';
@@ -63,7 +64,7 @@ function createMockToolContext(overrides: Record<string, unknown> = {}) {
     worktree: '',
     abort: new AbortController().signal,
     metadata: vi.fn(),
-    ask: vi.fn().mockResolvedValue(undefined),
+    ask: vi.fn().mockReturnValue(Effect.void),
     ...overrides,
   };
 }