fix: Link opencode session and opencode tui extension

mrsimpson · web-flow · commit 5b3a9e6f2dbe · 2026-04-01T10:35:48.000+02:00
* fix: properly isolate workflow state by OpenCode session ID

The TUI plugin was incorrectly falling back to the most recently modified
workflow state when no state was found for the current session. This caused
new OpenCode sessions to display workflow state from previous sessions.

Changes:
1. Remove fallback to readLatestState() in TUI plugin initialization
2. Remove fallback to readLatestState() in event handler
3. Remove unused readLatestState() function
4. Only use session ID-based state lookup to ensure proper isolation

This ensures that when a new OpenCode session starts with no active workflow,
the TUI correctly shows no workflow state instead of showing the previous
session's workflow.

* ui: show 'No Active Workflow' in TUI when no workflow is active for the session

When the TUI plugin detects that no workflow state exists for the current
OpenCode session, it now explicitly displays 'No Active Workflow' instead of
hiding the component. This makes it clear that no workflow is currently
active, rather than being ambiguous about the state.

This improves UX by:
- Making the workflow state always visible
- Being explicit about the absence of an active workflow
- Guiding users to start a workflow when needed
diff --git a/packages/opencode-plugin/src/plugin.ts b/packages/opencode-plugin/src/plugin.ts
@@ -123,13 +123,16 @@ export const WorkflowsPlugin: Plugin = async (
   const planManager = new PlanManager();
   const instructionGenerator = new InstructionGenerator();
 
-  // Cached ServerContext - created once, reused for all requests
+  // Cached ServerContext - created once, reused for all requests within a session
   // This avoids creating new WorkflowManager/PluginRegistry instances per request
+  // When the OpenCode session changes, the context is invalidated to prevent
+  // showing workflow state from a previous session
   let cachedServerContext: Awaited<
     ReturnType<typeof createServerContext>
   > | null = null;
   let serverContextInitialized = false;
   let currentSessionId: string | null = null;
+  let lastKnownSessionId: string | null = null;
 
   // Buffered instructions from tools (proceed_to_phase, start_development).
   // Consumed and cleared by the next chat.message hook call.
@@ -149,8 +152,21 @@ export const WorkflowsPlugin: Plugin = async (
   }
 
   // Helper to get an initialized ServerContext for handler delegation
-  // Creates once, reuses for all subsequent calls
+  // Creates once per session, reuses for all subsequent calls within the same session.
+  // If the session ID changes, the cached context is invalidated to prevent
+  // showing workflow state from a previous OpenCode session.
   async function getServerContext() {
+    // Invalidate cache if session ID has changed
+    if (currentSessionId && currentSessionId !== lastKnownSessionId) {
+      logger.debug('Session ID changed, invalidating cached ServerContext', {
+        oldSessionId: lastKnownSessionId,
+        newSessionId: currentSessionId,
+      });
+      cachedServerContext = null;
+      serverContextInitialized = false;
+      lastKnownSessionId = currentSessionId;
+    }
+
     if (!cachedServerContext) {
       const sessionMetadata = currentSessionId
         ? {
@@ -234,10 +250,22 @@ export const WorkflowsPlugin: Plugin = async (
      * We add a synthetic part with phase instructions.
      */
     'chat.message': async (hookInput, output) => {
-      // Capture session ID from the first hook that has it
-      if (hookInput.sessionID && !currentSessionId) {
-        currentSessionId = hookInput.sessionID;
-        logger.debug('Captured session ID', { sessionId: currentSessionId });
+      // Capture session ID and detect session changes
+      if (hookInput.sessionID) {
+        if (!currentSessionId) {
+          currentSessionId = hookInput.sessionID;
+          lastKnownSessionId = hookInput.sessionID;
+          logger.debug('Captured initial session ID', {
+            sessionId: currentSessionId,
+          });
+        } else if (currentSessionId !== hookInput.sessionID) {
+          // Session has changed - the getServerContext() function will handle invalidation
+          currentSessionId = hookInput.sessionID;
+          logger.info('Session ID changed', {
+            oldSessionId: lastKnownSessionId,
+            newSessionId: currentSessionId,
+          });
+        }
       }
 
       // Skip if workflows are disabled
diff --git a/packages/opencode-tui-plugin/workflows-phase.tsx b/packages/opencode-tui-plugin/workflows-phase.tsx
@@ -86,49 +86,6 @@ function readStateBySessionId(
   }
 }
 
-/**
- * Fallback: Read the most recently modified state.
- * Used when no matching session ID is found or for backward compatibility.
- * This is deprecated in favor of sessionId-based lookup.
- */
-function readLatestState(
-  sessionDir: string
-): { phase: string; workflow: string } | null {
-  try {
-    // require() is intentional: top-level ESM imports of Node built-ins are not
-    // supported in the Bun plugin runtime.
-    // eslint-disable-next-line @typescript-eslint/no-require-imports
-    const fsSync = require('node:fs') as typeof fs;
-    // eslint-disable-next-line @typescript-eslint/no-require-imports
-    const pathSync = require('node:path') as typeof path;
-    const vibeDir = pathSync.join(sessionDir, '.vibe', 'conversations');
-    const dirs = fsSync.readdirSync(vibeDir);
-    let latest: { mtime: number; file: string } | null = null;
-    for (const dir of dirs) {
-      const file = pathSync.join(vibeDir, dir, 'state.json');
-      try {
-        const stat = fsSync.statSync(file);
-        if (!latest || stat.mtimeMs > latest.mtime) {
-          latest = { mtime: stat.mtimeMs, file };
-        }
-      } catch {
-        // unreadable entry — skip silently
-      }
-    }
-    if (!latest) return null;
-    const state = JSON.parse(
-      fsSync.readFileSync(latest.file, 'utf8')
-    ) as StateJson;
-    if (!state.currentPhase && !state.workflowName) return null;
-    return {
-      phase: state.currentPhase ?? '—',
-      workflow: state.workflowName ?? '—',
-    };
-  } catch {
-    return null;
-  }
-}
-
 // eslint-disable-next-line @typescript-eslint/require-await -- TuiPlugin signature requires Promise<void>; plugin body is synchronous
 const tui: TuiPlugin = async api => {
   api.slots.register({
@@ -145,9 +102,11 @@ const tui: TuiPlugin = async api => {
         // not only after the first tool call.
         const dir = api.state.path.directory;
         if (dir) {
-          // Try session ID-based lookup first, fall back to most recent state
+          // ONLY use session ID-based lookup. Do NOT fall back to readLatestState,
+          // as that would show workflow state from a different session.
+          // If no matching session state exists, that means no workflow is active in this session.
           const stateBySession = readStateBySessionId(dir, props.session_id);
-          setState(stateBySession || readLatestState(dir));
+          setState(stateBySession);
         }
 
         const offPart = api.event.on('message.part.updated', e => {
@@ -158,23 +117,28 @@ const tui: TuiPlugin = async api => {
           if (part.type !== 'tool') return;
           if (!part.tool || !WORKFLOW_TOOLS.has(part.tool)) return;
           if (!dir) return;
-          // Use session ID-based lookup to get the correct state for this session
+          // ONLY use session ID-based lookup. Do NOT fall back to readLatestState,
+          // as that would show workflow state from a different session.
           const stateBySession = readStateBySessionId(dir, props.session_id);
-          setState(stateBySession || readLatestState(dir));
+          setState(stateBySession);
         });
         onCleanup(offPart);
 
         // eslint-disable-next-line @typescript-eslint/no-unsafe-return -- JSX element typed as `error` by @opentui/solid's JSX types; safe at runtime
         return (
-          <box flexDirection="column" visible={!!state()}>
+          <box flexDirection="column">
             <text fg={theme().text}>
               <b>Workflow</b>
             </text>
-            <text fg={theme().textMuted}>
-              {state()?.workflow}:{' '}
-              {/* eslint-disable-next-line solid/style-prop -- `fg` is an OpenTUI-specific style prop, not a standard CSS property */}
-              <span style={{ fg: theme().text }}>{state()?.phase}</span>
-            </text>
+            {state() ? (
+              <text fg={theme().textMuted}>
+                {state()?.workflow}:{' '}
+                {/* eslint-disable-next-line solid/style-prop -- `fg` is an OpenTUI-specific style prop, not a standard CSS property */}
+                <span style={{ fg: theme().text }}>{state()?.phase}</span>
+              </text>
+            ) : (
+              <text fg={theme().textMuted}>No Active Workflow</text>
+            )}
           </box>
         );
       },
