Skip to content

Gen 9 follow-ups from #880 (polish + smaller deferred items) #889

Description

@codemonkey85

Umbrella tracker for smaller items deferred from PR #880 / the #333 implementation plan. Each bullet is independent and any one could be picked up as a small PR.

Items

  • Force-all Colorful Screws variant. `ColorfulScrew9a` exposes both `CollectScrews(sav)` (smart, returns count) and `SetAllScrews(sav, collected: bool)` (brute-force, supports un-collecting). `TrainerInfoSav9ZaSection` today only wires `CollectScrews`. Plan called out a "secret `SetAllScrews` behind a 'Force all' sub-action" for power users who want to wipe screw state. Niche; add behind a modifier-click or a separate action.

  • Donut Generator dialog (range-based templated generator). PKHeX has a separate `SAV_DonutGenerator9a` form that creates N donuts with user-selected flavors over a slot range (`SetRandomShinyTemplateRange(flavorOptions, start, end)`). `Donut9Dialog` currently exposes whole-list bulk actions (`Shiny Template (All 999)` / `Random Lv3` / `Clone Selected`) but not the ranged generator. Plan open question Adopt MudBlazor #4 asked: bundle or split — we split.

  • Donut flavor profile radial chart. PKHeX renders a Spicy/Fresh/Sweet/Bitter/Sour pentagonal chart per donut. Numeric stats are already present; the chart is purely visual. Plan open question Fix MAUI #3 deferred to v2.

  • Unit tests on the Gen 9 `Unlock All …` Trainer-tab actions. Plan called for xUnit tests asserting each button flips the expected SCBlock entries to `Bool2`. `TrainerInfoSav9SvSection` now owns the helpers (`UnlockSvFlyLocations` over `SvFlyLocationBlockNames`, `UnlockSvBikeUpgrades`) and `TrainerInfoSav9ZaSection` owns `CollectZaTechnicalMachines` / `CollectZaColorfulScrews` — straightforward to test against a synthetic `SAV9SV` / `SAV9ZA`.

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions