Track: breaking changes to address on next PKHeX.Core NuGet bump (> 26.5.5)

[codemonkey85]

@
Living tracker for PKHeX.Core source changes (committed upstream, not yet released on NuGet) that will require code changes in PKMDS when we bump the PKHeX.Core package past the current pin.

Current state (2026-06-01): pinned PKHeX.Core 26.5.5 in Directory.Packages.props; latest published NuGet is also 26.5.5, so no action needed yet. This issue collects what to fix the moment a newer package ships. Add to it as upstream evolves.

---

⚠️ Breaking changes (build will fail until fixed)

1. SAV4HGSS.PokeathlonPoints removed → Pokeathlon4 substructure

• Upstream: PKHeX commit 300953128 ("initial pokeathlon", 2026-05-25). The flat SAV4HGSS.PokeathlonPoints property was replaced by a Pokeathlon4 substructure exposed as SAV4HGSS.Pokeathlon.
• Affected site: Pkmds.Rcl/Components/MainTabPages/TrainerInfoTab.razor.cs (~line 457, GetExtraCurrencies, the SAV4HGSS hgss case).
• Fix:

  // before
  hgss.PokeathlonPoints,
  v => hgss.PokeathlonPoints = v,
  uint.MaxValue);
  // after
  hgss.Pokeathlon.Points,
  v => hgss.Pokeathlon.Points = v,
  Pokeathlon4.MaxPoints);   // 99,999 — true game cap (old code used uint.MaxValue)

• Data note: same save offset (0xD9D4 + 0xB74 == 0xE548), so it is a pure data-compatible refactor; the new setter additionally clamps to the real 99,999 cap.

---

✅ Non-breaking improvements (flow through transparently on bump — no code change)

Listed for awareness / changelog only:

• 0428865d0 — Gen4: relax Korean↔International legality (fewer false "illegal" flags on KOR Gen4 mons).
• 801928d72 — handle KOR Gen2→Gen1 transfers (PK1 / StringConverter1).
• 93661ea50 — Gen4 GTS trade-rules tweak.
• 8e7e02add — SwSh Exeggutor static encounter (affects legality + Encounter DB results).
• ee2fd8428 — WA9 mystery-gift IV checking (affects Mystery Gift DB legality).
• Misc: checksum perf, localization/EV xmldoc tweaks, event-flag/translation data updates.

Verified unaffected: EntityConverter (ConvertToType / AllowIncompatibleConversion / IsConvertibleToFormat), EntityBlank, EntityDetection, EffortValues.Max12/255/252, PlayerBag (commit 0b6a1accd only added xmldoc + moved files; namespace still PKHeX.Core).

---

Checked against PKHeX master HEAD d2fe0cb5 (2026-06-01). Update this issue as new upstream commits land before the next release.
@