cleanup some rubocop todos

Author: andi

.rubocop_todo.yml

@@ -1,30 +1,30 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2026-06-25 14:22:00 UTC using RuboCop version 1.69.0.
+# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100000`
+# on 2026-06-25 14:47:51 UTC using RuboCop version 1.88.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 9
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: have_no, not_to
-Capybara/RSpec/NegationMatcher:
+# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
+# URISchemes: http, https
+Layout/LineLength:
   Exclude:
-    - 'spec/simple_navigation/renderer/breadcrumbs_spec.rb'
-    - 'spec/simple_navigation/renderer/links_spec.rb'
-    - 'spec/simple_navigation/renderer/list_spec.rb'
+    - 'generators/navigation_config/templates/config/navigation.rb'
+    - 'spec/simple_navigation/helpers_spec.rb'
 
 # Offense count: 1
-Lint/ShadowingOuterLocalVariable:
+# Configuration parameters: MaxRangeSize.
+Lint/MissingCopEnableDirective:
   Exclude:
-    - 'spec/spec_helper.rb'
+    - 'spec/simple_navigation/configuration_spec.rb'
 
 # Offense count: 11
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
     - 'generators/navigation_config/templates/config/navigation.rb'
@@ -68,15 +68,6 @@ RSpec/NamedSubject:
   Exclude:
     - 'spec/simple_navigation_spec.rb'
 
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/simple_navigation/item_spec.rb'
-    - 'spec/simple_navigation/renderer/list_spec.rb'
-
 # Offense count: 24
 RSpec/SubjectStub:
   Exclude:
@@ -100,40 +91,3 @@ RSpec/VerifiedDoubles:
     - 'spec/simple_navigation/renderer/base_spec.rb'
     - 'spec/simple_navigation_spec.rb'
     - 'spec/spec_helper.rb'
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# AllowedMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'spec/simple_navigation/helpers_spec.rb'
-    - 'spec/simple_navigation/item_container_spec.rb'
-    - 'spec/simple_navigation/item_spec.rb'
-    - 'spec/simple_navigation_spec.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: .
-# SupportedStyles: same_as_string_literals, single_quotes, double_quotes
-Style/QuotedSymbols:
-  EnforcedStyle: double_quotes
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'lib/simple_navigation/item.rb'
-    - 'spec/simple_navigation/item_spec.rb'
-
-# Offense count: 19
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 190

lib/simple_navigation/configuration.rb

@@ -74,7 +74,9 @@ def id_generator
     # See SimpleNavigation::ItemAdapter for more details.
     #
     def items(items_provider = nil, &block)
-      raise('please specify either items_provider or block, but not both') if (items_provider && block) || (items_provider.nil? && block.nil?)
+      if (items_provider && block) || (items_provider.nil? && block.nil?)
+        raise('please specify either items_provider or block, but not both')
+      end
 
       self.primary_navigation = ItemContainer.new
 

lib/simple_navigation/item.rb

@@ -93,7 +93,7 @@ def method
     def link_html_options
       @link_html_options ||= begin
         link_options = options[:link_html] || {}
-        link_options[:"aria-current"] = "page" if !selected_by_subnav? && selected_by_condition?
+        link_options[:'aria-current'] = 'page' if !selected_by_subnav? && selected_by_condition?
         link_options
       end
     end

spec/integration/rendering_navigation_spec.rb

@@ -8,8 +8,8 @@
   scenario 'Rendering basic navigation', type: :feature do # rubocop:disable RSpec/MultipleExpectations
     visit '/base_spec'
 
-    expect(page).to have_content('Item 1')
-    expect(page).to have_content('Item 2')
+    expect(page).to have_text('Item 1')
+    expect(page).to have_text('Item 2')
     expect(page).to have_css('li.item_1 a#link_1')
     expect(page).to have_css('li.item_2 a#link_2')
   end

spec/simple_navigation/adapters/rails_spec.rb

@@ -185,7 +185,9 @@
         before { adapter.instance_variable_set(:@template, nil) }
 
         it 'raises an exception' do
-          expect { adapter.context_for_eval }.to raise_error(RuntimeError, 'no context set for evaluation the config file')
+          expect do
+            adapter.context_for_eval
+          end.to raise_error(RuntimeError, 'no context set for evaluation the config file')
         end
       end
     end

spec/simple_navigation/adapters/sinatra_spec.rb

@@ -11,7 +11,9 @@
     context "when adapter's context is not set" do
       it 'raises an exception' do
         allow(adapter).to receive_messages(context: nil)
-        expect { adapter.context_for_eval }.to raise_error(RuntimeError, 'no context set for evaluation the config file')
+        expect do
+          adapter.context_for_eval
+        end.to raise_error(RuntimeError, 'no context set for evaluation the config file')
       end
     end
 

spec/simple_navigation/config_file_finder_spec.rb

@@ -24,7 +24,9 @@
 
       context 'and no navigation.rb file is found in the paths' do
         it 'raises an exception' do
-          expect { finder.find(context) }.to raise_error(RuntimeError, /Config file 'navigation.rb' not found in path\(s\)/)
+          expect do
+            finder.find(context)
+          end.to raise_error(RuntimeError, /Config file 'navigation.rb' not found in path\(s\)/)
         end
       end
     end
@@ -42,7 +44,9 @@
 
       context 'and no other_navigation.rb file is found in the paths' do
         it 'raise an exception' do
-          expect { finder.find(context) }.to raise_error(RuntimeError, /Config file 'other_navigation.rb' not found in path\(s\)/)
+          expect do
+            finder.find(context)
+          end.to raise_error(RuntimeError, /Config file 'other_navigation.rb' not found in path\(s\)/)
         end
       end
     end

spec/simple_navigation/configuration_spec.rb

@@ -90,7 +90,11 @@
         let(:provider) { double(:provider) }
 
         it 'raises an exception' do
-          expect { config.items(provider) {} }.to raise_error(RuntimeError, 'please specify either items_provider or block, but not both') # rubocop:disable Lint/EmptyBlock
+          # rubocop:disable Lint/EmptyBlock
+          expect do
+            config.items(provider) do
+            end
+          end.to raise_error(RuntimeError, 'please specify either items_provider or block, but not both')
         end
       end
 
@@ -140,7 +144,9 @@
 
       context 'when items_provider is not specified' do
         it 'raises an exception' do
-          expect { config.items }.to raise_error(RuntimeError, 'please specify either items_provider or block, but not both')
+          expect do
+            config.items
+          end.to raise_error(RuntimeError, 'please specify either items_provider or block, but not both')
         end
       end
     end

spec/simple_navigation/helpers_spec.rb

@@ -368,18 +368,18 @@
 
         context "and the active_item_container isn't set" do
           it "doesn't raise an exception" do
-            expect {
+            expect do
               controller.render_navigation(level: 2)
-            }.not_to raise_error
+            end.not_to raise_error
           end
         end
       end
 
       context "and its value isn't a valid level" do
         it 'raises an exception' do
-          expect {
+          expect do
             controller.render_navigation(level: :invalid)
-          }.to raise_error(ArgumentError, 'Invalid navigation level: invalid')
+          end.to raise_error(ArgumentError, 'Invalid navigation level: invalid')
         end
       end
     end
@@ -395,17 +395,20 @@
 
     context 'when a block is given' do
       it 'calls the block passing it an item container' do
-        expect { |blk|
+        expect do |blk|
           controller.render_navigation(&blk)
-        }.to yield_with_args(SimpleNavigation::ItemContainer)
+        end.to yield_with_args(SimpleNavigation::ItemContainer)
       end
     end
 
     context 'when no primary configuration is defined' do
       before { allow(SimpleNavigation).to receive_messages(primary_navigation: nil) }
 
       it 'raises an exception' do
-        expect { controller.render_navigation }.to raise_error(RuntimeError, 'no primary navigation defined, either use a navigation config file or pass items directly to render_navigation')
+        expect do
+          controller.render_navigation
+        end.to raise_error(RuntimeError,
+                           'no primary navigation defined, either use a navigation config file or pass items directly to render_navigation')
       end
     end
 

spec/simple_navigation/item_container_spec.rb

@@ -220,9 +220,9 @@
       it 'yields a new ItemContainer' do
         allow_any_instance_of(SimpleNavigation::Item).to receive_messages(sub_navigation: sub_container) # rubocop:disable RSpec/AnyInstance
 
-        expect { |blk|
+        expect do |blk|
           item_container.item('key', 'name', 'url', options, &blk)
-        }.to yield_with_args(sub_container)
+        end.to yield_with_args(sub_container)
       end
 
       it 'creates a new Item with the given params and block' do
@@ -314,9 +314,9 @@
         end
 
         it 'does not raise an exception' do
-          expect {
+          expect do
             item_container.item('key', 'name', 'url', options)
-          }.not_to raise_error
+          end.not_to raise_error
         end
       end
 
@@ -433,9 +433,9 @@
 
         context 'and it is not a proc or a method' do
           it 'raises an error' do
-            expect {
+            expect do
               item_container.item('key', 'name', 'url', { if: 'text' })
-            }.to raise_error(ArgumentError, ':if or :unless must be procs or lambdas')
+            end.to raise_error(ArgumentError, ':if or :unless must be procs or lambdas')
           end
         end
       end