Release/7.1 phpstan errors (#468)

Author: tobiasschutter

classes/Admin/Tooltip.php

@@ -18,24 +18,11 @@ class Tooltip
 
     private string $position = 'right';
 
-    public function __construct(string $id, array $args = [])
+    public function __construct(string $id)
     {
         $this->id = $id;
         $this->title = __('Notice', 'codepress-admin-columns');
         $this->link_label = __('Instructions', 'codepress-admin-columns');
-
-        $this->populate($args);
-    }
-
-    private function populate($args): void
-    {
-        foreach ($args as $key => $value) {
-            $method = 'set_' . $key;
-
-            if (method_exists($this, $method)) {
-                call_user_func([$this, $method], $value);
-            }
-        }
     }
 
     public function set_id(string $id): Tooltip

classes/Admin/Type/MenuGroup.php

@@ -4,6 +4,8 @@
 
 namespace AC\Admin\Type;
 
+use LogicException;
+
 class MenuGroup
 {
     private string $name;
@@ -50,6 +52,10 @@ public function has_icon(): bool
 
     public function get_icon(): string
     {
+        if (null === $this->icon) {
+            throw new LogicException('Empty icon');
+        }
+
         return $this->icon;
     }
 

classes/Asset/Enqueueable.php

@@ -26,11 +26,19 @@ public function get_handle(): string
 
     protected function get_version(): ?int
     {
+        if (null === $this->location) {
+            return null;
+        }
+
         $path = $this->location->get_path();
 
-        return file_exists($path)
-            ? filemtime($path)
-            : null;
+        if (! file_exists($path)) {
+            return null;
+        }
+
+        $mtime = filemtime($path);
+
+        return false === $mtime ? null : $mtime;
     }
 
     abstract public function register(): void;

classes/Column/ColumnLabelTrait.php

@@ -10,7 +10,10 @@ trait ColumnLabelTrait
 {
     public function get_column_label(Column $column): string
     {
-        $label = $column->get_setting('label')->get_input()->get_value();
+        $setting = $column->get_setting('label');
+        $label = $setting
+            ? (string)$setting->get_input()->get_value()
+            : '';
 
         if (str_contains($label, 'dashicons')) {
             return trim($label);

classes/ColumnSize/ListStorage.php

@@ -66,7 +66,13 @@ private function create(Column $column): ?ColumnWidth
             return null;
         }
 
-        $unit = (string) $column->get_setting('width_unit')->get_input()->get_value();
+        $unit_setting = $column->get_setting('width_unit');
+
+        if (! $unit_setting) {
+            return null;
+        }
+
+        $unit = (string) $unit_setting->get_input()->get_value();
 
         try {
             $width = new ColumnWidth($unit, $width);

classes/Deprecated/Hook.php

@@ -5,6 +5,7 @@
 namespace AC\Deprecated;
 
 use Closure;
+use LogicException;
 use ReflectionFunction;
 
 class Hook
@@ -34,6 +35,10 @@ public function get_version(): string
 
     public function get_replacement(): string
     {
+        if (null === $this->replacement) {
+            throw new LogicException('Empty replacement');
+        }
+
         return $this->replacement;
     }
 
@@ -49,7 +54,7 @@ public function has_hook(): bool
 
     public function usage_count(): int
     {
-        return count($this->get_callbacks());
+        return count($this->get_callbacks() ?? []);
     }
 
     private function get_filter_callbacks(): array

classes/Entity/Plugin.php

@@ -54,7 +54,7 @@ public function get_url(): string
         return $this->url;
     }
 
-    public function get_location(): Location
+    public function get_location(): Location\Absolute
     {
         return new Location\Absolute($this->url, $this->dir);
     }

classes/Form/Element/Checkbox.php

@@ -62,7 +62,7 @@ private function get_elements(): ?array
         $value = (array)$this->get_value();
 
         foreach ($options as $key => $label) {
-            $input = new Input($this->get_name());
+            $input = new Input((string)$this->get_name());
 
             $input
                 ->set_value($key)

classes/Formatter/ConditionalValue.php

@@ -4,6 +4,7 @@
 
 namespace AC\Formatter;
 
+use AC\Exception\ValueNotFoundException;
 use AC\Formatter;
 use AC\Type\Value;
 
@@ -25,7 +26,13 @@ public function format(Value $value): Value
             return $value;
         }
 
-        return $this->formatter->format($value);
+        $formatted = $this->formatter->format($value);
+
+        if (! $formatted instanceof Value) {
+            throw ValueNotFoundException::from_id($value->get_id());
+        }
+
+        return $formatted;
     }
 
 }

classes/Formatter/ExplodeToCollection.php

@@ -7,6 +7,7 @@
 use AC\Exception\ValueNotFoundException;
 use AC\Type\Value;
 use AC\Type\ValueCollection;
+use InvalidArgumentException;
 
 final class ExplodeToCollection extends ArrayToCollection
 {
@@ -16,14 +17,18 @@ public function __construct(string $separator)
     {
         parent::__construct();
 
+        if ('' === $separator) {
+            throw new InvalidArgumentException('Separator can not be empty.');
+        }
+
         $this->separator = $separator;
     }
 
     public function format(Value $value): ValueCollection
     {
         $result = explode($this->separator, (string)$value);
 
-        if (false === $result || $result === ['']) {
+        if ($result === ['']) {
             throw new ValueNotFoundException('No values found');
         }