fix: prevent process.exit(1) on single user API failure (#61)#128
Merged
jagdish-15 merged 1 commit intoJun 8, 2026
Merged
Conversation
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. A maintainer will review your submission shortly. |
jagdish-15
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents
process.exit(1)when a single user's LeetCode API call fails. Previously, one transient API failure would kill the entire sync cycle — losing all previously fetched data for other users. Now, failed users are logged and skipped, and syncing continues for the remaining users.Additionally adds a 15-second axios timeout (default is
0= infinite) to prevent a hanging request from silently destroying the entire 6-hour CI run.Linked Issue
Fixes #61
Changes Made
{ timeout: 15000 }toaxios.get()call — prevents infinite hangs on unresponsive APIprocess.exit(1)toreturn nullon API failure — keeps the process alivecontinue— skips failed users gracefullyType of Change
Testing
Verification performed:
node --check scripts/sync-leaderboard.js— Syntax OKnpx prettier --check "frontend/**/*.{html,css,js}" "scripts/**/*.js" "server.js"— All files passChecklist
Screenshots / Screen Recording
N/A — Backend-only change with no UI impact.