Feature/display global ranking#215
Conversation
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. Formatting and Branching
|
| if (!profileRankingEl) return; | ||
|
|
||
| if (data && data.ranking) { | ||
| profileRankingEl.textContent = `Number(data.ranking).toLocaleString()`; |
There was a problem hiding this comment.
| profileRankingEl.textContent = `Number(data.ranking).toLocaleString()`; | |
| profileRankingEl.textContent = Number(data.ranking).toLocaleString(); |
This'll cause the variable to be rendered as a string rather than rendering the actual value associated with it
| studentHistoryArray = rawPerformanceData.history || []; | ||
| console.log("Successfully fetched user data:", studentHistoryArray); |
There was a problem hiding this comment.
| studentHistoryArray = rawPerformanceData.history || []; | |
| console.log("Successfully fetched user data:", studentHistoryArray); | |
| userDataArray = rawPerformanceData.history || []; |
This variable name change causes the graphs to stop rendering entirely. The rest of the file still uses userDataArray, but it was renamed only here and not in the other places where it's referenced.
Let's keep the existing variable name unless all references are updated together.
Also, let's remove this log entry
Description
Renamed 'Global Rank' references to 'Profile Rank'. This prevents user confusion since LeetCode already provides a separate, contest-specific global ranking system on profiles. create a horizontal layout to store all rankings and displayed profile rank
in user profile page
Linked Issue
Fixes #80
Changes Made
PROFILE:.global-rankingtoprofile-rankingto reflect the new nomenclature.historical-graphs.js) to target the revised element ID.Type of Change
Testing
Checklist
npx prettier --write .before submittingfeature/*branch, not themainbranchScreenshots / Screen Recording