Skip to content

fix: remove continue-on-error masking sync workflow failures (#224)#231

Open
rishab11250 wants to merge 1 commit into
codepvg:mainfrom
rishab11250:feature/fix-sync-workflow-failures-issue224
Open

fix: remove continue-on-error masking sync workflow failures (#224)#231
rishab11250 wants to merge 1 commit into
codepvg:mainfrom
rishab11250:feature/fix-sync-workflow-failures-issue224

Conversation

@rishab11250

Copy link
Copy Markdown
Contributor

Description

Removes continue-on-error: true from the Run sync loop step in sync-leaderboard.yml which was silently swallowing all workflow failures. Replaces it with explicit failure tracking across all 72 iterations, annotated error output, auto-creation of GitHub issues after 3 consecutive failures, and a final summary that causes the workflow step to show red when failures occur.

Linked Issue

Fixes #224

Changes Made

  • Added issues: write permission to allow gh issue create
  • Removed continue-on-error: true from the Run sync loop step
  • Added failure tracking counters (SUCCESS_COUNT, FAIL_COUNT, CONSECUTIVE_FAILS, ISSUE_CREATED)
  • Wrapped node scripts/sync-leaderboard.js in if/else to track exit codes instead of silently continuing
  • Prints ::error:: annotations per failure visible in the GitHub Actions UI
  • Auto-creates a GitHub issue (with type:devops label, run link, and failure details) after 3 consecutive failures, limited to once per run
  • Prints a final summary block showing total iterations, successful count, and failed count
  • Exits with code 1 if any iteration failed so the step shows ❌ status
  • Preserved || true on git pull --rebase as expected transient errors

Type of Change

  • Bug fix
  • New feature
  • UI/Visual update
  • Documentation update
  • Refactor

Testing

  • Tested locally
  • Tested on mobile viewport (if applicable)
  • No console errors introduced
  • Verified with npx prettier --check .github/workflows/sync-leaderboard.yml

Checklist

  • My code follows the project's coding style
  • I have formatted my code locally by running npx prettier --write . before submitting
  • I am submitting my PR from a dedicated feature/* branch, not the main branch
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have updated documentation if required
  • I have linked the relevant issue

Screenshots / Screen Recording

N/A — workflow-only change, no UI impact.

…#224)

Remove continue-on-error: true from sync-leaderboard.yml and replace with explicit failure tracking across 72 iterations. Track success/fail counts, print ::error:: annotations per failure, auto-create GitHub issue after 3 consecutive failures, and print final summary. Exit with code 1 if any iteration failed so the step shows red.
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request.

Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully.

Formatting and Branching

  • Please confirm you have formatted your code locally using npx prettier --write ., or you can simply comment /format on this PR to have our bot do it for you!
  • Ensure this PR is made from a feature/* branch and not main.

Note: This project is currently maintained by a solo maintainer, so reviews and responses may sometimes take a little time. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: sync-leaderboard.yml uses continue-on-error: true masking workflow failures

1 participant