fix: remove continue-on-error masking sync workflow failures (#224)#231
Merged
jagdish-15 merged 1 commit intoJun 21, 2026
Merged
Conversation
…#224) Remove continue-on-error: true from sync-leaderboard.yml and replace with explicit failure tracking across 72 iterations. Track success/fail counts, print ::error:: annotations per failure, auto-create GitHub issue after 3 consecutive failures, and print final summary. Exit with code 1 if any iteration failed so the step shows red.
Contributor
|
Thank you for submitting a pull request. Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully. Formatting and Branching
|
jagdish-15
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
continue-on-error: truefrom theRun sync loopstep insync-leaderboard.ymlwhich was silently swallowing all workflow failures. Replaces it with explicit failure tracking across all 72 iterations, annotated error output, auto-creation of GitHub issues after 3 consecutive failures, and a final summary that causes the workflow step to show red when failures occur.Linked Issue
Fixes #224
Changes Made
issues: writepermission to allowgh issue createcontinue-on-error: truefrom theRun sync loopstepSUCCESS_COUNT,FAIL_COUNT,CONSECUTIVE_FAILS,ISSUE_CREATED)node scripts/sync-leaderboard.jsinif/elseto track exit codes instead of silently continuing::error::annotations per failure visible in the GitHub Actions UItype:devopslabel, run link, and failure details) after 3 consecutive failures, limited to once per run|| trueongit pull --rebaseas expected transient errorsType of Change
Testing
npx prettier --check .github/workflows/sync-leaderboard.ymlChecklist
npx prettier --write .before submittingfeature/*branch, not themainbranchScreenshots / Screen Recording
N/A — workflow-only change, no UI impact.